refactor(rebalancer): extract getOverrideExecutionType helper to reduce duplication

Author: Mo-Hussain

typescript/rebalancer/src/config/types.ts

@@ -512,6 +512,20 @@ export function getChainExecutionType(
   return chainConfig?.executionType ?? ExecutionType.MovableCollateral;
 }
 
+/**
+ * Extract the executionType from an override config object.
+ * Returns undefined if the override config doesn't have an executionType field.
+ */
+export function getOverrideExecutionType(
+  overrideConfig: unknown,
+): ExecutionType | undefined {
+  return typeof overrideConfig === 'object' &&
+    overrideConfig !== null &&
+    'executionType' in overrideConfig
+    ? (overrideConfig as { executionType?: ExecutionType }).executionType
+    : undefined;
+}
+
 /**
  * Get the names of all chains that use inventory execution type.
  * Includes both top-level inventory chains and override destination chains
@@ -540,15 +554,7 @@ export function getInventoryChainNames(strategies: StrategyConfig[]): string[] {
             return overrideEntries
               .filter(([, overrideConfig]) => {
                 const overrideExecutionType =
-                  typeof overrideConfig === 'object' &&
-                  overrideConfig !== null &&
-                  'executionType' in overrideConfig
-                    ? (
-                        overrideConfig as {
-                          executionType?: ExecutionType;
-                        }
-                      ).executionType
-                    : undefined;
+                  getOverrideExecutionType(overrideConfig);
 
                 return (
                   (overrideExecutionType ??
@@ -582,15 +588,7 @@ export function getInventoryOriginChainNames(
               chainConfig.override,
             ).some((overrideConfig) => {
               const overrideExecutionType =
-                typeof overrideConfig === 'object' &&
-                overrideConfig !== null &&
-                'executionType' in overrideConfig
-                  ? (
-                      overrideConfig as {
-                        executionType?: ExecutionType;
-                      }
-                    ).executionType
-                  : undefined;
+                getOverrideExecutionType(overrideConfig);
 
               return (
                 (overrideExecutionType ??

typescript/rebalancer/src/factories/RebalancerContextFactory.ts

@@ -27,6 +27,7 @@ import {
   getAllBridges,
   getInventoryChainNames,
   getInventoryOriginChainNames,
+  getOverrideExecutionType,
   getStrategyChainConfig,
   getStrategyChainNames,
 } from '../config/types.js';
@@ -702,12 +703,7 @@ export class RebalancerContextFactory {
 
         return Object.values(chainConfig.override).some((overrideConfig) => {
           const overrideExecutionType =
-            typeof overrideConfig === 'object' &&
-            overrideConfig !== null &&
-            'executionType' in overrideConfig
-              ? (overrideConfig as { executionType?: ExecutionType })
-                  .executionType
-              : undefined;
+            getOverrideExecutionType(overrideConfig);
 
           return (
             (overrideExecutionType ??