fix(rebalancer): await transfer receipts in e2e harness to prevent anvil auto-mine race (#8346)

Author: Mo-Hussain

typescript/rebalancer/src/e2e/collateral-deficit.e2e-test.ts

@@ -165,7 +165,8 @@ describe('Collateral Deficit E2E', function () {
       deployedAddresses.tokens.anvil1,
       deployer,
     );
-    await token.transfer(userAddress, transferAmount.mul(2));
+    const tx = await token.transfer(userAddress, transferAmount.mul(2));
+    await tx.wait();
 
     const transferResult = await executeWarpTransfer(
       context.multiProvider,

typescript/rebalancer/src/e2e/composite.e2e-test.ts

@@ -135,7 +135,8 @@ describe('CompositeStrategy E2E', function () {
       deployedAddresses.tokens.anvil1,
       deployer,
     );
-    await token.transfer(userAddress, transferAmount.mul(2));
+    const tx = await token.transfer(userAddress, transferAmount.mul(2));
+    await tx.wait();
 
     const transferResult = await executeWarpTransfer(
       context.multiProvider,

typescript/rebalancer/src/e2e/harness/BridgeSetup.ts

@@ -26,7 +26,8 @@ export async function setupCollateralBalances(
     // We need to set the exact balance, so transfer (targetBalance - currentBalance) if needed
     if (targetBalance.gt(currentBalance)) {
       const diff = targetBalance.sub(currentBalance);
-      await token.transfer(routersByChain[chain], diff);
+      const tx = await token.transfer(routersByChain[chain], diff);
+      await tx.wait();
     }
 
     // Verify

typescript/rebalancer/src/e2e/harness/Erc20InventoryLocalDeploymentManager.ts

@@ -149,8 +149,16 @@ export class Erc20InventoryLocalDeploymentManager extends BaseLocalDeploymentMan
         tokens[chain.name].address,
         deployer,
       );
-      await token.transfer(bridgeRouters[chain.name].address, bridgeSeedAmount);
-      await token.transfer(this.inventorySignerAddress, signerErc20Amount);
+      const tx1 = await token.transfer(
+        bridgeRouters[chain.name].address,
+        bridgeSeedAmount,
+      );
+      await tx1.wait();
+      const tx2 = await token.transfer(
+        this.inventorySignerAddress,
+        signerErc20Amount,
+      );
+      await tx2.wait();
     }
 
     return {

typescript/rebalancer/src/e2e/harness/Erc20LocalDeploymentManager.ts

@@ -151,14 +151,16 @@ export class Erc20LocalDeploymentManager extends BaseLocalDeploymentManager<Depl
         tokens[chain.name].address,
         deployer,
       );
-      await token.transfer(
+      const tx1 = await token.transfer(
         bridgeRouters1[chain.name].address,
         bridgeSeedAmount,
       );
-      await token.transfer(
+      await tx1.wait();
+      const tx2 = await token.transfer(
         bridgeRouters2[chain.name].address,
         bridgeSeedAmount,
       );
+      await tx2.wait();
     }
 
     return {

typescript/rebalancer/src/e2e/harness/MixedLocalDeploymentManager.ts

@@ -160,8 +160,16 @@ export class MixedLocalDeploymentManager extends BaseLocalDeploymentManager<Erc2
         tokens[chain.name].address,
         deployer,
       );
-      await token.transfer(bridgeRouters[chain.name].address, bridgeSeedAmount);
-      await token.transfer(this.inventorySignerAddress, signerErc20Amount);
+      const tx1 = await token.transfer(
+        bridgeRouters[chain.name].address,
+        bridgeSeedAmount,
+      );
+      await tx1.wait();
+      const tx2 = await token.transfer(
+        this.inventorySignerAddress,
+        signerErc20Amount,
+      );
+      await tx2.wait();
     }
 
     return {

typescript/rebalancer/src/e2e/harness/TestRebalancer.ts

@@ -498,7 +498,8 @@ export class TestRebalancerBuilder {
           provider,
         );
         const token = ERC20Test__factory.connect(tokenAddress, deployerSigner);
-        await token.transfer(monitoredRouteAddress, balance);
+        const tx = await token.transfer(monitoredRouteAddress, balance);
+        await tx.wait();
       }
 
       this.logger.info(
@@ -610,14 +611,19 @@ export class TestRebalancerBuilder {
 
         const current = await tokenAsSigner.balanceOf(signerAddress);
         if (current.gt(0)) {
-          await tokenAsSigner.transfer(deployerSigner.address, current);
+          const tx1 = await tokenAsSigner.transfer(
+            deployerSigner.address,
+            current,
+          );
+          await tx1.wait();
         }
 
         if (BigNumber.from(balance).gt(0)) {
-          await tokenAsDeployer.transfer(
+          const tx2 = await tokenAsDeployer.transfer(
             signerAddress,
             BigNumber.from(balance),
           );
+          await tx2.wait();
         }
       }