chore(provider sdks): remove old alt vm signer and provider methods that have been replaced by the artifact api [PART 1] (#8593)

Author: xeno097

.changeset/slim-altvm-interfaces.md

@@ -0,0 +1,15 @@
+---
+'@hyperlane-xyz/provider-sdk': major
+'@hyperlane-xyz/sealevel-sdk': major
+'@hyperlane-xyz/cosmos-sdk': major
+'@hyperlane-xyz/radix-sdk': major
+'@hyperlane-xyz/starknet-sdk': major
+'@hyperlane-xyz/aleo-sdk': major
+'@hyperlane-xyz/tron-sdk': major
+'@hyperlane-xyz/deploy-sdk': major
+'@hyperlane-xyz/cli': major
+---
+
+IProvider and ISigner interfaces were slimmed to their minimal surface. IProvider was reduced from 53 to 22 query-only methods by removing all get*Transaction methods. ISigner was reduced from 36 to 5 infrastructure methods by removing all action methods (createMailbox, setDefaultIsm, enrollRemoteRouter, etc.). Transaction building is now handled exclusively by artifact managers using concrete class methods or standalone helper functions.
+
+Throwing stubs were removed from SVM, Cosmos, Radix, and Starknet provider/signer implementations. Old action-method-based e2e tests were replaced with artifact API equivalents. Cosmos routing ISM writer was fixed to handle domain route updates correctly via remove + re-add.

typescript/aleo-sdk/src/testing/utils.ts

@@ -1,8 +1,6 @@
-import { type AltVM } from '@hyperlane-xyz/provider-sdk';
 import { type TestChainMetadata } from '@hyperlane-xyz/provider-sdk/chain';
 
 import { AleoSigner } from '../clients/signer.js';
-import { type AleoReceipt, type AleoTransaction } from '../utils/types.js';
 
 import {
   TEST_ALEO_CHAIN_METADATA,
@@ -19,7 +17,7 @@ import {
 export async function createSigner(
   privateKey: string = TEST_ALEO_PRIVATE_KEY,
   chainMetadata: TestChainMetadata = TEST_ALEO_CHAIN_METADATA,
-): Promise<AltVM.ISigner<AleoTransaction, AleoReceipt>> {
+): Promise<AleoSigner> {
   return AleoSigner.connectWithSigner([chainMetadata.rpcUrl], privateKey, {
     metadata: chainMetadata,
   });
@@ -35,6 +33,6 @@ export async function createSigner(
 export async function createSigners(
   privateKeys: string[],
   chainMetadata: TestChainMetadata = TEST_ALEO_CHAIN_METADATA,
-): Promise<AltVM.ISigner<AleoTransaction, AleoReceipt>[]> {
+): Promise<AleoSigner[]> {
   return Promise.all(privateKeys.map((pk) => createSigner(pk, chainMetadata)));
 }

typescript/aleo-sdk/src/tests/1_interchain_security.e2e-test.ts

@@ -3,18 +3,15 @@ import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import { step } from 'mocha-steps';
 
-import { type AltVM } from '@hyperlane-xyz/provider-sdk';
-
 import { AleoSigner } from '../clients/signer.js';
-import { type AleoReceipt, type AleoTransaction } from '../utils/types.js';
 
 chai.use(chaiAsPromised);
 const { expect } = chai;
 
 describe('1. aleo sdk interchain security e2e tests', async function () {
   this.timeout(100_000);
 
-  let signer: AltVM.ISigner<AleoTransaction, AleoReceipt>;
+  let signer: AleoSigner;
 
   let noop_ism: string;
   let routing_ism: string;

typescript/aleo-sdk/src/tests/2_core.e2e-test.ts

@@ -2,15 +2,12 @@ import { Account } from '@provablehq/sdk';
 import { expect } from 'chai';
 import { step } from 'mocha-steps';
 
-import { type AltVM } from '@hyperlane-xyz/provider-sdk';
-
 import { AleoSigner } from '../clients/signer.js';
-import { type AleoReceipt, type AleoTransaction } from '../utils/types.js';
 
 describe('2. aleo sdk core e2e tests', async function () {
   this.timeout(100_000);
 
-  let signer: AltVM.ISigner<AleoTransaction, AleoReceipt>;
+  let signer: AleoSigner;
 
   let mailboxAddress: string;
   let ismAddress: string;

typescript/aleo-sdk/src/tests/3_post_dispatch.e2e-test.ts

@@ -2,15 +2,12 @@ import { Account } from '@provablehq/sdk';
 import { expect } from 'chai';
 import { step } from 'mocha-steps';
 
-import { type AltVM } from '@hyperlane-xyz/provider-sdk';
-
 import { AleoSigner } from '../clients/signer.js';
-import { type AleoReceipt, type AleoTransaction } from '../utils/types.js';
 
 describe('3. aleo sdk post dispatch e2e tests', async function () {
   this.timeout(100_000);
 
-  let signer: AltVM.ISigner<AleoTransaction, AleoReceipt>;
+  let signer: AleoSigner;
 
   let mailboxAddress: string;
   let igpAddress: string;

typescript/aleo-sdk/src/tests/4_warp.e2e-test.ts

@@ -21,12 +21,11 @@ import {
   fromAleoAddress,
   stringToU128,
 } from '../utils/helper.js';
-import { type AleoReceipt, type AleoTransaction } from '../utils/types.js';
 
 describe('4. aleo sdk warp e2e tests', async function () {
   this.timeout(100_000);
 
-  let signer: AltVM.ISigner<AleoTransaction, AleoReceipt>;
+  let signer: AleoSigner;
 
   let mailboxAddress: string;
   let collateralDenom: string;

typescript/aleo-sdk/src/tests/6_hook_artifacts.e2e-test.ts

@@ -2,7 +2,7 @@ import { expect } from 'chai';
 import { step } from 'mocha-steps';
 
 import { AltVM } from '@hyperlane-xyz/provider-sdk';
-import { HookType } from '@hyperlane-xyz/provider-sdk/altvm';
+import { HookType, type ISigner } from '@hyperlane-xyz/provider-sdk/altvm';
 import {
   type ArtifactDeployed,
   ArtifactState,
@@ -19,14 +19,12 @@ import { assert, normalizeConfig } from '@hyperlane-xyz/utils';
 
 import { AleoSigner } from '../clients/signer.js';
 import { AleoHookArtifactManager } from '../hook/hook-artifact-manager.js';
-import { type AleoReceipt, type AleoTransaction } from '../utils/types.js';
 
 describe('6. aleo sdk Hook artifacts e2e tests', async function () {
   this.timeout(100_000);
 
+  let signer: ISigner<AnnotatedTx, TxReceipt>;
   let aleoSigner: AleoSigner;
-  let signer: AltVM.ISigner<AleoTransaction, AleoReceipt>;
-  let providerSdkSigner: AltVM.ISigner<AnnotatedTx, TxReceipt>;
   let artifactManager: AleoHookArtifactManager;
   let mailboxAddress: string;
 
@@ -43,8 +41,6 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
     });
     signer = aleoSigner;
 
-    providerSdkSigner = signer as any;
-
     // Create a mailbox for hook testing
     const domainId = 1234;
     const mailbox = await aleoSigner.createMailbox({
@@ -64,7 +60,7 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
       // Create MerkleTree Hook using artifact writer
       const writer = artifactManager.createWriter(
         AltVM.HookType.MERKLE_TREE,
-        signer as any,
+        aleoSigner,
       );
 
       const [deployedArtifact] = await writer.create({
@@ -98,16 +94,16 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
       // Create IGP Hook using artifact writer
       const writer = artifactManager.createWriter(
         AltVM.HookType.INTERCHAIN_GAS_PAYMASTER,
-        signer as any,
+        aleoSigner,
       );
 
       const [deployedArtifact] = await writer.create({
         artifactState: ArtifactState.NEW,
         config: {
           type: AltVM.HookType.INTERCHAIN_GAS_PAYMASTER,
-          owner: signer.getSignerAddress(),
-          beneficiary: signer.getSignerAddress(),
-          oracleKey: signer.getSignerAddress(),
+          owner: aleoSigner.getSignerAddress(),
+          beneficiary: aleoSigner.getSignerAddress(),
+          oracleKey: aleoSigner.getSignerAddress(),
           overhead: {
             [DOMAIN_1]: 50000,
             [DOMAIN_2]: 75000,
@@ -140,14 +136,14 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
       expect(readHook.config.type).to.equal(
         AltVM.HookType.INTERCHAIN_GAS_PAYMASTER,
       );
-      expect(readHook.config.owner).to.equal(signer.getSignerAddress());
+      expect(readHook.config.owner).to.equal(aleoSigner.getSignerAddress());
 
       // Verify gas configs
       const expectedConfig = {
         type: AltVM.HookType.INTERCHAIN_GAS_PAYMASTER,
-        owner: signer.getSignerAddress(),
-        beneficiary: signer.getSignerAddress(),
-        oracleKey: signer.getSignerAddress(),
+        owner: aleoSigner.getSignerAddress(),
+        beneficiary: aleoSigner.getSignerAddress(),
+        oracleKey: aleoSigner.getSignerAddress(),
         overhead: {
           [DOMAIN_1]: 50000,
           [DOMAIN_2]: 75000,
@@ -173,7 +169,7 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
       // Update one of the gas configs using artifact writer
       const writer = artifactManager.createWriter(
         AltVM.HookType.INTERCHAIN_GAS_PAYMASTER,
-        signer as any,
+        aleoSigner,
       );
 
       // Read current config
@@ -208,7 +204,7 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
       // Execute update transactions
       const transactions = await writer.update(updatedArtifact);
       for (const tx of transactions) {
-        await providerSdkSigner.sendAndConfirmTransaction(tx);
+        await signer.sendAndConfirmTransaction(tx);
       }
 
       // Read and verify update
@@ -233,7 +229,7 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
       // Remove DOMAIN_2 config using artifact writer
       const writer = artifactManager.createWriter(
         AltVM.HookType.INTERCHAIN_GAS_PAYMASTER,
-        signer as any,
+        aleoSigner,
       );
 
       // Read current config
@@ -265,7 +261,7 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
       // Execute update transactions
       const transactions = await writer.update(updatedArtifact);
       for (const tx of transactions) {
-        await providerSdkSigner.sendAndConfirmTransaction(tx);
+        await signer.sendAndConfirmTransaction(tx);
       }
 
       // Read and verify removal
@@ -291,7 +287,7 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
         // Create IGP hook using the artifact writer with a different owner
         const writer = artifactManager.createWriter(
           AltVM.HookType.INTERCHAIN_GAS_PAYMASTER,
-          signer as any,
+          aleoSigner,
         );
 
         const [deployedArtifact] = await writer.create({
@@ -316,7 +312,9 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
         const readHook = await reader.read(deployedArtifact.deployed.address);
 
         expect(readHook.config.owner).to.equal(newOwnerAddress);
-        expect(readHook.config.owner).to.not.equal(signer.getSignerAddress());
+        expect(readHook.config.owner).to.not.equal(
+          aleoSigner.getSignerAddress(),
+        );
       },
     );
   });
@@ -328,7 +326,7 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
       // Create MerkleTree Hook
       const writer = artifactManager.createWriter(
         AltVM.HookType.MERKLE_TREE,
-        signer as any,
+        aleoSigner,
       );
 
       const [deployedHook] = await writer.create({
@@ -352,16 +350,16 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
       // Create IGP Hook
       const writer = artifactManager.createWriter(
         AltVM.HookType.INTERCHAIN_GAS_PAYMASTER,
-        signer as any,
+        aleoSigner,
       );
 
       const [deployedHook] = await writer.create({
         artifactState: ArtifactState.NEW,
         config: {
           type: AltVM.HookType.INTERCHAIN_GAS_PAYMASTER,
-          owner: signer.getSignerAddress(),
-          beneficiary: signer.getSignerAddress(),
-          oracleKey: signer.getSignerAddress(),
+          owner: aleoSigner.getSignerAddress(),
+          beneficiary: aleoSigner.getSignerAddress(),
+          oracleKey: aleoSigner.getSignerAddress(),
           overhead: {
             [DOMAIN_1]: 50000,
           },
@@ -392,9 +390,9 @@ describe('6. aleo sdk Hook artifacts e2e tests', async function () {
         igpConfig.type === HookType.INTERCHAIN_GAS_PAYMASTER,
         `Expected config to be of type ${HookType.INTERCHAIN_GAS_PAYMASTER}`,
       );
-      expect(igpConfig.owner).to.equal(signer.getSignerAddress());
-      expect(igpConfig.beneficiary).to.equal(signer.getSignerAddress());
-      expect(igpConfig.oracleKey).to.equal(signer.getSignerAddress());
+      expect(igpConfig.owner).to.equal(aleoSigner.getSignerAddress());
+      expect(igpConfig.beneficiary).to.equal(aleoSigner.getSignerAddress());
+      expect(igpConfig.oracleKey).to.equal(aleoSigner.getSignerAddress());
       expect(igpConfig.overhead[DOMAIN_1]).to.equal(50000);
       expect(igpConfig.oracleConfig[DOMAIN_1].gasPrice).to.equal('1000000000');
       expect(igpConfig.oracleConfig[DOMAIN_1].tokenExchangeRate).to.equal(

typescript/aleo-sdk/src/tests/8_mailbox_artifacts.e2e-test.ts

@@ -2,6 +2,7 @@ import chai, { expect } from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 
 import { AltVM } from '@hyperlane-xyz/provider-sdk';
+import { type ISigner } from '@hyperlane-xyz/provider-sdk/altvm';
 import {
   type ArtifactDeployed,
   ArtifactState,
@@ -34,7 +35,7 @@ chai.use(chaiAsPromised);
 describe('8. aleo sdk Mailbox artifacts e2e tests', async function () {
   this.timeout(100_000);
 
-  let signer: AltVM.ISigner<AnnotatedTx, TxReceipt>;
+  let signer: ISigner<AnnotatedTx, TxReceipt>;
   let aleoSigner: AleoSigner;
   let aleoClient: AnyAleoNetworkClient;
   let mailboxArtifactManager: AleoMailboxArtifactManager;
@@ -57,8 +58,8 @@ describe('8. aleo sdk Mailbox artifacts e2e tests', async function () {
         },
       },
     );
-
     signer = aleoSigner;
+
     aleoClient = aleoSigner.getAleoClient();
 
     mailboxArtifactManager = new AleoMailboxArtifactManager(

typescript/cli/src/tests/cosmosnative/commands/helpers.ts

@@ -1,8 +1,12 @@
 import { DirectSecp256k1Wallet } from '@cosmjs/proto-signing';
 import path from 'path';
 
-import { CosmosNativeSigner } from '@hyperlane-xyz/cosmos-sdk';
-import { type Address } from '@hyperlane-xyz/utils';
+import { AltVM } from '@hyperlane-xyz/provider-sdk';
+import {
+  CosmosNativeSigner,
+  CosmosWarpArtifactManager,
+} from '@hyperlane-xyz/cosmos-sdk';
+import { type Address, assert } from '@hyperlane-xyz/utils';
 
 import { getContext } from '../../../context/context.js';
 import { REGISTRY_PATH, getCombinedWarpRoutePath } from '../consts.js';
@@ -44,12 +48,27 @@ export async function deployCollateralToken(
     },
   );
 
-  const { tokenAddress } = await signer.createCollateralToken({
-    mailboxAddress: mailbox,
-    collateralDenom: metadata.nativeToken?.denom ?? '',
+  const denom = metadata.nativeToken?.denom;
+  assert(denom, `Missing nativeToken denom for chain ${chain}`);
+
+  const rpcUrls = signer.getRpcUrls();
+  const artifactManager = new CosmosWarpArtifactManager(rpcUrls);
+  const writer = artifactManager.createWriter(
+    AltVM.TokenType.collateral,
+    signer,
+  );
+  const [result] = await writer.create({
+    config: {
+      type: AltVM.TokenType.collateral,
+      owner: signer.getSignerAddress(),
+      mailbox,
+      token: denom,
+      remoteRouters: {},
+      destinationGas: {},
+    },
   });
 
-  return tokenAddress;
+  return result.deployed.address;
 }
 
 export async function deploySyntheticToken(
@@ -77,12 +96,24 @@ export async function deploySyntheticToken(
     },
   );
 
-  const { tokenAddress } = await signer.createSyntheticToken({
-    mailboxAddress: mailbox,
-    name: '',
-    denom: '',
-    decimals: 0,
+  const rpcUrls = signer.getRpcUrls();
+  const artifactManager = new CosmosWarpArtifactManager(rpcUrls);
+  const writer = artifactManager.createWriter(
+    AltVM.TokenType.synthetic,
+    signer,
+  );
+  const [result] = await writer.create({
+    config: {
+      type: AltVM.TokenType.synthetic,
+      owner: signer.getSignerAddress(),
+      mailbox,
+      name: '',
+      symbol: '',
+      decimals: 0,
+      remoteRouters: {},
+      destinationGas: {},
+    },
   });
 
-  return tokenAddress;
+  return result.deployed.address;
 }