Conversation
Check Warp Deploy Summary
Last updated: 2026-04-10 16:12:21 UTC |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdded multiple Warp routing configuration and deployment YAMLs that declare cross-chain tokens, collateral mappings, per-chain router/fee/mailbox settings, interchain security modules, allowed rebalancers/bridges, and cross-chain connections across ethereum, arbitrum, base, citrea, katana, and solanamainnet. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User as User
participant SrcChain as SrcChain
participant Mailbox as Mailbox
participant ISM as InterchainSecurityModule
participant Router as CrossCollateralRouter
participant Fee as FeeContract
participant DestChain as DestChain
rect rgba(173,216,230,0.5)
User->>SrcChain: Initiate cross-chain transfer (token + meta)
SrcChain->>Mailbox: Submit message for destination
end
rect rgba(144,238,144,0.5)
Mailbox->>ISM: Validate routing policy / thresholds
ISM-->>Mailbox: Approve/Reject
Mailbox->>Router: Relay transfer message
end
rect rgba(255,228,181,0.5)
Router->>Fee: Request off-chain fee quote
Fee-->>Router: Return fee (bps, signers)
Router->>DestChain: Mint/lock collateral or synthetic per `standard`
DestChain-->>User: Deliver destination asset
end
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deployments/warp_routes/CROSS/ctusd-config.yaml`:
- Around line 121-122: The YAML entry uses an undefined standard value
"SealevelHypCrossCollateral" for the USDT token; change the standard to the
correct schema-defined value used for Solana cross-collateral (the same
replacement you applied to the USDC entry) so that the "symbol: USDT" entry
references the valid standard instead of "SealevelHypCrossCollateral". Ensure
the updated standard identifier exactly matches the schema name used elsewhere.
- Around line 106-107: The YAML uses a non-existent standard value
SealevelHypCrossCollateral under the standard key; either replace
SealevelHypCrossCollateral with an existing enum value (e.g.,
SealevelHypCollateral) in the affected records (the standard key entries) or add
SealevelHypCrossCollateral to the schema.json enum so it becomes a valid
standard; update the standard values consistently (including the other
occurrence noted) and ensure the schema's enum list and the YAML standard keys
match exactly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4e18a20e-3971-4d29-b23d-356f8db685d9
📒 Files selected for processing (5)
deployments/warp_routes/CROSS/ctusd-config.yamldeployments/warp_routes/USDC/ctusd-config.yamldeployments/warp_routes/USDC/ctusd-deploy.yamldeployments/warp_routes/USDT/ctusd-config.yamldeployments/warp_routes/USDT/ctusd-deploy.yaml
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deployments/warp_routes/USDC/ctusd-deploy.yaml`:
- Around line 16-31: Reorder the YAML keys inside the amountRoutingIsm blocks so
they are alphabetical: change the amountRoutingIsm key order to lowerIsm,
threshold, type, upperIsm; inside the nested lowerIsm blocks reorder keys to
modules, threshold, type; apply this fix for the amountRoutingIsm occurrences
(including the blocks labeled amountRoutingIsm, lowerIsm, and upperIsm) present
in the file (and the repeated base and citrea sections) so all ISM blocks follow
the "YAML keys must be sorted alphabetically" rule.
- Around line 3-5: The allowedRebalancers entries in ctusd-deploy.yaml contain
inconsistent casing (one lowercase address among checksummed ones); locate the
allowedRebalancers arrays for the top-level, base, and ethereum sections and
replace the lowercase/non-checksummed addresses with their proper EIP-55
checksummed forms (use the correct checksums already present in USDTSTAGE and
ETHSTAGE as the source of truth), ensuring all addresses in allowedRebalancers
are uniformly checksummed (e.g., update the three addresses shown and the
corresponding sets in base and ethereum).
In `@deployments/warp_routes/USDT/ctusd-deploy.yaml`:
- Around line 21-31: The YAML has nested maps with keys out of alphabetical
order; reorder keys so each map sorts keys alphabetically (e.g., for the
amountRoutingIsm block put keys as lowerIsm, threshold, type -> then inside
lowerIsm/staticAggregationIsm sort as modules, threshold, type -> inside each
module sort keys alphabetically such as relayer, type and owner, domains, type
for defaultFallbackRoutingIsm) and apply the same reordering to the other nested
ISM/module block with trustedRelayerIsm/defaultFallbackRoutingIsm so all keys
(type, threshold, lowerIsm, modules, relayer, owner, domains, etc.) are
alphabetized to satisfy the YAML key-sorting policy.
- Around line 7-16: The mapping under crossCollateralRouters has domain keys out
of lexicographic order; reorder the keys so they are alphabetically sorted as
strings (e.g., "1", "1399811149", "4114", "42161", "8453") and apply the same
sorting to the other similar block(s) referenced (the block containing the keys
"1","4114","42161","8453","1399811149") to satisfy the YAML key-ordering rule.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: eca52214-a84b-4a92-a7f6-ad6f9893d555
📒 Files selected for processing (2)
deployments/warp_routes/USDC/ctusd-deploy.yamldeployments/warp_routes/USDT/ctusd-deploy.yaml
| - "0xEA2117b24F7947647Bec60527B68f4244AE40c01" | ||
| - "0xa3948a15e1d0778a7d53268b651B2411AF198FE3" | ||
| - "0x3e0a78a330f2b97059a4d507ca9d8292b65b6fb5" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if there's a standard for address casing in this repo
rg -n "0x3e0a78a330f2b97059a4d507ca9d8292b65b6fb5" --ignore-caseRepository: hyperlane-xyz/hyperlane-registry
Length of output: 1549
🏁 Script executed:
#!/bin/bash
# Read the YAML file to see the actual addresses and structure
head -n 10 deployments/warp_routes/USDC/ctusd-deploy.yaml
# Also check around lines 76-78 and 224-226 mentioned in the original scratchpad
echo "=== Around line 76-78 ==="
sed -n '74,80p' deployments/warp_routes/USDC/ctusd-deploy.yaml
echo "=== Around line 224-226 ==="
sed -n '222,228p' deployments/warp_routes/USDC/ctusd-deploy.yaml
# Verify the checksum validity using online source or logic
# EIP-55 checksum is derived from Keccak256 hash of the lowercase address
pip install eth-keys eth-utils >/dev/null 2>&1
python3 << 'EOF'
from eth_utils import to_checksum_address
# The address in question
lowercase_addr = "0x3e0a78a330f2b97059a4d507ca9d8292b65b6fb5"
# Generate correct checksum
correct_checksum = to_checksum_address(lowercase_addr)
print(f"Lowercase: {lowercase_addr}")
print(f"Correct checksum: {correct_checksum}")
# Check the suggested version from the diff
suggested = "0x3E0A78A330F2b97059a4d507CA9D8292b65b6fb5"
print(f"Suggested in diff: {suggested}")
print(f"Match: {suggested.lower() == correct_checksum.lower()}")
EOFRepository: hyperlane-xyz/hyperlane-registry
Length of output: 2718
🏁 Script executed:
#!/bin/bash
# Try with a different approach to verify the checksum
# Use web-based source or alternative validation
# First, let's check if there are any guidelines in the codebase
grep -r "address" --include="*.md" --include="*.txt" | grep -i "check\|case\|format" | head -20
# Also check what the files we saw in pre-execution use
echo "=== Checksum in USDTSTAGE (seen in pre-exec results) ==="
grep -n "0x3e0A78A330F2b97059A4D507ca9d8292b65B6FB5" deployments/warp_routes/USDTSTAGE/mode-deploy.yaml | head -1
echo "=== Checksum in ETHSTAGE (seen in pre-exec results) ==="
grep -n "0x3e0A78A330F2b97059A4D507ca9d8292b65B6FB5" deployments/warp_routes/ETHSTAGE/stage-deploy.yaml | head -1
# Try Python with installed crypto backend
pip install pycryptodome >/dev/null 2>&1
python3 << 'EOF'
from eth_utils import to_checksum_address
lowercase_addr = "0x3e0a78a330f2b97059a4d507ca9d8292b65b6fb5"
correct_checksum = to_checksum_address(lowercase_addr)
print(f"Lowercase: {lowercase_addr}")
print(f"Correct EIP-55 checksum: {correct_checksum}")
# Check versions we've seen
version_from_usdtstage = "0x3e0A78A330F2b97059A4D507ca9d8292b65B6FB5"
version_from_diff = "0x3E0A78A330F2b97059a4d507CA9D8292b65b6fb5"
print(f"\nVersion in USDTSTAGE/ETHSTAGE: {version_from_usdtstage}")
print(f" Matches correct: {version_from_usdtstage.lower() == correct_checksum.lower()}")
print(f"\nVersion suggested in diff: {version_from_diff}")
print(f" Matches correct: {version_from_diff.lower() == correct_checksum.lower()}")
EOFRepository: hyperlane-xyz/hyperlane-registry
Length of output: 1317
Those addresses be looking a wee bit disheveled, you see
Three of the allowedRebalancers across your chains got that address casing all mixed up like ogres in a swamp. Two are proper checksummed (EIP-55) and one's sitting there in all lowercase. While it might not cause trouble with everything, best to keep 'em consistent like layers.
Fix the address casing
- "0xEA2117b24F7947647Bec60527B68f4244AE40c01"
- "0xa3948a15e1d0778a7d53268b651B2411AF198FE3"
- - "0x3e0a78a330f2b97059a4d507ca9d8292b65b6fb5"
+ - "0x3e0A78A330F2b97059A4D507ca9d8292b65B6FB5"This pattern repeats in base (lines 76-78) and ethereum (lines 224-226) sections too. The correct checksummed form matches what's already in your USDTSTAGE and ETHSTAGE files.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - "0xEA2117b24F7947647Bec60527B68f4244AE40c01" | |
| - "0xa3948a15e1d0778a7d53268b651B2411AF198FE3" | |
| - "0x3e0a78a330f2b97059a4d507ca9d8292b65b6fb5" | |
| - "0xEA2117b24F7947647Bec60527B68f4244AE40c01" | |
| - "0xa3948a15e1d0778a7d53268b651B2411AF198FE3" | |
| - "0x3e0A78A330F2b97059A4D507ca9d8292b65B6FB5" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@deployments/warp_routes/USDC/ctusd-deploy.yaml` around lines 3 - 5, The
allowedRebalancers entries in ctusd-deploy.yaml contain inconsistent casing (one
lowercase address among checksummed ones); locate the allowedRebalancers arrays
for the top-level, base, and ethereum sections and replace the
lowercase/non-checksummed addresses with their proper EIP-55 checksummed forms
(use the correct checksums already present in USDTSTAGE and ETHSTAGE as the
source of truth), ensuring all addresses in allowedRebalancers are uniformly
checksummed (e.g., update the three addresses shown and the corresponding sets
in base and ethereum).
| ethereum: | ||
| type: amountRoutingIsm | ||
| threshold: 1000000000 | ||
| lowerIsm: | ||
| type: staticAggregationIsm | ||
| threshold: 1 | ||
| modules: | ||
| - type: trustedRelayerIsm | ||
| relayer: "0x1e100476e9360b11a592eafe1c90328368e547b6" | ||
| - type: defaultFallbackRoutingIsm | ||
| owner: "0xEA2117b24F7947647Bec60527B68f4244AE40c01" | ||
| domains: {} | ||
| upperIsm: | ||
| domains: {} | ||
| owner: "0xEA2117b24F7947647Bec60527B68f4244AE40c01" | ||
| type: defaultFallbackRoutingIsm |
There was a problem hiding this comment.
YAML keys aren't sorted alphabetically in the ISM blocks, mate.
Look, within the amountRoutingIsm block here (and repeated in base at lines 89-104 and citrea at lines 164-179), the keys type, threshold, lowerIsm, upperIsm should be reordered alphabetically. Same goes for the nested lowerIsm structure where modules should come before threshold and type.
As per coding guidelines: "YAML files must have keys sorted alphabetically"
🔧 Proposed fix for alphabetical sorting
ethereum:
- type: amountRoutingIsm
- threshold: 1000000000
lowerIsm:
- type: staticAggregationIsm
- threshold: 1
modules:
- type: trustedRelayerIsm
relayer: "0x1e100476e9360b11a592eafe1c90328368e547b6"
- type: defaultFallbackRoutingIsm
- owner: "0xEA2117b24F7947647Bec60527B68f4244AE40c01"
domains: {}
+ owner: "0xEA2117b24F7947647Bec60527B68f4244AE40c01"
+ threshold: 1
+ type: staticAggregationIsm
+ threshold: 1000000000
+ type: amountRoutingIsm
upperIsm:
domains: {}
owner: "0xEA2117b24F7947647Bec60527B68f4244AE40c01"
type: defaultFallbackRoutingIsm📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ethereum: | |
| type: amountRoutingIsm | |
| threshold: 1000000000 | |
| lowerIsm: | |
| type: staticAggregationIsm | |
| threshold: 1 | |
| modules: | |
| - type: trustedRelayerIsm | |
| relayer: "0x1e100476e9360b11a592eafe1c90328368e547b6" | |
| - type: defaultFallbackRoutingIsm | |
| owner: "0xEA2117b24F7947647Bec60527B68f4244AE40c01" | |
| domains: {} | |
| upperIsm: | |
| domains: {} | |
| owner: "0xEA2117b24F7947647Bec60527B68f4244AE40c01" | |
| type: defaultFallbackRoutingIsm | |
| ethereum: | |
| lowerIsm: | |
| modules: | |
| - type: trustedRelayerIsm | |
| relayer: "0x1e100476e9360b11a592eafe1c90328368e547b6" | |
| - type: defaultFallbackRoutingIsm | |
| domains: {} | |
| owner: "0xEA2117b24F7947647Bec60527B68f4244AE40c01" | |
| threshold: 1 | |
| type: staticAggregationIsm | |
| threshold: 1000000000 | |
| type: amountRoutingIsm | |
| upperIsm: | |
| domains: {} | |
| owner: "0xEA2117b24F7947647Bec60527B68f4244AE40c01" | |
| type: defaultFallbackRoutingIsm |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@deployments/warp_routes/USDC/ctusd-deploy.yaml` around lines 16 - 31, Reorder
the YAML keys inside the amountRoutingIsm blocks so they are alphabetical:
change the amountRoutingIsm key order to lowerIsm, threshold, type, upperIsm;
inside the nested lowerIsm blocks reorder keys to modules, threshold, type;
apply this fix for the amountRoutingIsm occurrences (including the blocks
labeled amountRoutingIsm, lowerIsm, and upperIsm) present in the file (and the
repeated base and citrea sections) so all ISM blocks follow the "YAML keys must
be sorted alphabetically" rule.
| type: amountRoutingIsm | ||
| threshold: 1000000000 | ||
| lowerIsm: | ||
| type: staticAggregationIsm | ||
| threshold: 1 | ||
| modules: | ||
| - type: trustedRelayerIsm | ||
| relayer: "0x1e100476e9360b11a592eafe1c90328368e547b6" | ||
| - type: defaultFallbackRoutingIsm | ||
| owner: "0xEA2117b24F7947647Bec60527B68f4244AE40c01" | ||
| domains: {} |
There was a problem hiding this comment.
Nested ISM/module maps need one more onion layer of key sorting.
A few nested maps are out of alpha order (type/threshold/lowerIsm, module entries like type/relayer, and type/owner/domains). Same content, just reorder keys to match policy and keep CI happy.
As per coding guidelines, **/*.{yaml,yml}: YAML files must have keys sorted alphabetically.
Also applies to: 98-108
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@deployments/warp_routes/USDT/ctusd-deploy.yaml` around lines 21 - 31, The
YAML has nested maps with keys out of alphabetical order; reorder keys so each
map sorts keys alphabetically (e.g., for the amountRoutingIsm block put keys as
lowerIsm, threshold, type -> then inside lowerIsm/staticAggregationIsm sort as
modules, threshold, type -> inside each module sort keys alphabetically such as
relayer, type and owner, domains, type for defaultFallbackRoutingIsm) and apply
the same reordering to the other nested ISM/module block with
trustedRelayerIsm/defaultFallbackRoutingIsm so all keys (type, threshold,
lowerIsm, modules, relayer, owner, domains, etc.) are alphabetized to satisfy
the YAML key-sorting policy.
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check the current state of the USDT ctusd-deploy.yaml file for key ordering
cat deployments/warp_routes/USDT/ctusd-deploy.yaml
Length of output: 6321
@nambrot, not quite — the nested keys in the interchainSecurityModule block are still out of order in both arbitrum and base sections. Here's what needs fixing:
# Current (out of order) → # Fixed (alphabetical)
type: amountRoutingIsm → lowerIsm:
threshold: 1000000000 → modules:
lowerIsm: → - relayer: "0x1e100..."
type: staticAggregationIsm → type: trustedRelayerIsm
threshold: 1 → - domains: {}
modules: → owner: "0xEA21..."
- type: trustedRelayerIsm → type: defaultFallbackRoutingIsm
relayer: "0x1e100..." → threshold: 1
- type: defaultFallbackRouting → type: staticAggregationIsm
owner: "0xEA21..." → threshold: 1000000000
domains: {} → type: amountRoutingIsmSpecifically, for each occurrence (both arbitrum and base, Lines 21–31 and Lines 98–108):
ethereumblock: reordertype → threshold → lowerIsmtolowerIsm → threshold → typelowerIsmblock: reordertype → threshold → modulestomodules → threshold → typetrustedRelayerIsmmodule: reordertype → relayertorelayer → typedefaultFallbackRoutingIsmmodule: reordertype → owner → domainstodomains → owner → type
🧠 Learnings used
Learnt from: CR
Repo: hyperlane-xyz/hyperlane-registry PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-03-27T21:55:19.210Z
Learning: Applies to deployments/warp_routes/**/*-config.yaml : Warp route IDs must follow format: {SYMBOL}/{label} where label is typically chain names joined by hyphens (e.g., USDC/ethereum-arbitrum)
Learnt from: CR
Repo: hyperlane-xyz/hyperlane-registry PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-27T21:55:07.081Z
Learning: Applies to deployments/warp_routes/**/*.yaml : Warp route IDs must follow format: {SYMBOL}/{label} where label is typically chain names joined by hyphens
Learnt from: Xaroz
Repo: hyperlane-xyz/hyperlane-registry PR: 1444
File: deployments/warp_routes/USDT/eclipsemainnet-deploy.yaml:1-1
Timestamp: 2026-04-02T15:08:14.086Z
Learning: In the hyperlane-xyz/hyperlane-registry repo, `deployments/warp_routes/warpRouteConfigs.yaml` is automatically updated by a CI job that runs after a PR is merged. Manual edits to this index file are not required in PRs that add or rename warp routes.
Learnt from: paulbalaji
Repo: hyperlane-xyz/hyperlane-registry PR: 1302
File: deployments/warp_routes/USDC/paradex-deploy.yaml:43-55
Timestamp: 2025-12-23T12:47:38.840Z
Learning: In Hyperlane warp route deployment YAML files under deployments/warp_routes, omitting the contractVersion field for a chain means that chain will use the latest contract version, while other chains with explicit contractVersion remain on their specified versions. Ensure this behavior is intentional and documented; review each deploy before applying to avoid unintended upgrades.
Learnt from: CR
Repo: hyperlane-xyz/hyperlane-registry PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-03-27T21:55:19.210Z
Learning: Applies to **/*.yaml : YAML files must have keys sorted alphabetically
Learnt from: CR
Repo: hyperlane-xyz/hyperlane-registry PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-27T21:55:07.081Z
Learning: Applies to **/*.{yaml,yml} : YAML files must have keys sorted alphabetically
Learnt from: CR
Repo: hyperlane-xyz/hyperlane-registry PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-03-27T21:55:07.081Z
Learning: Applies to **/*.{ts,tsx} : Sort arrays and maps before processing for consistent, deterministic output
There was a problem hiding this comment.
🧹 Nitpick comments (1)
deployments/warp_routes/USDC/ctusd-deploy.yaml (1)
81-87: Keys aren't in alphabetical order within the chain blocks, and that just ain't right.
destinationGasis sitting at the bottom of each chain section when it should be right aftercrossCollateralRoutersalphabetically. This pattern repeats across all five chain blocks (arbitrum, base, citrea, ethereum, katana).As per coding guidelines: "YAML files must have keys sorted alphabetically"
🔧 Suggested reordering for arbitrum block (apply same pattern to other chains)
arbitrum: allowedRebalancers: ... crossCollateralRouters: ... + destinationGas: + "1": "68000" + "4114": "68000" + "8453": "68000" + "1399811149": "68000" + "747474": "68000" interchainSecurityModule: ... mailbox: "0x979Ca5202784112f4738403dBec5D0F3B9daabB9" owner: "0xEA2117b24F7947647Bec60527B68f4244AE40c01" token: "0xaf88d065e77c8cC2239327C5EDb3A432268e5831" tokenFee: ... - destinationGas: - "1": "68000" - "4114": "68000" - "8453": "68000" - "1399811149": "68000" - "747474": "68000" type: crossCollateral🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deployments/warp_routes/USDC/ctusd-deploy.yaml` around lines 81 - 87, The YAML keys in each chain block are not alphabetized: move destinationGas so it appears immediately after crossCollateralRouters (alphabetical order) within the arbitrum, base, citrea, ethereum, and katana chain sections; ensure every key in those chain blocks (including crossCollateralRouters, destinationGas, type: crossCollateral, etc.) is sorted alphabetically so the destinationGas entry is no longer at the bottom but correctly positioned after crossCollateralRouters.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@deployments/warp_routes/USDC/ctusd-deploy.yaml`:
- Around line 81-87: The YAML keys in each chain block are not alphabetized:
move destinationGas so it appears immediately after crossCollateralRouters
(alphabetical order) within the arbitrum, base, citrea, ethereum, and katana
chain sections; ensure every key in those chain blocks (including
crossCollateralRouters, destinationGas, type: crossCollateral, etc.) is sorted
alphabetically so the destinationGas entry is no longer at the bottom but
correctly positioned after crossCollateralRouters.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 089aab84-760d-451e-a7d9-ab24e94a7e90
📒 Files selected for processing (2)
deployments/warp_routes/USDC/ctusd-config.yamldeployments/warp_routes/USDC/ctusd-deploy.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- deployments/warp_routes/USDC/ctusd-config.yaml
There was a problem hiding this comment.
♻️ Duplicate comments (1)
deployments/warp_routes/CROSS/ctusd-config.yaml (1)
111-112:⚠️ Potential issue | 🟠 MajorUse a schema-valid Sealevel standard for both Solana tokens.
Line 111 and Line 126 use
SealevelHypCrossCollateral, but that value is not indeployments/warp_routes/schema.json’sstandardenum from the provided snippet. This will break schema validation.Suggested patch
- standard: SealevelHypCrossCollateral + standard: SealevelHypCollateral ... - standard: SealevelHypCrossCollateral + standard: SealevelHypCollateralAlso applies to: 126-127
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deployments/warp_routes/CROSS/ctusd-config.yaml` around lines 111 - 112, The YAML uses a non-schema value "SealevelHypCrossCollateral" for the "standard" field (seen near the entries with "symbol: USDC"); replace those occurrences (the two "standard: SealevelHypCrossCollateral" entries) with one of the valid enum values from deployments/warp_routes/schema.json's "standard" enum so the documents validate—update both entries to the correct Sealevel standard string that matches the schema.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@deployments/warp_routes/CROSS/ctusd-config.yaml`:
- Around line 111-112: The YAML uses a non-schema value
"SealevelHypCrossCollateral" for the "standard" field (seen near the entries
with "symbol: USDC"); replace those occurrences (the two "standard:
SealevelHypCrossCollateral" entries) with one of the valid enum values from
deployments/warp_routes/schema.json's "standard" enum so the documents
validate—update both entries to the correct Sealevel standard string that
matches the schema.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 95b9f313-1c9a-4ac1-a294-a9733a134d75
📒 Files selected for processing (1)
deployments/warp_routes/CROSS/ctusd-config.yaml
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
deployments/warp_routes/warpRouteConfigs.yaml (1)
672-810: Prefer letting CI update this index file instead of manual edits.These entries look structurally fine, but
deployments/warp_routes/warpRouteConfigs.yamlis CI-managed after merge, so hand-editing it in the PR can add noisy diff churn. I’d recommend dropping manual index edits unless your workflow explicitly requires pre-merge updates.Based on learnings:
deployments/warp_routes/warpRouteConfigs.yamlis automatically updated by a CI job after merge, so manual edits are not required for added/renamed warp routes.Also applies to: 7464-7524, 10633-10652
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deployments/warp_routes/warpRouteConfigs.yaml` around lines 672 - 810, The CI-managed index file has been edited manually; revert the manual changes to the CROSS/ctusd section in warpRouteConfigs.yaml (the entries under the "CROSS/ctusd" block such as tokens with addressOrDenom "0x62fe676dff1e7ABBCcbedc8BABc993827b9fb189", "0x8243539...", "0xd54A15f8...", the Sealevel entries "HxwQM6D6F..." and "3zh5dN..." and the katana token "0xe064aee7...") — remove these hand edits from your branch so the file is unchanged and allow the CI job to update warpRouteConfigs.yaml after merge. Preserve any other unrelated changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@deployments/warp_routes/warpRouteConfigs.yaml`:
- Around line 672-810: The CI-managed index file has been edited manually;
revert the manual changes to the CROSS/ctusd section in warpRouteConfigs.yaml
(the entries under the "CROSS/ctusd" block such as tokens with addressOrDenom
"0x62fe676dff1e7ABBCcbedc8BABc993827b9fb189", "0x8243539...", "0xd54A15f8...",
the Sealevel entries "HxwQM6D6F..." and "3zh5dN..." and the katana token
"0xe064aee7...") — remove these hand edits from your branch so the file is
unchanged and allow the CI job to update warpRouteConfigs.yaml after merge.
Preserve any other unrelated changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 23f80fbb-a0be-425c-978c-10c29230cfc6
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
.changeset/small-mayflies-marry.mddeployments/warp_routes/schema.jsondeployments/warp_routes/warpRouteConfigs.yamlpackage.json
✅ Files skipped from review due to trivial changes (3)
- .changeset/small-mayflies-marry.md
- package.json
- deployments/warp_routes/schema.json
This reverts commit 11ada70.
…s for cross collateral warp routes
2 participants
Summary
CROSS/ctusdaggregate route configUSDC/ctusdsubroute artifactsUSDT/ctusdsubroute artifactsNotes
main