Skip to content

Commit 0f15d56

Browse files
Bump jaeger v2
- Switch to jaeger v2 container within NWO - Remove unused docker-compose and configuration - Remove unused jaeger reporting client code Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
1 parent 46fb0c7 commit 0f15d56

File tree

9 files changed

+6
-179
lines changed

9 files changed

+6
-179
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ monitoring-docker-images: ## Pull images for monitoring
9494
docker pull ghcr.io/hyperledger-labs/explorer:latest
9595
docker pull prom/prometheus:latest
9696
docker pull grafana/grafana:latest
97-
docker pull jaegertracing/all-in-one:latest
97+
docker pull cr.jaegertracing.io/jaegertracing/jaeger:2.12.0
9898

9999
.PHONY: testing-docker-images
100100
testing-docker-images: ## Pull images for system testing

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ require (
284284
go.opentelemetry.io/otel/metric v1.37.0 // indirect
285285
go.opentelemetry.io/otel/sdk v1.37.0
286286
go.opentelemetry.io/otel/sdk/metric v1.37.0 // indirect
287-
go.opentelemetry.io/proto/otlp v1.3.1
287+
go.opentelemetry.io/proto/otlp v1.3.1 // indirect
288288
go.uber.org/automaxprocs v1.6.0 // indirect
289289
go.uber.org/fx v1.23.0 // indirect
290290
go.uber.org/mock v0.5.0 // indirect

integration/nwo/monitoring/otlp/docker-compose.yaml

Lines changed: 0 additions & 39 deletions
This file was deleted.

integration/nwo/monitoring/otlp/docker.go

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,14 @@ import (
1010
"context"
1111

1212
"github.com/docker/docker/api/types/container"
13-
"github.com/docker/docker/api/types/mount"
1413
"github.com/docker/docker/api/types/network"
1514
"github.com/docker/docker/client"
1615
"github.com/hyperledger-labs/fabric-smart-client/integration/nwo/common/docker"
1716
"github.com/onsi/gomega"
1817
)
1918

2019
const (
21-
JaegerTracing = "jaegertracing/all-in-one:latest"
20+
JaegerTracing = "cr.jaegertracing.io/jaegertracing/jaeger:2.12.0"
2221
JaegerQueryPort = 16685
2322
JaegerCollectorPort = 4317
2423
JaegerUIPort = 16686
@@ -64,14 +63,6 @@ func (n *Extension) startJaeger() {
6463
},
6564
&container.HostConfig{
6665
PortBindings: docker.PortBindings([]int{JaegerCollectorPort, JaegerQueryPort, JaegerUIPort, JaegerAdminPort}...),
67-
Mounts: []mount.Mount{
68-
// To avoid error: "error reading server preface: EOF"
69-
{
70-
Type: mount.TypeBind,
71-
Source: n.jaegerHostsPath(),
72-
Target: "/etc/hosts",
73-
},
74-
},
7566
},
7667
&network.NetworkingConfig{
7768
EndpointsConfig: map[string]*network.EndpointSettings{

integration/nwo/monitoring/otlp/optl.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ func (n *Extension) GenerateArtifacts() {
4747
}
4848

4949
gomega.Expect(os.MkdirAll(n.configFileDir(), 0o777)).NotTo(gomega.HaveOccurred())
50-
gomega.Expect(os.WriteFile(n.configFilePath(), []byte(ConfigTemplate), 0o644)).NotTo(gomega.HaveOccurred())
51-
gomega.Expect(os.WriteFile(n.jaegerHostsPath(), []byte(JaegerHosts), 0o644)).NotTo(gomega.HaveOccurred())
5250
}
5351

5452
func (n *Extension) PostRun(bool) {
@@ -66,11 +64,3 @@ func (n *Extension) configFileDir() string {
6664
"otlp",
6765
)
6866
}
69-
70-
func (n *Extension) configFilePath() string {
71-
return filepath.Join(n.configFileDir(), "otlp-collector-config.yaml")
72-
}
73-
74-
func (n *Extension) jaegerHostsPath() string {
75-
return filepath.Join(n.configFileDir(), "jaeger_hosts")
76-
}

integration/nwo/monitoring/otlp/otel-collector-config.yaml

Lines changed: 0 additions & 47 deletions
This file was deleted.

integration/reporting/jaeger/client.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ import (
1818
"google.golang.org/grpc/credentials/insecure"
1919
)
2020

21+
const defaultSearchDepth = 20
22+
2123
type Reporter interface {
2224
FindTraces(nodeName, operationName string) (iterators.Iterator[*api_v2.SpansResponseChunk], error)
2325
GetServices() ([]string, error)
@@ -64,7 +66,7 @@ func (c *reporter) FindTraces(nodeName, operationName string) (iterators.Iterato
6466
if len(nodeName) == 0 {
6567
return nil, errors.New("no node name passed")
6668
}
67-
params := &api_v2.TraceQueryParameters{ServiceName: nodeName, RawTraces: true}
69+
params := &api_v2.TraceQueryParameters{ServiceName: nodeName, RawTraces: true, SearchDepth: defaultSearchDepth}
6870
if len(operationName) > 0 {
6971
params.OperationName = operationName
7072
}

integration/reporting/jaeger/predicates.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

integration/reporting/jaeger/transformers.go

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)