resolve comments

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Author: SaidAltury-ibm

integration/benchmark/grpc/grpc_bench_test.go

@@ -8,7 +8,6 @@ package test
 
 import (
 	"encoding/json"
-	"flag"
 	"testing"
 	"time"
 
@@ -24,10 +23,8 @@ import (
 	"go.opentelemetry.io/otel/trace/noop"
 )
 
-var workload = flag.String("workload", "ecdsa", "workload type: cpu or ecdsa") // ecdsa is the Default workload
-
-func BenchmarkGRPC(b *testing.B) {
-	srvEndpoint := setupServer(b)
+func BenchmarkGRPCSingleConnectionCPU(b *testing.B) {
+	srvEndpoint := setupServer(b, "cpu")
 
 	// we share a single connection among all client goroutines
 	cli, closeF := setupClient(b, srvEndpoint)
@@ -43,7 +40,60 @@ func BenchmarkGRPC(b *testing.B) {
 	benchmark.ReportTPS(b)
 }
 
-func setupServer(tb testing.TB) string {
+func BenchmarkGRPCMultiConnectionCPU(b *testing.B) {
+	srvEndpoint := setupServer(b, "cpu")
+
+	b.RunParallel(func(pb *testing.PB) {
+		// each goroutine gets its own client + connection
+		cli, closeF := setupClient(b, srvEndpoint)
+		defer closeF()
+
+		for pb.Next() {
+			resp, err := cli.CallViewWithContext(b.Context(), "fid", nil)
+			require.NoError(b, err)
+			require.NotNil(b, resp)
+		}
+	})
+
+	benchmark.ReportTPS(b)
+}
+
+// --- ECDSA Workload Benchmarks ---
+
+func BenchmarkGRPCSingleConnectionECDSA(b *testing.B) {
+	srvEndpoint := setupServer(b, "ecdsa")
+	cli, closeF := setupClient(b, srvEndpoint)
+	defer closeF()
+
+	b.ResetTimer()
+	b.RunParallel(func(pb *testing.PB) {
+		for pb.Next() {
+			resp, err := cli.CallViewWithContext(b.Context(), "fid", nil)
+			require.NoError(b, err)
+			require.NotNil(b, resp)
+		}
+	})
+	benchmark.ReportTPS(b)
+}
+
+func BenchmarkGRPCMultiConnectionECDSA(b *testing.B) {
+	srvEndpoint := setupServer(b, "ecdsa")
+
+	b.ResetTimer()
+	b.RunParallel(func(pb *testing.PB) {
+		cli, closeF := setupClient(b, srvEndpoint)
+		defer closeF()
+
+		for pb.Next() {
+			resp, err := cli.CallViewWithContext(b.Context(), "fid", nil)
+			require.NoError(b, err)
+			require.NotNil(b, resp)
+		}
+	})
+	benchmark.ReportTPS(b)
+}
+
+func setupServer(tb testing.TB, workloadType string) string {
 	tb.Helper()
 
 	mDefaultIdentity := view.Identity("server identity")
@@ -84,7 +134,7 @@ func setupServer(tb testing.TB) string {
 	require.NotNil(tb, srv)
 
 	var v view.View
-	switch *workload {
+	switch workloadType {
 	case "cpu":
 		parms := &benchviews.CPUParams{N: 200000}
 		input, _ := json.Marshal(parms)
@@ -96,7 +146,7 @@ func setupServer(tb testing.TB) string {
 		factory := &benchviews.ECDSASignViewFactory{}
 		v, _ = factory.NewView(input)
 	default:
-		tb.Fatalf("unknown workload type: %s", *workload)
+		tb.Fatalf("unknown workload type: %s", workloadType)
 	}
 
 	// our view manager

integration/benchmark/grpc/grpc_multi_connection_bench_test.go

@@ -14,7 +14,7 @@ import (
 )
 
 func BenchmarkView(b *testing.B) {
-	srvEndpoint := setupServer(b)
+	srvEndpoint := setupServer(b, "cpu")
 
 	// we share a single connection among all client goroutines
 	cli, closeF := setupClient(b, srvEndpoint)