simplify query build

Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>

Author: Hayim.Shaul@ibm.com

platform/view/services/storage/driver/sql/common/binding.go

@@ -111,19 +111,24 @@ func (db *BindingStore) PutBindings(ctx context.Context, longTerm view.Identity,
 	}
 
 	// Build single INSERT with multiple VALUES
-	query := fmt.Sprintf(`INSERT INTO %s (ephemeral_hash, long_term_id) VALUES `, db.table)
+	// prepare query placeholder and arguments
+	placeholders := make([]string, len(ephemerals)+1)
+	args := make([]any, 0, (len(ephemerals)+1)*2)
 
-	var args = []interface{}{}
-	argsReferences := []string{"($1, $2)"}
+	// first item it the longTerm itself
+	i := 0
+	placeholders[i] = fmt.Sprintf("($%d,$%d)", i*2+1, i*2+2)
 	args = append(args, longTerm.UniqueID(), longTerm)
-	for i, eph := range ephemerals {
+
+	// next we go through our ephemerals
+	for _, eph := range ephemerals {
+		i++
+		placeholders[i] = fmt.Sprintf("($%d,$%d)", i*2+1, i*2+2)
 		args = append(args, eph.UniqueID(), longTerm)
-		oneArgRef := fmt.Sprintf("($%d, $%d)", i*2+3, i*2+4)
-		argsReferences = append(argsReferences, oneArgRef)
 	}
 
-	query += strings.Join(argsReferences, ", ")
-	query += " ON CONFLICT DO NOTHING;"
+	query := fmt.Sprintf(`INSERT INTO %s (ephemeral_hash, long_term_id) VALUES %s ON CONFLICT DO NOTHING;`,
+		db.table, strings.Join(placeholders, ","))
 
 	logger.DebugfContext(ctx, "executing bulk insert: %s", query)