Skip to content

Potentially untrusted information returned by P2PStream.RemotePeerID #871

Open
@ale-linux

Description

@ale-linux

When using the websocket implementation of the comm stack, the RemotePeerID returned here is the one that the server reads out from the client's StreamInfo message. The code doesn't seem to validate the information in any way, even with mutual TLS enabled. A correct implementation would

  • keep the field empty without mutual TLS
  • use information from the transport security layer to fill this field, as opposed to trusting the client

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions