test(token): fix lint and quantity test expectations

Signed-off-by: Nishant <nishantbkl3345@gmail.com>

Author: nishantbkl3345-ship-it

token/token/quantity.go

@@ -84,19 +84,22 @@ func ToQuantity(q string, precision uint64) (Quantity, error) {
 	}
 }
 
+// ToQuantitySum computes the sum of the quantities of the tokens in the iterator.
 // ToQuantitySum computes the sum of the quantities of the tokens in the iterator.
 func ToQuantitySum(precision uint64) iterators.Reducer[*UnspentToken, Quantity] {
 	return iterators.NewReducer(NewZeroQuantity(precision), func(sum Quantity, tok *UnspentToken) (res Quantity, err error) {
+		defer func() {
+			if r := recover(); r != nil {
+				err = errors.Errorf("failed to sum quantities: %v", r)
+			}
+		}()
+
 		q, err := ToQuantity(tok.Quantity, precision)
 		if err != nil {
 			return nil, err
 		}
 
-
 		return sum.Add(q)
-
-		return sum.Add(q), nil
-       e9cc9c08 (fix(token): handle panic recovery correctly in ToQuantitySum and add missing edge case tests (#1348))
 	})
 }
 

token/token/quantity_test.go

@@ -413,7 +413,6 @@ func IntToHex(q int64) string {
 	return "0x" + strconv.FormatInt(q, 16)
 }
 
-
 // Additional comprehensive tests for improved coverage
 
 func TestTypeMismatchErrors(t *testing.T) {
@@ -811,18 +810,24 @@ func TestUInt64Quantity_ToBigInt(t *testing.T) {
 	assert.Equal(t, int64(12345), bi.Int64())
 }
 
-func TestQuantity_TypeMismatchPanics(t *testing.T) {
-	big128 := token.NewZeroQuantity(128)
-	u64 := token.NewZeroQuantity(64)
+func TestQuantity_TypeMismatchReturnsError(t *testing.T) {
+	u64, err := token.UInt64ToQuantity(10, 64)
+	require.NoError(t, err)
+
+	big128, err := token.NewUBigQuantity("10", 128)
+	require.NoError(t, err)
+
+	_, err = big128.Add(u64)
+	require.Error(t, err)
 
-	// BigQuantity methods Add and Sub panic when given UInt64Quantity
-	assert.Panics(t, func() { big128.(*token.BigQuantity).Add(u64) })
-	assert.Panics(t, func() { big128.(*token.BigQuantity).Sub(u64) })
+	_, err = big128.Sub(u64)
+	require.Error(t, err)
 
-	// UInt64Quantity methods Add and Sub panic when given BigQuantity
-	big128 = token.NewZeroQuantity(128) // fresh instance
-	assert.Panics(t, func() { u64.(*token.UInt64Quantity).Add(big128) })
-	assert.Panics(t, func() { u64.(*token.UInt64Quantity).Sub(big128) })
+	_, err = u64.(*token.UInt64Quantity).Add(big128)
+	require.Error(t, err)
+
+	_, err = u64.(*token.UInt64Quantity).Sub(big128)
+	require.Error(t, err)
 }
 
 func TestUInt64ToQuantity_BigQuantityPath(t *testing.T) {
@@ -878,6 +883,6 @@ func TestToQuantitySum(t *testing.T) {
 		// Add 1 more to trigger panic
 		_, err = reducer.Reduce(s, &token.UnspentToken{Quantity: "1"})
 		require.Error(t, err)
-		assert.Contains(t, err.Error(), "overflow in quantity sum")
+		assert.Contains(t, err.Error(), "exceeds uint64")
 	})
 }