commnets + lint fix

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

Author: adecaro

token/core/zkatdlog/nogh/v1/benchmark/setup_test.go

@@ -1,3 +1,9 @@
+/*
+Copyright IBM Corp. All Rights Reserved.
+
+SPDX-License-Identifier: Apache-2.0
+*/
+
 package benchmark
 
 import (

token/core/zkatdlog/nogh/v1/validator/testdata/env_test.go

@@ -1,3 +1,9 @@
+/*
+Copyright IBM Corp. All Rights Reserved.
+
+SPDX-License-Identifier: Apache-2.0
+*/
+
 package testdata
 
 import (
@@ -23,7 +29,7 @@ func TestSaveTransferToFile(t *testing.T) {
 	assert.NoError(t, err)
 
 	var payload struct {
-		TxID  string `json:"txid"`
+		TxID   string `json:"txid"`
 		ReqRaw string `json:"req_raw"`
 	}
 	err = json.Unmarshal(b, &payload)

token/core/zkatdlog/nogh/v1/validator/testdata/generator/main.go

@@ -1,3 +1,9 @@
+/*
+Copyright IBM Corp. All Rights Reserved.
+
+SPDX-License-Identifier: Apache-2.0
+*/
+
 package main
 
 import (
@@ -8,14 +14,14 @@ import (
 
 	"github.com/hyperledger-labs/fabric-token-sdk/token/core/zkatdlog/nogh/v1/benchmark"
 	"github.com/hyperledger-labs/fabric-token-sdk/token/core/zkatdlog/nogh/v1/validator/testdata"
-	benchmark2 "github.com/hyperledger-labs/fabric-token-sdk/token/services/benchmark"
+	sbenchmark "github.com/hyperledger-labs/fabric-token-sdk/token/services/benchmark"
 )
 
 //go:generate go run . -bits=32,64 -curves=BN254,BLS12_381_BBS_GURVY
 func main() {
 	flag.Parse()
 	// generate setup
-	bits, curves, _, err := benchmark2.GenerateCasesWithDefaults()
+	bits, curves, _, err := sbenchmark.GenerateCasesWithDefaults()
 	if err != nil {
 		panic(err)
 	}
@@ -36,7 +42,7 @@ func main() {
 		}
 
 		for i := range 64 {
-			env, err := testdata.NewEnv(&benchmark2.Case{
+			env, err := testdata.NewEnv(&sbenchmark.Case{
 				Bits:       configuration.Bits,
 				CurveID:    configuration.CurveID,
 				NumInputs:  2,

token/core/zkatdlog/nogh/v1/validator/validator_test.go

@@ -113,6 +113,19 @@ func TestParallelBenchmarkValidatorTransfer(t *testing.T) {
 	)
 }
 
+// TestRegression runs previously recorded regression test vectors contained in the
+// `testdata/<variant>` directories. Each directory contains a `params.txt` and a
+// sequence of JSON files under `transfers/output.<n>.json` representing serialized
+// token requests and their associated txids. The test unmarshals each recorded
+// request and verifies it against the validator to ensure the library remains
+// backwards compatible.
+//
+// Notes:
+//   - The testdata used here is generated by `testdata/generator`. If you need to
+//     re-generate vectors for a new setup, run that generator and commit the
+//     produced artifacts to the corresponding `testdata/...` directory.
+//   - The test expects 64 transfer vectors (output.0..output.63). Update the loop
+//     range in `testRegression` if you add or remove vectors.
 func TestRegression(t *testing.T) {
 	testRegression(t, "testdata/32-BLS12_381_BBS_GURVY")
 	testRegression(t, "testdata/64-BLS12_381_BBS_GURVY")
@@ -141,7 +154,7 @@ func testRegression(t *testing.T, rootDir string) {
 		err = json.Unmarshal(jsonData, &tokenData)
 		require.NoError(t, err)
 		_, _, err = tokenValidator.UnmarshallAndVerifyWithMetadata(
-			context.Background(),
+			t.Context(),
 			&fakeLedger{},
 			token.RequestAnchor(tokenData.TXID),
 			tokenData.ReqRaw,
@@ -188,6 +201,6 @@ func tokenServicesFactory(bytes []byte) (tcc.PublicParameters, tcc.Validator, er
 
 type fakeLedger struct{}
 
-func (*fakeLedger) GetState(id tk.ID) ([]byte, error) {
+func (*fakeLedger) GetState(_ tk.ID) ([]byte, error) {
 	panic("ciao")
 }