Skip to content

Commit bf80912

Browse files
committed
mnr edits
Signed-off-by: Effi-S <effi.szt@gmail.com>
1 parent b3ce1d4 commit bf80912

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

cmd/benchmarking/plotly_plot_node.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,16 @@ def parse_combined(dfs: dict[str, pd.DataFrame]):
236236
def make_combined_figures(dfs, local_dfs):
237237
figs = {"_All": None}
238238
all_dfs = []
239+
for name, d in local_dfs.items():
240+
d = d.copy()
241+
d["bench"] = name
242+
all_dfs.append(_aggregate(d, ["bench", "workers"]))
243+
239244
for nc, df in sorted(dfs.items(), key=lambda x: x[0]):
240245
agg = _aggregate(df, ["bench", "workers"])
246+
d = agg.copy()
247+
d["bench"] = d["bench"] + f" (nc={nc})"
248+
all_dfs.append(d)
241249
local_parts = []
242250
for name, ldf in local_dfs.items():
243251
ldf = ldf.copy()
@@ -249,9 +257,6 @@ def make_combined_figures(dfs, local_dfs):
249257
)
250258

251259
figs[nc] = _tps_fig(agg, 'bench', f'TPS (nc={nc})')
252-
d = agg.copy()
253-
d["bench"] = d["bench"] + f" (nc={nc})"
254-
all_dfs.append(d)
255260
lat = _latency_fig(agg, 'bench', 'percentile', f'Latency (nc={nc})')
256261
if lat:
257262
figs[f"{nc}_latency"] = lat

token/core/zkatdlog/nogh/v1/validator/bench/transfer_service/transfer_service_bench.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,6 @@ func (c *TransferServiceViewFactory) NewView(in []byte) (view.View, error) {
222222
return nil, err
223223
}
224224
if f.params.TokenData != nil {
225-
226225
f.tokenData = f.params.TokenData
227226

228227
var initErr error

0 commit comments

Comments
 (0)