Skip to content

Commit cfea7d6

Browse files
committed
lint fix
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
1 parent cd98cb1 commit cfea7d6

File tree

2 files changed

+27
-26
lines changed

2 files changed

+27
-26
lines changed

token/core/fabtoken/v1/driver/driver_test.go

Lines changed: 24 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
idmock "github.com/hyperledger-labs/fabric-token-sdk/token/services/identity/mock"
2121
"github.com/hyperledger-labs/fabric-token-sdk/token/services/network"
2222
"github.com/stretchr/testify/assert"
23+
"github.com/stretchr/testify/require"
2324
)
2425

2526
// TestNewDriver tests the creation of a new fabtoken driver.
@@ -70,45 +71,45 @@ func TestNewTokenService(t *testing.T) {
7071

7172
tmsID := tdriver.TMSID{Network: "n1", Channel: "c1", Namespace: "ns1"}
7273
pp, err := setup.NewWith(setup.FabTokenDriverName, setup.ProtocolV1, 64)
73-
assert.NoError(t, err)
74+
require.NoError(t, err)
7475
pp.AddIssuer([]byte("issuer-1"))
7576
pp.AddAuditor([]byte("auditor-1"))
7677
ppBytes, err := pp.Serialize()
77-
assert.NoError(t, err)
78+
require.NoError(t, err)
7879

7980
// Case 1: Empty public parameters
8081
ts, err := d.NewTokenService(tmsID, nil)
81-
assert.Error(t, err)
82+
require.Error(t, err)
8283
assert.Nil(t, ts)
8384
assert.Contains(t, err.Error(), "empty public parameters")
8485

8586
// Case 2: Failed getting network
8687
networkProvider.GetNetworkReturns(nil, errors.New("network-error"))
8788
ts, err = d.NewTokenService(tmsID, ppBytes)
88-
assert.Error(t, err)
89+
require.Error(t, err)
8990
assert.Nil(t, ts)
9091
assert.Contains(t, err.Error(), "failed getting network [network-error]")
9192

9293
// Case 3: Failed getting vault
9394
networkProvider.GetNetworkReturns(&network.Network{}, nil)
9495
vaultProvider.VaultReturns(nil, errors.New("vault-error"))
9596
ts, err = d.NewTokenService(tmsID, ppBytes)
96-
assert.Error(t, err)
97+
require.Error(t, err)
9798
assert.Nil(t, ts)
9899
assert.Contains(t, err.Error(), "failed getting vault [vault-error]")
99100

100101
// Case 4: Failed to get config
101102
vaultProvider.VaultReturns(&dmock.Vault{}, nil)
102103
configService.ConfigurationForReturns(nil, errors.New("config-error"))
103104
ts, err = d.NewTokenService(tmsID, ppBytes)
104-
assert.Error(t, err)
105+
require.Error(t, err)
105106
assert.Nil(t, ts)
106107
assert.Contains(t, err.Error(), "failed to get config for token service")
107108

108109
// Case 5: Failed to initialize public params manager (invalid bytes)
109110
configService.ConfigurationForReturns(&dmock.Configuration{}, nil)
110111
ts, err = d.NewTokenService(tmsID, []byte("invalid-pp"))
111-
assert.Error(t, err)
112+
require.Error(t, err)
112113
assert.Nil(t, ts)
113114
assert.Contains(t, err.Error(), "failed to initiliaze public params manager")
114115

@@ -125,7 +126,7 @@ func TestNewTokenService(t *testing.T) {
125126

126127
storageProvider.IdentityStoreReturns(nil, errors.New("identity-store-error"))
127128
ts, err = d.NewTokenService(tmsID, ppBytes)
128-
assert.Error(t, err)
129+
require.Error(t, err)
129130
assert.Nil(t, ts)
130131
assert.Contains(t, err.Error(), "failed to initiliaze wallet service")
131132

@@ -146,7 +147,7 @@ func TestNewTokenService(t *testing.T) {
146147
configService.ConfigurationForReturns(config, nil)
147148

148149
ts, err = d.NewTokenService(tmsID, ppBytes)
149-
assert.NoError(t, err)
150+
require.NoError(t, err)
150151
assert.NotNil(t, ts)
151152
}
152153

@@ -175,12 +176,12 @@ func TestNewDefaultValidator(t *testing.T) {
175176

176177
// Case 1: Valid public parameters
177178
v, err := d.NewDefaultValidator(pp)
178-
assert.NoError(t, err)
179+
require.NoError(t, err)
179180
assert.NotNil(t, v)
180181

181182
// Case 2: Invalid public parameters type
182183
v, err = d.NewDefaultValidator(&dmock.PublicParameters{})
183-
assert.Error(t, err)
184+
require.Error(t, err)
184185
assert.Nil(t, v)
185186
assert.Contains(t, err.Error(), "invalid public parameters type")
186187
}
@@ -190,15 +191,15 @@ func TestPublicParametersFromBytes(t *testing.T) {
190191
d := &driver.Driver{}
191192
pp, _ := setup.NewWith(setup.FabTokenDriverName, setup.ProtocolV1, 64)
192193
ppBytes, err := pp.Serialize()
193-
assert.NoError(t, err)
194+
require.NoError(t, err)
194195

195196
res, err := d.PublicParametersFromBytes(ppBytes)
196-
assert.NoError(t, err)
197+
require.NoError(t, err)
197198
assert.NotNil(t, res)
198199
assert.Equal(t, uint64(64), res.Precision())
199200

200201
_, err = d.PublicParametersFromBytes([]byte("invalid"))
201-
assert.Error(t, err)
202+
require.Error(t, err)
202203
assert.Contains(t, err.Error(), "failed to unmarshal public parameters")
203204
}
204205

@@ -208,17 +209,17 @@ func TestPPMFactory(t *testing.T) {
208209
assert.Equal(t, core.DriverIdentifier(setup.FabTokenDriverName, setup.ProtocolV1), factory.Name)
209210
assert.NotNil(t, factory.Driver)
210211

211-
ppmFactory := factory.Driver.(tdriver.PPMFactory)
212+
ppmFactory := factory.Driver
212213
pp, _ := setup.NewWith(setup.FabTokenDriverName, setup.ProtocolV1, 64)
213214

214215
// Success
215216
ppm, err := ppmFactory.NewPublicParametersManager(pp)
216-
assert.NoError(t, err)
217+
require.NoError(t, err)
217218
assert.NotNil(t, ppm)
218219

219220
// Invalid type
220221
_, err = ppmFactory.NewPublicParametersManager(&dmock.PublicParameters{})
221-
assert.Error(t, err)
222+
require.Error(t, err)
222223
assert.Contains(t, err.Error(), "invalid public parameters type")
223224
}
224225

@@ -229,7 +230,7 @@ func TestWalletServiceFactory(t *testing.T) {
229230
assert.Equal(t, core.DriverIdentifier(setup.FabTokenDriverName, setup.ProtocolV1), factory.Name)
230231
assert.NotNil(t, factory.Driver)
231232

232-
wsFactory := factory.Driver.(tdriver.WalletServiceFactory)
233+
wsFactory := factory.Driver
233234
tmsConfig := &dmock.Configuration{}
234235
tmsConfig.IDReturns(tdriver.TMSID{Network: "n1", Channel: "c1", Namespace: "ns1"})
235236

@@ -247,27 +248,27 @@ func TestWalletServiceFactory(t *testing.T) {
247248

248249
// Success
249250
ws, err := wsFactory.NewWalletService(tmsConfig, pp)
250-
assert.NoError(t, err)
251+
require.NoError(t, err)
251252
assert.NotNil(t, ws)
252253

253254
// Error path: IdentityStore failure
254255
storageProvider.IdentityStoreReturns(nil, errors.New("identity store error"))
255256
_, err = wsFactory.NewWalletService(tmsConfig, pp)
256-
assert.Error(t, err)
257+
require.Error(t, err)
257258
assert.Contains(t, err.Error(), "failed to open identity db")
258259

259260
// Error path: Keystore failure
260261
storageProvider.IdentityStoreReturns(identityStore, nil)
261262
storageProvider.KeystoreReturns(nil, errors.New("keystore error"))
262263
_, err = wsFactory.NewWalletService(tmsConfig, pp)
263-
assert.Error(t, err)
264+
require.Error(t, err)
264265
assert.Contains(t, err.Error(), "failed to open keystore")
265266

266267
// Error path: WalletStore failure
267268
storageProvider.KeystoreReturns(keystore, nil)
268269
storageProvider.WalletStoreReturns(nil, errors.New("wallet store error"))
269270
_, err = wsFactory.NewWalletService(tmsConfig, pp)
270-
assert.Error(t, err)
271+
require.Error(t, err)
271272
assert.Contains(t, err.Error(), "failed to get identity storage provider")
272273
}
273274

@@ -280,7 +281,7 @@ func TestDeserializers(t *testing.T) {
280281
pp, _ := setup.NewWith(setup.FabTokenDriverName, setup.ProtocolV1, 64)
281282
ppBytes, _ := pp.Serialize()
282283
res, err := ppd.DeserializePublicParams(ppBytes, setup.FabTokenDriverName, setup.ProtocolV1)
283-
assert.NoError(t, err)
284+
require.NoError(t, err)
284285
assert.NotNil(t, res)
285286

286287
eidrh := driver.NewEIDRHDeserializer()

token/core/fabtoken/v1/service_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,13 @@ func TestNewService(t *testing.T) {
6262
assert.Equal(t, tokensService, service.TokensService())
6363
assert.Equal(t, tokensUpgradeService, service.TokensUpgradeService())
6464
assert.Equal(t, authorization, service.Authorization())
65-
65+
6666
v, err := service.Validator()
67-
assert.NoError(t, err)
67+
require.NoError(t, err)
6868
assert.Equal(t, validator, v)
6969

7070
assert.Nil(t, service.CertificationService())
7171

7272
err = service.Done()
73-
assert.NoError(t, err)
73+
require.NoError(t, err)
7474
}

0 commit comments

Comments
 (0)