test(certifier): increase unit-test coverage from 41% to 62% (#1508)

Signed-off-by: atharrva01 <atharvaborade568@gamil.com>

Author: atharrva01

token/services/certifier/interactive/certification_test.go

@@ -30,15 +30,18 @@ const (
 
 var logger = logging.MustGetLogger()
 
+//go:generate counterfeiter -o mock/query_engine.go -fake-name QueryEngineMock . QueryEngine
 type QueryEngine interface {
 	UnspentTokensIterator(ctx context.Context) (*token2.UnspentTokensIterator, error)
 }
 
+//go:generate counterfeiter -o mock/certification_storage.go -fake-name CertificationStorageMock . CertificationStorage
 type CertificationStorage interface {
 	Exists(ctx context.Context, id *token.ID) bool
 	Store(ctx context.Context, certifications map[*token.ID][]byte) error
 }
 
+//go:generate counterfeiter -o mock/view_manager.go -fake-name ViewManagerMock . ViewManager
 type ViewManager interface {
 	InitiateView(view view.View) (interface{}, error)
 }

token/services/certifier/interactive/client.go

@@ -4,7 +4,7 @@ Copyright IBM Corp. All Rights Reserved.
 SPDX-License-Identifier: Apache-2.0
 */
 
-package interactive
+package interactive_test
 
 import (
 	"context"
@@ -19,6 +19,7 @@ import (
 	"github.com/hyperledger-labs/fabric-smart-client/platform/view/view"
 	token2 "github.com/hyperledger-labs/fabric-token-sdk/token"
 	"github.com/hyperledger-labs/fabric-token-sdk/token/driver"
+	"github.com/hyperledger-labs/fabric-token-sdk/token/services/certifier/interactive"
 	"github.com/hyperledger-labs/fabric-token-sdk/token/services/tokens"
 	"github.com/hyperledger-labs/fabric-token-sdk/token/token"
 	"github.com/stretchr/testify/assert"
@@ -90,13 +91,13 @@ func (f *fakeViewManager) InitiateView(v view.View) (interface{}, error) {
 	}
 
 	// Build a success result using the IDs from the CertificationRequestView.
-	crv, ok := v.(*CertificationRequestView)
+	crv, ok := v.(*interactive.CertificationRequestView)
 	if !ok {
 		return nil, errors.Errorf("unexpected view type %T", v)
 	}
 
-	result := make(map[*token.ID][]byte, len(crv.ids))
-	for _, id := range crv.ids {
+	result := make(map[*token.ID][]byte, len(interactive.CRVIDs(crv)))
+	for _, id := range interactive.CRVIDs(crv) {
 		result[id] = []byte("cert:" + id.TxId)
 	}
 
@@ -120,15 +121,15 @@ var _ = (*fakeViewManager).callCount
 // newTestClient creates a CertificationClient with defaults suitable for tests.
 func newTestClient(
 	t *testing.T,
-	vm ViewManager,
-	storage CertificationStorage,
+	vm interactive.ViewManager,
+	storage interactive.CertificationStorage,
 	batchSize int,
 	flushInterval time.Duration,
 	workers int,
-) *CertificationClient {
+) *interactive.CertificationClient {
 	t.Helper()
 
-	return NewCertificationClient(
+	return interactive.NewCertificationClient(
 		context.Background(),
 		"test-network",
 		"test-channel",
@@ -144,15 +145,15 @@ func newTestClient(
 		1000,
 		flushInterval,
 		workers,
-		DefaultResponseTimeout,
+		interactive.DefaultResponseTimeout,
 		&disabled.Provider{},
 	)
 }
 
 // injectToken sends a token ID directly into the client's input channel.
 // This simulates what OnReceive does without going through the events system.
-func injectToken(cc *CertificationClient, id *token.ID) {
-	cc.tokens <- id
+func injectToken(cc *interactive.CertificationClient, id *token.ID) {
+	interactive.ClientTokensChan(cc) <- id
 }
 
 // --- tests ---
@@ -236,7 +237,7 @@ func TestCertificationClient_OnReceive_BufferFull_DoesNotBlock(t *testing.T) {
 	storage := newFakeCertificationStorage()
 
 	// batchSize=1000 and flushInterval=10min so tokens accumulate but are never batched.
-	cc := NewCertificationClient(
+	cc := interactive.NewCertificationClient(
 		context.Background(),
 		"net", "ch", "ns",
 		&fakeQueryEngine{},
@@ -249,7 +250,7 @@ func TestCertificationClient_OnReceive_BufferFull_DoesNotBlock(t *testing.T) {
 		2, // tiny buffer — fills immediately
 		10*time.Minute,
 		1,
-		DefaultResponseTimeout,
+		interactive.DefaultResponseTimeout,
 		&disabled.Provider{},
 	)
 	cc.Start()
@@ -280,7 +281,7 @@ func TestCertificationClient_PushbackNonBlocking(t *testing.T) {
 	vm := &fakeViewManager{failErr: errors.New("simulated failure")}
 	storage := newFakeCertificationStorage()
 
-	cc := NewCertificationClient(
+	cc := interactive.NewCertificationClient(
 		context.Background(),
 		"net", "ch", "ns",
 		&fakeQueryEngine{},
@@ -294,7 +295,7 @@ func TestCertificationClient_PushbackNonBlocking(t *testing.T) {
 		1, // bufferSize=1 — push-back will overflow
 		20*time.Millisecond,
 		1,
-		DefaultResponseTimeout,
+		interactive.DefaultResponseTimeout,
 		&disabled.Provider{},
 	)
 	cc.Start()
@@ -327,7 +328,7 @@ func TestCertificationClient_MultipleWorkers(t *testing.T) {
 
 	storage := newFakeCertificationStorage()
 
-	cc := NewCertificationClient(
+	cc := interactive.NewCertificationClient(
 		context.Background(),
 		"net", "ch", "ns",
 		&fakeQueryEngine{},
@@ -340,7 +341,7 @@ func TestCertificationClient_MultipleWorkers(t *testing.T) {
 		1000,
 		5*time.Millisecond,
 		workers,
-		DefaultResponseTimeout,
+		interactive.DefaultResponseTimeout,
 		&disabled.Provider{},
 	)
 	cc.Start()
@@ -399,7 +400,7 @@ func TestCertificationClient_TimerResets_MultipleFlushes(t *testing.T) {
 
 // countingViewManager wraps a fakeViewManager and counts successful certifications.
 type countingViewManager struct {
-	inner   ViewManager
+	inner   interactive.ViewManager
 	counter *atomic.Int32
 }
 

token/services/certifier/interactive/client_test.go

@@ -4,22 +4,23 @@ Copyright IBM Corp. All Rights Reserved.
 SPDX-License-Identifier: Apache-2.0
 */
 
-package interactive
+package interactive_test
 
 import (
 	"testing"
 	"time"
 
+	"github.com/hyperledger-labs/fabric-token-sdk/token/services/certifier/interactive"
 	"github.com/stretchr/testify/assert"
 )
 
 // TestDefaultConstants guards that the operational defaults don't change accidentally.
 // Changing them is a behaviour-breaking deployment change, not just a refactor.
 func TestDefaultConstants(t *testing.T) {
-	assert.Equal(t, 3, DefaultMaxAttempts, "DefaultMaxAttempts")
-	assert.Equal(t, 10*time.Second, DefaultWaitTime, "DefaultWaitTime")
-	assert.Equal(t, 10, DefaultBatchSize, "DefaultBatchSize")
-	assert.Equal(t, 1000, DefaultBufferSize, "DefaultBufferSize")
-	assert.Equal(t, 5*time.Second, DefaultFlushInterval, "DefaultFlushInterval")
-	assert.Equal(t, 1, DefaultWorkers, "DefaultWorkers")
+	assert.Equal(t, 3, interactive.DefaultMaxAttempts, "DefaultMaxAttempts")
+	assert.Equal(t, 10*time.Second, interactive.DefaultWaitTime, "DefaultWaitTime")
+	assert.Equal(t, 10, interactive.DefaultBatchSize, "DefaultBatchSize")
+	assert.Equal(t, 1000, interactive.DefaultBufferSize, "DefaultBufferSize")
+	assert.Equal(t, 5*time.Second, interactive.DefaultFlushInterval, "DefaultFlushInterval")
+	assert.Equal(t, 1, interactive.DefaultWorkers, "DefaultWorkers")
 }

token/services/certifier/interactive/config_test.go

@@ -65,6 +65,7 @@ type Resolver interface {
 	ResolveIdentities(endpoints ...string) ([]view.Identity, error)
 }
 
+//go:generate counterfeiter -o mock/subscriber.go -fake-name SubscriberMock . Subscriber
 type Subscriber = events.Subscriber
 
 type Driver struct {

token/services/certifier/interactive/driver.go

@@ -0,0 +1,39 @@
+/*
+Copyright IBM Corp. All Rights Reserved.
+
+SPDX-License-Identifier: Apache-2.0
+*/
+
+package interactive_test
+
+import (
+	"testing"
+
+	"github.com/hyperledger-labs/fabric-smart-client/pkg/utils/errors"
+	"github.com/hyperledger-labs/fabric-smart-client/platform/view/services/metrics/disabled"
+	token "github.com/hyperledger-labs/fabric-token-sdk/token"
+	"github.com/hyperledger-labs/fabric-token-sdk/token/services/certifier/interactive"
+	"github.com/hyperledger-labs/fabric-token-sdk/token/services/certifier/interactive/mock"
+	"github.com/stretchr/testify/require"
+)
+
+// TestDriver_NewCertificationService_BackendFactoryError verifies that when
+// the BackendFactory returns an error, NewCertificationService propagates it
+// and leaves CertificationService nil.
+func TestDriver_NewCertificationService_BackendFactoryError(t *testing.T) {
+	factoryErr := errors.New("backend init failed")
+
+	d := interactive.NewDriver(
+		func(_ *token.ManagementService, _ string) (interactive.Backend, error) {
+			return nil, factoryErr
+		},
+		nil, nil, &fakeViewManager{},
+		&mock.ResponderRegistryMock{},
+		&disabled.Provider{},
+	)
+
+	_, err := d.NewCertificationService(nil, "wallet")
+	require.Error(t, err)
+	require.ErrorIs(t, err, factoryErr)
+	require.Nil(t, d.CertificationService, "service must not be set after factory failure")
+}

token/services/certifier/interactive/driver_test.go

@@ -0,0 +1,44 @@
+/*
+Copyright IBM Corp. All Rights Reserved.
+
+SPDX-License-Identifier: Apache-2.0
+*/
+
+// export_test.go exposes unexported fields and helpers for use by the external
+// test package (package interactive_test). Compiled only during testing.
+package interactive
+
+import (
+	"github.com/hyperledger-labs/fabric-smart-client/platform/view/view"
+	"github.com/hyperledger-labs/fabric-token-sdk/token/token"
+)
+
+// ClientTokensChan returns the raw tokens channel of a CertificationClient.
+func ClientTokensChan(cc *CertificationClient) chan *token.ID { return cc.tokens }
+
+// ClientProcessBatch calls the unexported processBatch method.
+func ClientProcessBatch(cc *CertificationClient, ids []*token.ID) { cc.processBatch(ids) }
+
+// ServiceBackend returns the backend wired into a CertificationService.
+func ServiceBackend(s *CertificationService) Backend { return s.backend }
+
+// ServiceWallets returns the wallets map of a CertificationService.
+func ServiceWallets(s *CertificationService) map[string]string { return s.wallets }
+
+// ServiceMetrics returns the metrics of a CertificationService.
+func ServiceMetrics(s *CertificationService) *Metrics { return s.metrics }
+
+// CRVNetwork returns the network field of a CertificationRequestView.
+func CRVNetwork(v *CertificationRequestView) string { return v.network }
+
+// CRVChannel returns the channel field of a CertificationRequestView.
+func CRVChannel(v *CertificationRequestView) string { return v.channel }
+
+// CRVNamespace returns the ns field of a CertificationRequestView.
+func CRVNamespace(v *CertificationRequestView) string { return v.ns }
+
+// CRVCertifier returns the certifier field of a CertificationRequestView.
+func CRVCertifier(v *CertificationRequestView) view.Identity { return v.certifier }
+
+// CRVIDs returns the ids field of a CertificationRequestView.
+func CRVIDs(v *CertificationRequestView) []*token.ID { return v.ids }