Skip to content

hdwallet dependency #27

Open
Open
@DragonDev1906

Description

@DragonDev1906

Problem

We currently have the dependency github.com/miguelmota/go-ethereum-hdwallet v0.1.1 (https://github.com/miguelmota/go-ethereum-hdwallet), which:

  • uses an old signer in its wallet implementation
  • was released in July 2021
  • had its last commit on July 4, 2022
  • and is archived on github (read-only)

More recent commits use a newer signer (capable of signing post EIP-155 and post London Fork transactions. Depending on how the transactions are created this may break the Transactor in wallet/hd/transactor.go.

Proposal

Option 1: Get rid of the hdwallet dependency, since it seems to be no longer maintained.

Option 2: Update to a later commit and fix Transactor such that transactions without a ChainId can still be signed, thus allowing replay protected transactions through EIP-155.

Option 3: Leave it as it is. This option has the least amount of effort needed, but does not protect against replaying transactions on a different Ethereum chain/testnet.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions