Multi command submission

[PHOL-DA]

Currently the Wallet SDK when given an array of commands simply throw an error. This is because the prepare submission and prepare execution endpoint on the ledger does not support more than one command.

An improvement to be made is simply to submit the commands (if an array) each one at a time. This also abstracts away in the future when multi-root node submission is enabled for a single party.

[meiersi-da]

An improvement to be made is simply to submit the commands (if an array) each one at a time. This also abstracts away in the future when multi-root node submission is enabled for a single party.

The semantics would change though: multi-root node submissions are atomic, while the individual submissions are not.

I think the two modes should not be mistaken for each other.

[PHOL-DA]

i would suspect once multi-root is supported then we would still allow it through the same method (this is after all to simplify the life of a developer, so they can in theory easily batch) However we would provide clear return values and warning indicating what was actually batched as multi-root and what was batched as individual transactions (non-atomic) @meiersi-da WDYT ?

[meiersi-da]

i would suspect once multi-root is supported then we would still allow it through the same method (this is after all to simplify the life of a developer, so they can in theory easily batch) However we would provide clear return values and warning indicating what was actually batched as multi-root and what was batched as individual transactions (non-atomic) @meiersi-da WDYT ?

I'm wary of this approach. I think whether multiple commands are committed as an atomic batch or not is an important design choice that a developer should make; e.g., it really matters that a DvP is atomic.

So I would not leave this choice to the SDK and in particular would not change the default on it. I'd suggest to consider these different methods, and expose them under different names in the SDK.