remove noop tests [ci]

Signed-off-by: Paweł Perek <pawel.perek@digitalasset.com>

Author: pawelperek-da

apps/sv/frontend/src/__tests__/governance/forms/create-unallocated-unclaimed-activity-form.test.tsx

@@ -432,11 +432,6 @@ describe('Create Unallocated Unclaimed Activity Record Form', () => {
     await user.click(submitButton); //review proposal
     await user.click(submitButton); //submit proposal
 
-    waitFor(() => {
-      expect(screen.getByText('Action Required')).toBeInTheDocument();
-      expect(screen.getByText('Inflight Votes')).toBeInTheDocument();
-      expect(screen.getByText('Vote History')).toBeInTheDocument();
-      expect(screen.getByText('Successfully submitted the proposal')).toBeInTheDocument();
-    });
+    await screen.findByText('Successfully submitted the proposal');
   });
 });

apps/sv/frontend/src/__tests__/governance/forms/grant-revoke-featured-app-form.test.tsx

@@ -458,11 +458,6 @@ describe('Revoke Featured App Form', () => {
     await user.click(submitButton); //review proposal
     await user.click(submitButton); //submit proposal
 
-    waitFor(() => {
-      expect(screen.getByText('Action Required')).toBeInTheDocument();
-      expect(screen.getByText('Inflight Votes')).toBeInTheDocument();
-      expect(screen.getByText('Vote History')).toBeInTheDocument();
-      expect(screen.getByText('Successfully submitted the proposal')).toBeInTheDocument();
-    });
+    await screen.findByText('Successfully submitted the proposal');
   });
 });

apps/sv/frontend/src/__tests__/governance/forms/offboard-sv-form.test.tsx

@@ -327,11 +327,6 @@ describe('Offboard SV Form', () => {
     await user.click(submitButton); //review proposal
     await user.click(submitButton); //submit proposal
 
-    waitFor(() => {
-      expect(screen.getByText('Action Required')).toBeInTheDocument();
-      expect(screen.getByText('Inflight Votes')).toBeInTheDocument();
-      expect(screen.getByText('Vote History')).toBeInTheDocument();
-      expect(screen.getByText('Successfully submitted the proposal')).toBeInTheDocument();
-    });
+    await screen.findByText('Successfully submitted the proposal');
   });
 });

apps/sv/frontend/src/__tests__/governance/forms/set-amulet-rules-form.test.tsx

@@ -312,22 +312,15 @@ describe('Set Amulet Config Rules Form', () => {
     const c2Input = screen.getByTestId('config-field-transferConfigTransferFeeInitialRate');
     await user.type(c2Input, '9.99');
 
-    const reviewButton = screen.getByTestId('submit-button');
+    const submitButton = screen.getByTestId('submit-button');
     await waitFor(async () => {
-      expect(reviewButton.getAttribute('disabled')).toBeNull();
+      expect(submitButton.getAttribute('disabled')).toBeNull();
     });
-    await user.click(reviewButton);
 
-    await screen.findByText('Proposal Summary');
-    const submitButton = screen.getByTestId('submit-button');
-    await user.click(submitButton);
+    await user.click(submitButton); //review proposal
+    await user.click(submitButton); //submit proposal
 
-    // Verify the success toast appears
-    // Note: Governance page content (Action Required, Inflight Votes, etc.) can't be tested
-    // without full routing and the Wrapper doesn't include routes for the governance page
-    await waitFor(() => {
-      expect(screen.queryByText('Successfully submitted the proposal')).toBeInTheDocument();
-    });
+    await screen.findByText('Successfully submitted the proposal');
   });
 
   test('should render diffs if changes to config values were made', async () => {

apps/sv/frontend/src/__tests__/governance/forms/set-dso-rules-form.test.tsx

@@ -308,22 +308,15 @@ describe('Set DSO Config Rules Form', () => {
 
     await user.click(actionInput); // using this to trigger the onBlur event which triggers the validation
 
-    const reviewButton = screen.getByTestId('submit-button');
+    const submitButton = screen.getByTestId('submit-button');
     await waitFor(async () => {
-      expect(reviewButton.getAttribute('disabled')).toBeNull();
+      expect(submitButton.getAttribute('disabled')).toBeNull();
     });
-    await user.click(reviewButton);
 
-    await screen.findByText('Proposal Summary');
-    const submitButton = screen.getByTestId('submit-button');
-    await user.click(submitButton);
+    await user.click(submitButton); //review proposal
+    await user.click(submitButton); //submit proposal
 
-    // Verify the success toast appears
-    // Note: Governance page content (Action Required, Inflight Votes, etc.) can't be tested
-    // without full routing and the Wrapper doesn't include routes for the governance page
-    await waitFor(() => {
-      expect(screen.queryByText('Successfully submitted the proposal')).toBeInTheDocument();
-    });
+    await screen.findByText('Successfully submitted the proposal');
   });
 
   test('should render diffs if changes to config values were made', async () => {

apps/sv/frontend/src/__tests__/governance/forms/update-sv-reward-weight-form-test.test.tsx

@@ -445,11 +445,6 @@ describe('Update SV Reward Weight Form', () => {
     await user.click(submitButton); //review proposal
     await user.click(submitButton); //submit proposal
 
-    waitFor(() => {
-      expect(screen.getByText('Action Required')).toBeInTheDocument();
-      expect(screen.getByText('Inflight Votes')).toBeInTheDocument();
-      expect(screen.getByText('Vote History')).toBeInTheDocument();
-      expect(screen.getByText('Successfully submitted the proposal')).toBeInTheDocument();
-    });
+    await screen.findByText('Successfully submitted the proposal');
   });
 });