Skip to content

Commit 0c044ab

Browse files
committed
[static] ignore in todos (reverted)
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
1 parent def63a4 commit 0c044ab

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/pr_non_contributors.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ name: CI on PRs from forks
22
on:
33
pull_request_target:
44
types: [ opened, synchronize, reopened ]
5-
branches: [ main, isegall/fix-fork-ci ] # Only run on PRs with `main` as their base
6-
# FIXME
5+
branches: [ main ] # Only run on PRs with `main` as their base
76

87
concurrency:
98
group: ${{ github.workflow }}-${{ github.event.pull_request.head.ref }}

scripts/todo/src/checkTodos.sc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ val fixedIssuesCurrentPR: Set[Int] = {
7777
prNumO.fold(Set.empty[Int])({ prNum =>
7878
val prInfo = Seq("hub", "pr", "show", "-f", "%b", prNum).!!
7979
val branch = Seq("hub", "pr", "show", "-f", "%H", prNum).!!.trim
80-
val commits = Seq("git", "log", s"main..$branch").!!
80+
// When running from forks, we don't currently check the commit messages on the branch
81+
val commits = Try(Seq("git", "log", s"main..$branch").!!).getOrElse("")
8182
val issueCloseKeywords =
8283
Seq("close", "closes", "closed", "fix", "fixes", "fixed", "resolve", "resolves", "resolved")
8384
.map(w => s"($w)")

0 commit comments

Comments
 (0)