Always expose sv runbook cometbft port (#1198)

* Always expose sv runbook cometbft port

fixes DACH-NY/cn-test-failures#4702

[static]

Probably could be more clever here but doesn't seem worth the
complexity and potential breakage.

Signed-off-by: Moritz Kiefer <[email protected]>

* Add missing dependency on splice-pulumi-common-sv

[static]

I hope this makes the pulumi operator happy again and fixes this

```
src/istio.ts(4,52): error TS2307: Cannot find module
'splice-pulumi-common-sv' or its corresponding type declarations.
```

Signed-off-by: Moritz Kiefer <[email protected]>

* fmt

[static]

Signed-off-by: Moritz Kiefer <[email protected]>

---------

Signed-off-by: Moritz Kiefer <[email protected]>
Co-authored-by: Moritz Kiefer <[email protected]>

Author: moritzkiefer-da

cluster/pulumi/infra/package.json

@@ -5,7 +5,8 @@
     "@pulumi/auth0": "3.21.0",
     "@pulumi/kubernetes-cert-manager": "0.2.0",
     "@pulumiverse/grafana": "0.16.3",
-    "splice-pulumi-common": "1.0.0"
+    "splice-pulumi-common": "1.0.0",
+    "splice-pulumi-common-sv": "1.0.0"
   },
   "overrides": {
     "@pulumi/kubernetes-cert-manager": {

cluster/pulumi/infra/src/istio.ts

@@ -10,7 +10,6 @@ import { PodMonitor, ServiceMonitor } from 'splice-pulumi-common/src/metrics';
 import {
   activeVersion,
   DecentralizedSynchronizerUpgradeConfig,
-  DeploySvRunbook,
   ExactNamespace,
   getDnsNames,
   HELM_MAX_HISTORY_SIZE,
@@ -160,16 +159,13 @@ function configureInternalGatewayService(
   // see notes when installing a CometBft node in the full deployment
   const cometBftIngressPorts = DecentralizedSynchronizerUpgradeConfig.runningMigrations()
     .map(migrationInfo => migrationInfo.id)
-    .flatMap((domain: number) => {
-      return (DeploySvRunbook ? [0] : [])
-        .concat(Array.from(Array(dsoSize).keys()).map(n => n + 1))
-        .map(node => {
-          return ingressPort(
-            `cometbft-${domain}-${node}-gw`,
-            istioCometbftExternalPort(domain, node)
-          );
-        });
-    });
+    .flatMap((domain: number) =>
+      // node = 0 is the sv runbook. We always include that as relying on SPLICE_DEPLOY_SV_RUNBOOK doesn't work well
+      // for jobs where we deploy the sv runbook in a separate step so the core infra stack still runs with SPLICE_DEPLOY_SV_RUNBOOK=false.
+      Array.from(Array(dsoSize + 1).keys()).map(node =>
+        ingressPort(`cometbft-${domain}-${node}-gw`, istioCometbftExternalPort(domain, node))
+      )
+    );
   return configureGatewayService(
     ingressNs,
     ingressIp,