Remove spurious matches in illegal_daml_references hook (#3208)

[static]

Signed-off-by: Simon Meier <simon@digitalasset.com>

Author: meiersi-da

scripts/rename.sh

@@ -1174,7 +1174,7 @@ function subcmd_no_illegal_daml_references() {
       )
     for word in "${illegal_words[@]}"; do
         echo "Checking for occurences of '$word' (case-insensitive)"
-        if rg -i "$word" daml/ -g '!daml/token-standard' -g '!daml/dars.lock'; then
+        if rg -i "$word" daml/ -g '!daml/token-standard' -g '!daml/dars.lock' -g '!**/target/'; then
             echo "$word occurs in Daml code, remove all references"
             exit 1
         fi
@@ -1200,7 +1200,7 @@ function subcmd_no_illegal_daml_references() {
       )
     for pattern in "${illegal_patterns[@]}"; do
         echo "Checking for occurences of '$pattern' (case sensitive, in code other than splitwell)"
-        if rg -P "$pattern" daml/ token-standard/ -g '!*/splitwell/*' -g '!*/splitwell-test/*' -g '!daml/dars.lock' -g '!token-standard/README.md' -g '!token-standard/CHANGELOG.md' -g '!*.json' -g '!token-standard/dependencies/*'; then
+        if rg -P "$pattern" daml/ token-standard/ -g '!*/splitwell/*' -g '!*/splitwell-test/*' -g '!daml/dars.lock' -g '!token-standard/README.md' -g '!token-standard/CHANGELOG.md' -g '!*.json' -g '!token-standard/dependencies/*' -g '!**/target/'; then
             echo "$pattern occurs in Daml code (other than splitwell), remove all references"
             exit 1
         fi
@@ -1221,11 +1221,11 @@ subcommand_whitelist[no_amulet_in_ui]='Check for Amulet and ANS in user UI'
 function subcmd_no_amulet_in_ui() {
     local illegal_patterns=(
       '(?<!TR)ANS(?!_LEDGER_NAME)'
-      "(?<!Splice[./])\bAmulet\b(?!( Rules))"
+      "(?<!(Splice[./]|Config \())\bAmulet\b(?!( Rules| Config| to Issue|\)|'))"
       )
     for pattern in "${illegal_patterns[@]}"; do
         echo "Checking for occurences of '$pattern' in frontend code"
-        if rg -P "$pattern" -g '*.tsx' -g '*.ts' -g '**test/**/*.scala' -g '!cluster/**' -g '!token-standard/**'; then
+        if rg -P "$pattern" -g '*.tsx' -g '*.ts' -g '**test/**/*.scala' -g '!__tests__' -g '!cluster/**' -g '!token-standard/**'; then
             echo "$pattern occurs in frontend, ensure it is not user-visible"
             exit 1
         fi