Skip to content

Commit 2a7d4d7

Browse files
Add config for enabling access logging across the entire cluster (#2747)
Signed-off-by: Robert Autenrieth <robert.autenrieth@digitalasset.com> Signed-off-by: Robert Autenrieth <31539813+rautenrieth-da@users.noreply.github.com> Co-authored-by: Itai Segall <itai.segall@digitalasset.com>
1 parent 52e88d9 commit 2a7d4d7

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

cluster/pulumi/infra/src/config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ export const InfraConfigSchema = z.object({
9292
}),
9393
istio: z.object({
9494
enableIngressAccessLogging: z.boolean(),
95+
enableClusterAccessLogging: z.boolean().default(false),
9596
}),
9697
extraCustomResources: z.object({}).catchall(z.any()).default({}),
9798
}),

cluster/pulumi/infra/src/istio.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,8 @@ function configureIstiod(
100100
},
101101
// https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/
102102
meshConfig: {
103-
// Uncomment to turn on access logging across the entire cluster (we disabled it by default to reduce cost):
104-
// accessLogFile: '/dev/stdout',
105103
// taken from https://github.com/istio/istio/issues/37682
106-
accessLogFile: '',
104+
accessLogFile: infraConfig.istio.enableClusterAccessLogging ? '/dev/stdout' : '',
107105
accessLogEncoding: 'JSON',
108106
// https://istio.io/latest/docs/ops/integrations/prometheus/#option-1-metrics-merging disable as we don't use annotations
109107
enablePrometheusMerge: false,

0 commit comments

Comments
 (0)