more detail in test failure messages for MultiHostValidatorOperator, wallet frontend tests (#3479)

* improve error messages in MultiHostValidatorOperatorIntegrationTest

- help for recurrence of DACH-NY/cn-test-failures#6683

* print more when UI party description doesn't match

- help for recurrence of DACH-NY/cn-test-failures#6695

---------

Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>

Author: stephencompall-DA

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/MultiHostValidatorOperatorIntegrationTest.scala

@@ -77,7 +77,7 @@ class MultiHostValidatorOperatorIntegrationTest
     )(
       "Topology has changed",
       _ => {
-        multiHostedParties.foreach(party =>
+        forEvery(multiHostedParties)(party =>
           aliceParticipant.topology.party_to_participant_mappings
             .list(
               synchronizerId,
@@ -125,7 +125,7 @@ class MultiHostValidatorOperatorIntegrationTest
     )(
       "Alice sees the transaction",
       _ =>
-        multiHostedParties.foreach { party =>
+        forEvery(multiHostedParties) { party =>
           val mappings = aliceParticipant.topology.party_to_participant_mappings
             .list(
               synchronizerId,
@@ -152,7 +152,7 @@ class MultiHostValidatorOperatorIntegrationTest
     )(
       "Wait for confirmation rights",
       _ =>
-        multiHostedParties.foreach(party => {
+        forEvery(multiHostedParties) { party =>
           val mapping =
             aliceValidatorBackend.participantClient.topology.party_to_participant_mappings
               .list(
@@ -162,7 +162,7 @@ class MultiHostValidatorOperatorIntegrationTest
               )
           mapping should not be empty
           mapping.last.item.participants.last.permission shouldBe ParticipantPermission.Confirmation
-        }),
+        },
     )
 
     clue("Setup transfer preapproval") {

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/util/WalletFrontendTestUtil.scala

@@ -195,13 +195,12 @@ trait WalletFrontendTestUtil extends WalletTestUtil { self: FrontendTestCommon =
   )(implicit env: SpliceTestConsoleEnvironment): Assertion = {
     val transaction = readTransactionFromRow(transactionRow)
 
-    transaction.action should matchText(expectedAction)
-    transaction.subtype should matchText(expectedSubtype)
-    (transaction.partyDescription, expectedPartyDescription) match {
-      case (None, None) => ()
+    transaction.action should matchText(expectedAction) withClue "action"
+    transaction.subtype should matchText(expectedSubtype) withClue "subtype"
+    inside((transaction.partyDescription, expectedPartyDescription)) {
+      case (None, None) => succeed
       case (Some(party), Some(ep)) => party should matchText(ep)
-      case _ => fail(s"Unexpected party in transaction: $transaction")
-    }
+    } withClue s"Unexpected party in transaction: $transaction"
     transaction.ccAmount should beWithin(expectedAmountAmulet._1, expectedAmountAmulet._2)
     transaction.usdAmount should beWithin(
       expectedAmountUSD._1,