Retire delegate election (#1633)

Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>

Author: julientinguely-da

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/console/SvAppReference.scala

@@ -376,18 +376,6 @@ class SvAppBackendReference(
     }
   }
 
-  @Help.Summary("Create an election request (via admin API)")
-  def createElectionRequest(
-      requester: String,
-      ranking: Vector[String],
-  ): Unit = {
-    consoleEnvironment.run {
-      httpCommand(
-        HttpSvAdminAppClient.CreateElectionRequest(requester, ranking)
-      )
-    }
-  }
-
   @Help.Summary("Get the CometBFT node debug dump")
   def cometBftNodeDump(): definitions.CometBftNodeDumpResponse =
     consoleEnvironment.run {

apps/app/src/test/resources/include/svs/_sv.conf

@@ -31,9 +31,6 @@
 
     enable-expire-validator-faucet = true
 
-    # TODO(DACH-NY/canton-network-node#7649) revise and/or remove
-    enable-dso-delegate-replacement-trigger = true
-
     # CometBFT reconciliation is disabled by default as it would destabilize the CometBFT network by reflecting the
     # DSORules state in the topology of the CometBFT network, therefore nodes would be added and remove as validators quite often,
     # leading to a very slow CometBFT network

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/EnvironmentDefinition.scala

@@ -206,13 +206,6 @@ case class EnvironmentDefinition(
       )(config)
     )
 
-  def withoutDsoDelegateReplacement: EnvironmentDefinition =
-    addConfigTransform((_, config) =>
-      ConfigTransforms.updateAllAutomationConfigs(
-        _.focus(_.enableDsoDelegateReplacementTrigger).replace(false)
-      )(config)
-    )
-
   def withHttpSettingsForHigherThroughput: EnvironmentDefinition =
     addConfigTransform((_, config) =>
       config.copy(pekkoConfig =

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/AutomationControlIntegrationTest.scala

@@ -49,7 +49,7 @@ class AutomationControlIntegrationTest
         .max
 
     // The trigger that advances rounds, running in the sv app
-    // Note: using `def`, as the trigger may be destroyed and recreated (when the sv delegate changes)
+    // Note: using `def`, as the trigger may be destroyed and recreated
     def trigger = sv1Backend.dsoDelegateBasedAutomation
       .trigger[AdvanceOpenMiningRoundTrigger]
 

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/BootstrapPackageConfigDarUploadIntegrationTest.scala

@@ -32,14 +32,7 @@ class BootstrapPackageConfigDarUploadIntegrationTest
 
   override implicit val patienceConfig: PatienceConfig = PatienceConfig(scaled(Span(1, Minute)))
 
-  private val initialPackageConfig = InitialPackageConfig(
-    amuletVersion = "0.1.8",
-    amuletNameServiceVersion = "0.1.8",
-    dsoGovernanceVersion = "0.1.11",
-    validatorLifecycleVersion = "0.1.2",
-    walletVersion = "0.1.8",
-    walletPaymentsVersion = "0.1.8",
-  )
+  private val initialPackageConfig = InitialPackageConfig.minimumInitialPackageConfig
 
   override def environmentDefinition: SpliceEnvironmentDefinition =
     EnvironmentDefinition

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/BootstrapPackageConfigIntegrationTest.scala

@@ -65,16 +65,9 @@ class BootstrapPackageConfigIntegrationTest
   override implicit val patienceConfig: PatienceConfig = PatienceConfig(scaled(Span(1, Minute)))
 
   // Factored out so we can reuse it in the test
-  val initialAmulet = DarResources.amulet_0_1_8
-
-  private val initialPackageConfig = InitialPackageConfig(
-    amuletVersion = initialAmulet.metadata.version.toString,
-    amuletNameServiceVersion = "0.1.8",
-    dsoGovernanceVersion = "0.1.11",
-    validatorLifecycleVersion = "0.1.2",
-    walletVersion = "0.1.8",
-    walletPaymentsVersion = "0.1.8",
-  )
+  val initialAmulet = DarResources.amulet_0_1_9
+
+  private val initialPackageConfig = InitialPackageConfig.minimumInitialPackageConfig
 
   override def environmentDefinition: SpliceEnvironmentDefinition =
     EnvironmentDefinition

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/DsoElectionTimeBasedIntegrationTest.scala

@@ -88,7 +88,7 @@ class ScanHistoryBackfillingIntegrationTest
     val tapAmount = com.digitalasset.daml.lf.data.Numeric.assertFromString("42.0")
 
     // The trigger that advances rounds, running in the sv app
-    // Note: using `def`, as the trigger may be destroyed and recreated (when the sv delegate changes)
+    // Note: using `def`, as the trigger may be destroyed and recreated
     def advanceRoundsTrigger = sv1Backend.dsoDelegateBasedAutomation
       .trigger[AdvanceOpenMiningRoundTrigger]
 

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/ScanHistoryBackfillingIntegrationTest.scala

@@ -594,7 +594,7 @@ class ScanIntegrationTest extends IntegrationTest with WalletTestUtil with TimeT
     bobValidatorRewardsTrigger.resume()
 
     // The trigger that advances rounds, running in the sv app
-    // Note: using `def`, as the trigger may be destroyed and recreated (when the sv delegate changes)
+    // Note: using `def`, as the trigger may be destroyed and recreated
     def advanceTrigger = sv1Backend.dsoDelegateBasedAutomation
       .trigger[AdvanceOpenMiningRoundTrigger]