Skip to content

Commit 6ddb3e9

Browse files
Fix container rename in participant Helm chart (#1052)
So this would have been caught by our Helm unit tests, if only they were testing the right value... [static] Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
1 parent dd8073c commit 6ddb3e9

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

cluster/helm/splice-participant/templates/participant.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ spec:
3030
spec:
3131
{{- include "splice-util-lib.service-account" .Values | nindent 6 }}
3232
containers:
33-
- name: participant-1
33+
- name: participant
3434
image: "{{ .Values.imageRepo }}/canton-participant:{{ .Chart.AppVersion }}{{ ((.Values.imageDigests).canton_participant) }}"
3535
{{- with .Values.imagePullPolicy }}
3636
imagePullPolicy: {{ . }}

cluster/helm/splice-participant/tests/participant_test.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ tests:
3737
# Sanity check
3838
- equal:
3939
path: spec.template.spec.containers[0].name
40-
value: participant-1
40+
value: participant
4141
# Labels on deployment
4242
- isSubset:
4343
path: metadata.labels
@@ -99,7 +99,7 @@ tests:
9999
# Sanity check
100100
- equal:
101101
path: spec.template.spec.containers[0].name
102-
value: participant-1
102+
value: participant
103103
# KMS config
104104
- contains:
105105
path: spec.template.spec.containers[0].env
@@ -139,7 +139,7 @@ tests:
139139
# Sanity check
140140
- equal:
141141
path: spec.template.spec.containers[0].name
142-
value: participant-1
142+
value: participant
143143
# multi-line env var
144144
- contains:
145145
path: spec.template.spec.containers[0].env

docs/src/release_notes.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,13 @@
88
Release Notes
99
=============
1010

11+
Upcoming
12+
--------
13+
14+
- Deployment
15+
16+
- Fix a typo in the `splice-participant` Helm chart that caused the participant container to be named `participant-1` instead of `participant`.
17+
1118
0.4.1
1219
-----
1320

0 commit comments

Comments
 (0)