.

[ci]

Signed-off-by: Moritz Kiefer <[email protected]>

Author: cocreature

.github/workflows/build.scala_test.yml

@@ -50,6 +50,9 @@ on:
         type: string
         required: false
         default: ""
+      daml_base_version:
+        type: string
+        required: true
 
 jobs:
 
@@ -130,3 +133,4 @@ jobs:
           failure_notifications_invoker_sa: ${{ secrets.FAILURE_NOTIFICATIONS_INVOKER_SA }}
           failure_notifications_invoker_url: ${{ secrets.FAILURE_NOTIFICATIONS_INVOKER_URL }}
           failure_notifications_slack_channel: ${{ secrets.FAILURE_NOTIFICATIONS_SLACK_CHANNEL }}
+          daml_base_version: ${{ inputs.daml_base_version }}

.github/workflows/build.scala_test_with_cometbft.yml

@@ -18,6 +18,9 @@ on:
         type: string
         required: false
         default: ""
+      daml_base_version:
+        type: string
+        required: true
 
 jobs:
 
@@ -117,3 +120,4 @@ jobs:
           failure_notifications_invoker_sa: ${{ secrets.FAILURE_NOTIFICATIONS_INVOKER_SA }}
           failure_notifications_invoker_url: ${{ secrets.FAILURE_NOTIFICATIONS_INVOKER_URL }}
           failure_notifications_slack_channel: ${{ secrets.FAILURE_NOTIFICATIONS_SLACK_CHANNEL }}
+          daml_base_version: ${{ inputs.daml_base_version }}

.github/workflows/build.yml

@@ -10,7 +10,18 @@ on:
       daml_base_version:
         type: string
         required: false
-        default: "0.3.21"
+        default: ""
+  workflow_dispatch:
+    inputs:
+      commit_sha:
+        description: 'The commit SHA to use for the build'
+        required: false
+        default: ''
+        type: string
+      daml_base_version:
+        type: string
+        required: false
+        default: ""
 
 permissions:
   id-token: write # Required for GCP Workload Identity for failure notifications

.github/workflows/daml_compat_test.yml

@@ -0,0 +1,36 @@
+name: Integration tests against mainnet Daml version
+on:
+  pull_request:
+    types: [ opened, synchronize, reopened ]
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+permissions:
+  id-token: write # Required for GCP Workload Identity for failure notifications
+  contents: read
+  pull-requests: read # Required for the static tests
+  issues: read # Required for the static tests
+  actions: write # To cancel itself if not opted in
+
+jobs:
+  get_mainnet_version:
+    runs-on: self-hosted-docker-tiny
+    outputs:
+      version: ${{ steps.get_mainnet_version.outputs.version }}
+    steps:
+      - name: Get MainNet version
+        id: get_mainnet_version
+        run: |
+          set -eou pipefail
+          version="$(curl -sSL --fail-with-body https://docs.global.canton.network.sync.global/info | jq -r '.sv.version')"
+          echo "MainNet version is $version"
+          echo "version=$version" >> "$GITHUB_OUTPUT"
+
+  build:
+    needs: get_mainnet_version
+    uses: ./.github/workflows/build.yml
+    with:
+      daml_base_version: ${{ needs.get_mainnet_version.outputs.version }}
+    secrets: inherit

DEVELOPMENT.md

@@ -369,6 +369,26 @@ To edit the files in a particular Daml project, for example, `/apps/wallet/daml`
 *Tip:* if `damlBuild` fails with weird errors, then that might be due to stale `damlBuild` outputs.
 Try forcing a clean rebuild by cleaning via SBT, e.g., `apps-common/clean` and similar for the dependent project.
 
+## Daml Version Guards in Integration Tests
+
+Our backends need to handle the case where we compile against Daml
+version X+1 but the vote to switch to those models is not yet done and
+only Daml version X can be used. This is done by checking the active
+version endpoints in triggers, UIs and similar. However, those checks
+can be easily forgotten and the normal integration tests do not catch
+that as they run against the latest version.
+
+To catch this, we periodically run all integration tests against the
+latest Daml version that was shipped to mainnet. This means tests that
+do actually depend on the newer versions won't work. Default to making
+tests backwards compatible where possible. Where this is not possible
+or does not make sense (e.g. because you're testing functionality that
+did not have an equivalent before), tag the test with a scalatest tag
+corresponding to the version of the Daml package that introduced the
+functionality, e.g.,
+`org.lfdecentralizedtrust.splice.util.scalatesttags.SpliceAmuelt_0_1_9`. This
+ensures the test will be excluded if we are running against earlier
+Daml versions.
 
 # Troubleshooting
 

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/SpliceTests.scala

@@ -40,11 +40,12 @@ import org.lfdecentralizedtrust.splice.auth.AuthUtil
 import org.lfdecentralizedtrust.splice.config.{AuthTokenSourceConfig, SpliceConfig}
 import org.lfdecentralizedtrust.splice.console.*
 import org.lfdecentralizedtrust.splice.environment.{
+  DarResources,
   RetryProvider,
   SpliceEnvironment,
   SpliceEnvironmentFactory,
 }
-import org.lfdecentralizedtrust.splice.integration.EnvironmentDefinition
+import org.lfdecentralizedtrust.splice.integration.{EnvironmentDefinition, InitialPackageVersions}
 import org.lfdecentralizedtrust.splice.integration.plugins.{
   ResetDecentralizedNamespace,
   ResetSequencerSynchronizerStateThreshold,
@@ -573,7 +574,7 @@ object SpliceTests extends LazyLogging {
     }
 
     protected def splitwellDarPath =
-      "daml/dars/splitwell-InitialPackageVersions.initialPackageVersion(DarResources.splitwell).dar"
+      s"daml/dars/splitwell-${InitialPackageVersions.initialPackageVersion(DarResources.splitwell)}.dar"
   }
 
   object BracketSynchronous {