cleanup unused arguments in cncluster commands (#2355)

Signed-off-by: Itai Segall <itai.segall@digitalasset.com>

Author: isegall-da

build-tools/cncluster

@@ -2157,13 +2157,12 @@ function subcmd_purge_unused_dbs() {
 subcommand_whitelist[set_operator_deployment_reference]="Set the git reference for the operator deployment in the cluster config file"
 function subcmd_set_operator_deployment_reference() {
 
-    # TODO(#1062): remove the ignored parameter once the base version for migration tests is >= 0.4.2
     if [ "$#" -lt 1 ]; then
-        echo "Usage: $0 set_operator_deployment_reference <branch> [<ignored>]"
+        echo "Usage: $0 set_operator_deployment_reference <branch>"
         exit 1
     fi
-    if [ "$#" -gt 2 ]; then
-        echo "Usage: $0 set_operator_deployment_reference <branch> [<ignored>]"
+    if [ "$#" -gt 1 ]; then
+        echo "Usage: $0 set_operator_deployment_reference <branch>"
         exit 1
     fi
     deployment_config=$(cat <<EOF

build-tools/lib/hard-domain-migration-commands

@@ -19,8 +19,7 @@ function subcmd_update_config() {
     migration_id="$2"
     shift 2
   else
-    # TODO(#1062): remove the ignored parameter once the base version for migration tests is >= 0.4.2
-    _error "Usage: $0 $SCRIPTNAME migration_type migration_id [version] [<git_reference> [<ignored>]]"
+    _error "Usage: $0 $SCRIPTNAME update_config <migration_type> <migration_id> [<version>] [<git_reference>]"
   fi
   local migration_config
   migration_config=$(cat <<EOF
@@ -35,10 +34,9 @@ EOF
   )
     shift
   fi
-  # TODO(#1062): remove the ignored parameter once the base version for migration tests is >= 0.4.2
   if [ "$#" -gt 0 ]; then
-    if [ "$#" -lt 1 ]; then
-      _error "Usage: $0 $SCRIPTNAME migration_type migration_id [version] [<git_reference> [<ignored>]]"
+    if [ "$#" -gt 1 ]; then
+      _error "Usage: $0 $SCRIPTNAME update_config <migration_type> <migration_id> [<version>] [<git_reference>]"
     fi
     git_reference="$1"
     shift
@@ -57,7 +55,7 @@ subcommand_whitelist[update_active_version]='Upgrade the version of the active m
 function subcmd_update_active_version() {
     local cluster_directory
     if [ "$#" -ne 1 ]; then
-        _error "Usage: $0 $SCRIPTNAME [version]"
+        _error "Usage: $0 $SCRIPTNAME [<version>]"
     fi
     # yq doesn't like the version being unquoted so we quote it here
     _update_cluster_config "\"$1\"" "synchronizerMigration.active.version"