Revert "Add trigger for periodic topology snapshots" (#3286)

* Revert "Add trigger for periodic topology snapshots (#3188)"

This reverts commit f289b6e.

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

* [ci] run

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

---------

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

Author: OriolMunoz-da

apps/app/src/main/resources/application.conf

@@ -1,5 +1,4 @@
 # This is deliberately lower than ConsoleCommandTimeout.defaultRequestTimeout
 pekko.http.server.request-timeout = 38 seconds
 pekko.http.server.parsing.error-handler="org.lfdecentralizedtrust.splice.http.PekkoHttpParsingErrorHandler$"
-pekko.http.server.parsing.ignore-illegal-header-for = ["user-agent", "etag"]
-pekko.http.client.parsing.ignore-illegal-header-for = ["etag"]
+pekko.http.server.parsing.ignore-illegal-header-for = ["user-agent"]

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/PeriodicBackupIntegrationTest.scala

@@ -4,7 +4,6 @@ import org.lfdecentralizedtrust.splice.config.{
   BackupDumpConfig,
   ConfigTransforms,
   GcpBucketConfig,
-  IdentityDumpTest,
   PeriodicBackupDumpConfig,
 }
 import org.lfdecentralizedtrust.splice.identities.NodeIdentitiesDump
@@ -99,7 +98,7 @@ final class DirectoryPeriodicBackupIntegrationTest
 final class GcpBucketPeriodicBackupIntegrationTest
     extends PeriodicBackupIntegrationTestBase[BackupDumpConfig.Gcp] {
   override def backupDumpLocation =
-    BackupDumpConfig.Gcp(GcpBucketConfig.inferForTesting(IdentityDumpTest), None)
+    BackupDumpConfig.Gcp(GcpBucketConfig.inferForTesting, None)
   val bucket = new GcpBucket(backupDumpLocation.bucket, loggerFactory)
   override def readDump(filename: String) = {
     bucket.readStringFromBucket(Paths.get(filename))

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/PeriodicTopologySnapshotIntegrationTest.scala

@@ -1,10 +1,9 @@
 package org.lfdecentralizedtrust.splice.integration.tests.runbook
 
-import org.lfdecentralizedtrust.splice.config.IdentityDump
 import org.lfdecentralizedtrust.splice.integration.EnvironmentDefinition
 import org.lfdecentralizedtrust.splice.integration.tests.SpliceTests.{
-  IntegrationTestWithSharedEnvironment,
   SpliceTestConsoleEnvironment,
+  IntegrationTestWithSharedEnvironment,
 }
 import org.lfdecentralizedtrust.splice.util.DataExportTestUtil
 
@@ -42,11 +41,11 @@ final class NonDsoNonDevNetPreflightIntegrationTest
   }
 
   "Check that there is a recent participant identities backup on GCP for validator1" in { _ =>
-    testRecentParticipantIdentitiesDump("validator1", IdentityDump)
+    testRecentParticipantIdentitiesDump("validator1")
   }
 
   "Check that there is a recent participant identities backup on GCP for splitwell validator" in {
     _ =>
-      testRecentParticipantIdentitiesDump("splitwell", IdentityDump)
+      testRecentParticipantIdentitiesDump("splitwell")
   }
 }

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/runbook/NonDsoNonDevNetPreflightIntegrationTest.scala

@@ -1,12 +1,11 @@
 package org.lfdecentralizedtrust.splice.integration.tests.runbook
 
-import org.lfdecentralizedtrust.splice.config.IdentityDump
 import org.lfdecentralizedtrust.splice.integration.EnvironmentDefinition
 import org.lfdecentralizedtrust.splice.integration.tests.SpliceTests.SpliceTestConsoleEnvironment
 import org.lfdecentralizedtrust.splice.integration.tests.FrontendIntegrationTestWithSharedEnvironment
 import org.lfdecentralizedtrust.splice.util.DataExportTestUtil
-import org.lfdecentralizedtrust.splice.util.FrontendLoginUtil
 
+import org.lfdecentralizedtrust.splice.util.FrontendLoginUtil
 import scala.util.Try
 
 abstract class SvNonDevNetPreflightIntegrationTestBase
@@ -114,7 +113,7 @@ abstract class SvNonDevNetPreflightIntegrationTestBase
   }
 
   "Check that there is a recent participant identities backup on GCP" in { _ =>
-    testRecentParticipantIdentitiesDump(svNamespace, IdentityDump)
+    testRecentParticipantIdentitiesDump(svNamespace)
   }
 }
 

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/runbook/SvNonDevNetPreflightintegrationTest.scala

@@ -1,6 +1,6 @@
 package org.lfdecentralizedtrust.splice.util
 
-import org.lfdecentralizedtrust.splice.config.{BucketName, GcpBucketConfig}
+import org.lfdecentralizedtrust.splice.config.GcpBucketConfig
 import org.lfdecentralizedtrust.splice.identities.{NodeIdentitiesDump, NodeIdentitiesStore}
 import org.lfdecentralizedtrust.splice.integration.tests.SpliceTests.TestCommon
 import com.digitalasset.canton.topology.ParticipantId
@@ -15,9 +15,8 @@ trait DataExportTestUtil extends TestCommon {
       namespace: String,
       getFileName: Instant => Path,
       decode: String => Either[String, A],
-      bucketName: BucketName,
   ) = {
-    val bucket = new GcpBucket(GcpBucketConfig.inferForCluster(bucketName), loggerFactory)
+    val bucket = new GcpBucket(GcpBucketConfig.inferForCluster, loggerFactory)
     import java.time.Instant
     import java.time.temporal.ChronoUnit
     val cluster = sys.env("GCP_CLUSTER_BASENAME")
@@ -34,11 +33,10 @@ trait DataExportTestUtil extends TestCommon {
     }
   }
 
-  def testRecentParticipantIdentitiesDump(namespace: String, bucketName: BucketName) =
+  def testRecentParticipantIdentitiesDump(namespace: String) =
     testRecentDump(
       namespace,
       NodeIdentitiesStore.dumpFilename(_),
       NodeIdentitiesDump.fromJsonString(ParticipantId.tryFromProtoPrimitive, _),
-      bucketName,
     )
 }

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/util/DataExportTestUtil.scala

@@ -48,36 +48,16 @@ final case class GcpBucketConfig(
   def description: String = s"GCP bucket $bucketName in project $projectId"
 }
 
-sealed trait BucketName {
-  def value: String
-}
-
-case object IdentityDumpTest extends BucketName {
-  val value: String = "da-splice-identity-dumps"
-}
-
-case object TopologySnapshotTest extends BucketName {
-  val value: String = "da-splice-topology-snapshots"
-}
-
-case object IdentityDump extends BucketName {
-  val value: String = "da-cn-data-dumps"
-}
-
-case object TopologySnapshot extends BucketName {
-  val value: String = "da-cn-topology-snapshots"
-}
-
 object GcpBucketConfig {
-  def inferForTesting(testBucketName: BucketName): GcpBucketConfig =
+  def inferForTesting: GcpBucketConfig =
     infer(
       "GCP_DATA_EXPORT_INTEGRATION_TEST_SERVICE_ACCOUNT_CREDENTIALS",
       "da-cn-splice",
-      testBucketName.value,
+      "da-splice-identity-dumps",
     )
 
-  def inferForCluster(bucketName: BucketName): GcpBucketConfig =
-    infer("GCP_DATA_DUMP_BUCKET_SERVICE_ACCOUNT_CREDENTIALS", "da-cn-devnet", bucketName.value)
+  def inferForCluster: GcpBucketConfig =
+    infer("GCP_DATA_DUMP_BUCKET_SERVICE_ACCOUNT_CREDENTIALS", "da-cn-devnet", "da-cn-data-dumps")
 
   def inferForBundles: GcpBucketConfig =
     infer(