Show popup when approving a Proposal matching a Delegation

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Author: Tim Emiola

apps/wallet/frontend/src/__tests__/mocks/delegation-constants.ts

@@ -13,11 +13,11 @@ export const delegationExpiresAt = '2050-01-01T00:00:00.000000Z';
 // Formatted version as displayed by DateDisplay component
 export const delegationExpiresAtFormatted = '2050-01-01 00:00';
 
-// Onboarded status for each delegation (bob is onboarded, charlie is not, eve is onboarded)
-export const mockDelegationOnboardedStatus = [true, false, true];
+// Hosted status for each delegation (bob is hosted, charlie is not, eve is hosted)
+export const mockDelegationHostedStatus = [true, false, true];
 
-// Onboarded status for each proposal (charlie is onboarded, dave is not, eve is onboarded)
-export const mockProposalOnboardedStatus = [true, false, true];
+// Hosted status for each proposal (charlie is hosted, dave is not, eve is hosted)
+export const mockProposalHostedStatus = [true, false, true];
 
 // Three different expiration dates for testing sort order
 export const expiresAtCurrent = '2050-01-01T00:00:00.000000Z';
@@ -69,8 +69,8 @@ export const mockMintingDelegationsSorted: MintingDelegation[] = [
   mockMintingDelegations[1], // charlie - 6 months
 ];
 
-// Onboarded status in sorted order (eve: true, bob: true, charlie: false)
-export const mockDelegationOnboardedStatusSorted = [true, true, false];
+// Hosted status in sorted order (eve: true, bob: true, charlie: false)
+export const mockDelegationHostedStatusSorted = [true, true, false];
 
 // Mock data is intentionally NOT sorted by expiration date.
 // Order: 3 months, 6 months, current - to verify UI sorts them correctly.
@@ -111,5 +111,5 @@ export const mockMintingDelegationProposalsSorted: MintingDelegationProposal[] =
   mockMintingDelegationProposals[1], // dave - 6 months
 ];
 
-// Onboarded status in sorted order (eve: true, charlie: true, dave: false)
-export const mockProposalOnboardedStatusSorted = [true, true, false];
+// Hosted status in sorted order (eve: true, charlie: true, dave: false)
+export const mockProposalHostedStatusSorted = [true, true, false];

apps/wallet/frontend/src/__tests__/mocks/handlers/wallet-api.ts

@@ -32,8 +32,8 @@ import {
 import {
   mockMintingDelegations,
   mockMintingDelegationProposals,
-  mockDelegationOnboardedStatus,
-  mockProposalOnboardedStatus,
+  mockDelegationHostedStatus,
+  mockProposalHostedStatus,
 } from '../delegation-constants';
 import { mkContract } from '../contract';
 
@@ -239,7 +239,7 @@ export const buildWalletMock = (walletUrl: string): RestHandler[] => [
       ctx.json<ListMintingDelegationsResponse>({
         delegations: mockMintingDelegations.map((delegation, index) => ({
           contract: mkContract(MintingDelegation, delegation),
-          beneficiary_onboarded: mockDelegationOnboardedStatus[index],
+          beneficiary_hosted: mockDelegationHostedStatus[index],
         })),
       })
     );
@@ -250,7 +250,7 @@ export const buildWalletMock = (walletUrl: string): RestHandler[] => [
       ctx.json<ListMintingDelegationProposalsResponse>({
         proposals: mockMintingDelegationProposals.map((proposal, index) => ({
           contract: mkContract(MintingDelegationProposal, proposal),
-          beneficiary_onboarded: mockProposalOnboardedStatus[index],
+          beneficiary_hosted: mockProposalHostedStatus[index],
         })),
       })
     );

apps/wallet/frontend/src/__tests__/wallet.test.tsx

@@ -21,8 +21,8 @@ import {
   mockMintingDelegations,
   mockMintingDelegationsSorted,
   mockMintingDelegationProposals,
-  mockDelegationOnboardedStatusSorted,
-  mockProposalOnboardedStatusSorted,
+  mockDelegationHostedStatusSorted,
+  mockProposalHostedStatusSorted,
   mockMintingDelegationProposalsSorted,
 } from './mocks/delegation-constants';
 import { requestMocks } from './mocks/handlers/transfers-api';
@@ -539,7 +539,7 @@ describe('Wallet user can', () => {
 
     // Verify warning icons are shown for proposals where beneficiary is not hosted
     const proposalWarnings = document.querySelectorAll('.proposal-not-hosted-warning');
-    const expectedProposalWarnings = mockProposalOnboardedStatusSorted.filter(s => !s).length;
+    const expectedProposalWarnings = mockProposalHostedStatusSorted.filter(s => !s).length;
     expect(proposalWarnings.length).toBe(expectedProposalWarnings);
 
     // Verify proposal max amulets values are in sorted order
@@ -558,12 +558,12 @@ describe('Wallet user can', () => {
     });
 
     // Verify Accept buttons are present for each proposal
-    // Accept button should be disabled when beneficiary is not onboarded (in sorted order)
+    // Accept button should be disabled when beneficiary is not hosted (in sorted order)
     const acceptButtons = document.querySelectorAll('.proposal-accept');
     expect(acceptButtons.length).toBe(mockMintingDelegationProposals.length);
-    mockProposalOnboardedStatusSorted.forEach((isOnboarded, index) => {
+    mockProposalHostedStatusSorted.forEach((isHosted, index) => {
       expect(acceptButtons[index].textContent).toBe('Accept');
-      if (isOnboarded) {
+      if (isHosted) {
         expect(acceptButtons[index]).not.toBeDisabled();
       } else {
         expect(acceptButtons[index]).toBeDisabled();
@@ -588,7 +588,7 @@ describe('Wallet user can', () => {
 
     // Verify warning icons are shown for delegations where beneficiary is not hosted
     const delegationWarnings = document.querySelectorAll('.delegation-not-hosted-warning');
-    const expectedDelegationWarnings = mockDelegationOnboardedStatusSorted.filter(s => !s).length;
+    const expectedDelegationWarnings = mockDelegationHostedStatusSorted.filter(s => !s).length;
     expect(delegationWarnings.length).toBe(expectedDelegationWarnings);
 
     // Verify max amulets values are in sorted order

apps/wallet/frontend/src/contexts/WalletServiceContext.tsx

@@ -42,12 +42,12 @@ import {
 
 export interface MintingDelegationWithStatus {
   contract: Contract<MintingDelegation>;
-  beneficiaryOnboarded: boolean;
+  beneficiaryHosted: boolean;
 }
 
 export interface MintingDelegationProposalWithStatus {
   contract: Contract<MintingDelegationProposal>;
-  beneficiaryOnboarded: boolean;
+  beneficiaryHosted: boolean;
 }
 
 import {
@@ -360,14 +360,14 @@ export const WalletClientProvider: React.FC<React.PropsWithChildren<WalletProps>
         const res = await walletClient.listMintingDelegations();
         return res.delegations.map(d => ({
           contract: Contract.decodeOpenAPI(d.contract, MintingDelegation),
-          beneficiaryOnboarded: d.beneficiary_onboarded,
+          beneficiaryHosted: d.beneficiary_hosted,
         }));
       },
       listMintingDelegationProposals: async () => {
         const res = await walletClient.listMintingDelegationProposals();
         return res.proposals.map(p => ({
           contract: Contract.decodeOpenAPI(p.contract, MintingDelegationProposal),
-          beneficiaryOnboarded: p.beneficiary_onboarded,
+          beneficiaryHosted: p.beneficiary_hosted,
         }));
       },
       acceptMintingDelegationProposal: async proposalContractId => {

apps/wallet/frontend/src/routes/delegations.tsx

@@ -155,7 +155,7 @@ interface DelegationRowProps {
 
 const DelegationRow: React.FC<DelegationRowProps> = ({ delegation }) => {
   const { withdrawMintingDelegation } = useWalletClient();
-  const { contract, beneficiaryOnboarded: beneficiaryHosted } = delegation;
+  const { contract, beneficiaryHosted } = delegation;
   const [confirmDialogOpen, setConfirmDialogOpen] = useState(false);
 
   const withdrawMutation = useMutation({
@@ -250,7 +250,7 @@ interface ProposalRowProps {
 
 const ProposalRow: React.FC<ProposalRowProps> = ({ proposal, existingDelegation }) => {
   const { acceptMintingDelegationProposal, rejectMintingDelegationProposal } = useWalletClient();
-  const { contract, beneficiaryOnboarded: beneficiaryHosted } = proposal;
+  const { contract, beneficiaryHosted } = proposal;
   const [acceptDialogOpen, setAcceptDialogOpen] = useState(false);
   const [rejectDialogOpen, setRejectDialogOpen] = useState(false);