create separate library for interfaces

Author: meiersi-da

build.sbt

@@ -114,6 +114,8 @@ lazy val root: Project = (project in file("."))
     `splice-dso-governance-test-daml`,
     `splice-validator-lifecycle-daml`,
     `splice-validator-lifecycle-test-daml`,
+    `splice-api-featured-app-v1-daml`,
+    `splice-api-credential-registry-v1-daml`,
     `splice-api-token-metadata-v1-daml`,
     `splice-api-token-holding-v1-daml`,
     `splice-api-token-transfer-instruction-v1-daml`,
@@ -660,7 +662,7 @@ lazy val `splice-util-daml` =
       `canton-bindings-java`
     )
 
-lazy val `splice-featured-app-api-v1-daml` =
+lazy val `splice-api-featured-app-v1-daml` =
   project
     .in(file("daml/splice-api-featured-app-v1"))
     .enablePlugins(DamlPlugin)
@@ -671,6 +673,21 @@ lazy val `splice-featured-app-api-v1-daml` =
       `canton-bindings-java`
     )
 
+lazy val `splice-api-credential-registry-v1-daml` =
+  project
+    .in(file("daml/splice-api-credential-registry-v1"))
+    .enablePlugins(DamlPlugin)
+    .settings(
+      BuildCommon.damlSettings,
+      Compile / damlDependencies :=
+        (`splice-util-daml` / Compile / damlBuild).value ++
+          (`splice-api-token-metadata-v1-daml` / Compile / damlBuild).value,
+    )
+    .dependsOn(
+      `canton-bindings-java`
+    )
+
+
 lazy val `splice-amulet-daml` =
   project
     .in(file("daml/splice-amulet"))
@@ -685,7 +702,7 @@ lazy val `splice-amulet-daml` =
           (`splice-api-token-allocation-v1-daml` / Compile / damlBuild).value ++
           (`splice-api-token-allocation-request-v1-daml` / Compile / damlBuild).value ++
           (`splice-api-token-allocation-instruction-v1-daml` / Compile / damlBuild).value ++
-          (`splice-featured-app-api-v1-daml` / Compile / damlBuild).value,
+          (`splice-api-featured-app-v1-daml` / Compile / damlBuild).value,
     )
     .dependsOn(`canton-bindings-java`)
 
@@ -796,7 +813,7 @@ lazy val `splice-util-featured-app-proxies-daml` =
         (`splice-api-token-transfer-instruction-v1-daml` / Compile / damlBuild).value ++
           (`splice-api-token-allocation-v1-daml` / Compile / damlBuild).value ++
           (`splice-api-token-allocation-instruction-v1-daml` / Compile / damlBuild).value ++
-          (`splice-featured-app-api-v1-daml` / Compile / damlBuild).value,
+          (`splice-api-featured-app-v1-daml` / Compile / damlBuild).value,
     )
     .dependsOn(`canton-bindings-java`)
 
@@ -810,7 +827,7 @@ lazy val `splice-util-token-standard-wallet-daml` =
         (`splice-api-token-holding-v1-daml` / Compile / damlBuild).value ++
           (`splice-api-token-metadata-v1-daml` / Compile / damlBuild).value ++
           (`splice-api-token-transfer-instruction-v1-daml` / Compile / damlBuild).value ++
-          (`splice-featured-app-api-v1-daml` / Compile / damlBuild).value,
+          (`splice-api-featured-app-v1-daml` / Compile / damlBuild).value,
     )
     .dependsOn(`canton-bindings-java`)
 
@@ -922,7 +939,7 @@ lazy val `apps-common` =
       `splice-api-token-allocation-instruction-v1-daml`,
       `splice-token-test-dummy-holding-daml`,
       `splice-token-test-trading-app-daml`,
-      `splice-featured-app-api-v1-daml`,
+      `splice-api-featured-app-v1-daml`,
     )
     .enablePlugins(BuildInfoPlugin)
     .settings(

daml/splice-amulet-name-service/daml.yaml

@@ -9,13 +9,14 @@ data-dependencies:
 - ../splice-amulet/.daml/dist/splice-amulet-current.dar
 - ../splice-util/.daml/dist/splice-util-current.dar
 - ../splice-wallet-payments/.daml/dist/splice-wallet-payments-current.dar
+
 - ../splice-api-featured-app-v1/.daml/dist/splice-api-featured-app-v1-current.dar
+- ../splice-api-credential-registry-v1/.daml/dist/splice-api-credential-registry-v1-current.dar
 - ../../token-standard/splice-api-token-metadata-v1/.daml/dist/splice-api-token-metadata-v1-current.dar
 build-options:
   - --ghc-option=-Wunused-binds
   - --ghc-option=-Wunused-matches
   - -Wno-ledger-time-is-alpha
-  - -Wupgrade-interfaces # FIXME: remove once the interface files moved
   - --target=2.1
 codegen:
   java:

daml/splice-amulet-name-service/daml/Splice/AnsV2/AnsCredential.daml

@@ -14,6 +14,8 @@ import Splice.Util
 import Splice.Api.Token.MetadataV1 (emptyMetadata)
 import Splice.Api.Credential.RegistryV1 qualified as RegistryV1
 
+
+-- | Registry for creating ANS records.
 template AnsCredentialRegistry with
     dso : Party
   where
@@ -24,9 +26,9 @@ template AnsCredentialRegistry with
         admin = dso
         meta = emptyMetadata
 
-      credentialRegistry_updateRecordsImpl self RegistryV1.CredentialRegistry_UpdateRecords{..} = do
+      credentialRegistry_updateRecordsImpl _self RegistryV1.CredentialRegistry_UpdateRecords{..} = do
         assertDeadlineExceeded "newCreatedAt" newCreatedAt
-        -- FIXME: make configurable
+        -- TODO: make configurable
         let defaultExpiresAt = addRelTime newCreatedAt (days 90) -- default to 90 day expiry
 
         -- check admin
@@ -86,69 +88,20 @@ template AnsCredentialRecord
         require "actor is stakeholder" (actor == holder || actor == issuer || actor == dso)
         assertDeadlineExceeded "expiresAt" expiresAt
 
-    -- TODO: add choice for Dso to remove invalid credential records
-
-{-
-    choice AnsCredential_DsoInvalidCreatedAt : ()
+    choice AnsCredential_DsoArchiveInvalid : ()
+      -- ^ Archive this credential record if it is invalid according to the DSO rules.
+      -- Required as the DSO party is only an observer and thus cannot control the creation of records.
       controller dso
       do
         -- created at cannot be in the future
         assertWithinDeadline "createdAt" createdAt
+        -- TODO: add check that expiresAt is not too far in the future
+        -- TODO: consider how to check that reliably when the allowed TTL changes
         pure ()
 
-    choice AnsCredential_Update : ContractId AnsCredential
-      with
-        newCreatedAt : Time
-        actor : Party
-      controller actor
-      do
-        assertDeadlineExceeded "newCreatedAt" newCreatedAt
-        create this with
-          createdAt = newCreatedAt
-
--}
-
-{-
-
-{-
-
-template AnsConfigV2 with
-    dso : Party
-    entryTTL : RelTime
-  where
-    signatory dso
-
-canton.network/url#<name> : url
-
-
--}
-
-data Credential = Credential with
-    claims : TextMap Text
-    validFrom : Optional Time
-    validUntil : Optional Time
-    createdAt : Time
-    meta : Metadata
-  deriving (Eq, Show)
-
-interface CredentialRegistry where
-  -- | Register a new credential with the DSO.
-  registerCredential : Party -> Credential -> Update (ContractId AnsCredential)
-
-
-  nonconsuming choice CredentialRegistry_UpdateCredentials
-    : ContractId Credential
-    with
-      inputCredentials : [ContractId Credential]
-      newCredentials : [Credential]
-      actors : Party
-      expectedRegisty : Party
-    controller actors
-    do updateCredentials
-
-
 
 
+{- TODO: consider exact validation rules and implement them
 
 
 validEntry : AnsCredential -> Bool

daml/splice-api-credential-registry-v1/daml.yaml

@@ -0,0 +1,18 @@
+sdk-version: 3.3.0-snapshot.20250502.13767.0.v2fc6c7e2
+name: splice-api-credential-registry-v1
+source: daml
+version: 1.0.0
+dependencies:
+  - daml-prim
+  - daml-stdlib
+data-dependencies:
+  - ../../token-standard/splice-api-token-metadata-v1/.daml/dist/splice-api-token-metadata-v1-current.dar
+build-options:
+  - --ghc-option=-Wunused-binds
+  - --ghc-option=-Wunused-matches
+  - --target=2.1
+codegen:
+  java:
+    package-prefix: org.lfdecentralizedtrust.splice.codegen.java
+    decoderClass: org.lfdecentralizedtrust.splice.codegen.java.DecoderSpliceCredentialRegistryV1
+    output-directory: target/daml-codegen-java