Skip to content

Commit 955bf68

Browse files
Fix pg14 tests (#3574)
By _not_ setting the initdb max_connections on pg14 [ci] Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
1 parent d906929 commit 955bf68

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.github/workflows/build.scala_test.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,11 @@ on:
6363
required: false
6464
type: string
6565
default: "postgres:17"
66+
postgres_init_args:
67+
description: "Additional arguments to pass to Postgres on initialization via POSTGRES_INITDB_ARGS"
68+
required: false
69+
type: string
70+
default: "-c max_connections=16000"
6671

6772
jobs:
6873

@@ -117,7 +122,7 @@ jobs:
117122
image: ${{ inputs.postgres_image }}
118123
env:
119124
POSTGRES_PASSWORD: postgres
120-
POSTGRES_INITDB_ARGS: "-c max_connections=16000"
125+
POSTGRES_INITDB_ARGS: ${{ inputs.postgres_init_args }}
121126

122127
steps:
123128

.github/workflows/build.wallclock_pg14.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,7 @@ jobs:
2424
commit_sha: ""
2525
daml_base_version: ""
2626
# This is the Postgres 14 image we built for testing. From 17 onwards, we use the official image.
27+
# It doesn't support `-c` init args. `max_connections` is set in the image itself.
2728
postgres_image: us-central1-docker.pkg.dev/da-cn-shared/ghcr/digital-asset/decentralized-canton-sync-dev/docker/splice-test-postgres:0.3.12
29+
postgres_init_args: ""
2830
secrets: inherit

0 commit comments

Comments
 (0)