migrate to Java 21 (#1033)

* set openjdk21 in nix

* set eclipse-temurin 21 & noble in Dockerfiles

- jammy will be removed for Java 22 releases; noble has been default for
  almost a year

* minor canton fork compatibility fix

* deprecated URL constructor; use recommended replacement

---------

Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>

Author: stephencompall-DA

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/AnsAuth0FrontendIntegrationTest.scala

@@ -7,7 +7,7 @@ import org.lfdecentralizedtrust.splice.integration.EnvironmentDefinition
 import org.lfdecentralizedtrust.splice.util.{FrontendLoginUtil, AnsFrontendTestUtil, WalletTestUtil}
 import monocle.macros.syntax.lens.*
 
-import java.net.URL
+import java.net.URI
 
 class AnsAuth0FrontendIntegrationTest
     extends FrontendIntegrationTest("alice")
@@ -29,7 +29,9 @@ class AnsAuth0FrontendIntegrationTest
             .replace(
               Rs256(
                 sys.env("OIDC_AUTHORITY_VALIDATOR_AUDIENCE"),
-                new URL(s"https://${sys.env("SPLICE_OAUTH_TEST_AUTHORITY")}/.well-known/jwks.json"),
+                new URI(
+                  s"https://${sys.env("SPLICE_OAUTH_TEST_AUTHORITY")}/.well-known/jwks.json"
+                ).toURL,
               )
             )
         )(c)

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/WalletAuth0FrontendIntegrationTest.scala

@@ -12,7 +12,7 @@ import org.lfdecentralizedtrust.splice.util.{
 }
 import monocle.macros.syntax.lens.*
 
-import java.net.URL
+import java.net.URI
 
 class WalletAuth0FrontendIntegrationTest
     extends FrontendIntegrationTest("randomUser")
@@ -31,7 +31,9 @@ class WalletAuth0FrontendIntegrationTest
             .replace(
               Rs256(
                 sys.env("OIDC_AUTHORITY_VALIDATOR_AUDIENCE"),
-                new URL(s"https://${sys.env("SPLICE_OAUTH_TEST_AUTHORITY")}/.well-known/jwks.json"),
+                new URI(
+                  s"https://${sys.env("SPLICE_OAUTH_TEST_AUTHORITY")}/.well-known/jwks.json"
+                ).toURL,
               )
             )
         )(spliceConfig)

canton/community/ledger/ledger-api-core/src/main/scala/com/digitalasset/canton/platform/apiserver/ratelimiting/MemoryCheck.scala

@@ -102,6 +102,7 @@ object MemoryCheck {
     }
 
     // Delegated methods
+    @deprecated("method deprecated by Java", since = "Java 18")
     override def getObjectPendingFinalizationCount: Int = delegate.getObjectPendingFinalizationCount
     override def getHeapMemoryUsage: MemoryUsage = delegate.getHeapMemoryUsage
     override def getNonHeapMemoryUsage: MemoryUsage = delegate.getNonHeapMemoryUsage

cluster/images/canton/Dockerfile

@@ -34,7 +34,7 @@ RUN ln -s bin/canton splice-image-bin
 
 FROM fullstorydev/grpcurl:v1.9.2 AS grpcurl
 
-FROM eclipse-temurin:17-jdk-jammy
+FROM eclipse-temurin:21-jdk-noble
 COPY --from=build /usr/bin/tini /usr/bin/tini
 COPY --from=build /usr/bin/screen /usr/bin/screen
 COPY --from=grpcurl /bin/grpcurl /bin/grpcurl

cluster/images/splice-app/Dockerfile

@@ -37,7 +37,7 @@ RUN mkdir -p /app/splice-node/docs/html/cn-release-bundles
 RUN ln -s splice-node/bin/splice-node splice-image-bin
 
 # This Dockerfile is a modified version of Canton's Dockerfile
-FROM eclipse-temurin:17-jdk-jammy
+FROM eclipse-temurin:21-jdk-noble
 COPY --from=build /usr/bin/tini /usr/bin/tini
 COPY --from=build /usr/bin/screen /usr/bin/screen
 COPY --from=build /app/ /app/

docs/src/release_notes.rst

@@ -14,6 +14,7 @@ Upcoming
 - Deployment
 
   - Fix a typo in the `splice-participant` Helm chart that caused the participant container to be named `participant-1` instead of `participant`.
+  - Java 21 replaces Java 17 in all Docker images and as the base JDK for building Splice apps.
 
 0.4.1
 -----

nix/overlays.nix

@@ -1,5 +1,5 @@
 [(self: super: {
-  openapi-generator-cli = (super.openapi-generator-cli.override { jre = super.openjdk17; }).overrideAttrs(oldAttrs: rec {
+  openapi-generator-cli = (super.openapi-generator-cli.override { jre = super.openjdk21; }).overrideAttrs(oldAttrs: rec {
     # 7.0.1 causes some issues in the generated package.json which break module resolution.
     version = "6.6.0";
     jarfilename = "${oldAttrs.pname}-${version}.jar";
@@ -8,7 +8,7 @@
       sha256 = "sha256-lxj/eETolGLHXc2bIKNRNvbbJXv+G4dNseMALpneRgk=";
     };
   });
-  jre = super.openjdk17;
+  jre = super.openjdk21;
   lnav = super.callPackage ./lnav.nix {};
   canton = super.callPackage ./canton.nix {};
   cometbft_driver = super.callPackage ./cometbft-driver.nix {};

nix/shell.nix

@@ -48,7 +48,7 @@ in pkgs.mkShell {
     nodePackages.node2nix
     npmPkgs.syncpack
     openapi-generator-cli
-    openjdk17
+    openjdk21
     pigz
     popeye
     postgresql_14