remove redundant version checks

[ci]

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

Author: cocreature

apps/common/src/main/openapi/common-internal.yaml

@@ -369,8 +369,9 @@ components:
 
     FeatureSupportResponse:
       type: object
-      required:
-        - no_holding_fees_on_transfers
+      required: []
       properties:
-        no_holding_fees_on_transfers:
+        # Guardrails seems to be unhappy when there are no properties so we add a dummy property.
+        # Remove once you add an actual property.
+        dummy:
           type: boolean

apps/common/src/main/scala/org/lfdecentralizedtrust/splice/environment/PackageVersionSupport.scala

@@ -81,20 +81,6 @@ trait PackageVersionSupport extends NamedLogging {
     )
   }
 
-  // TODO(#2257): remove this flag once the holding fees change has been rolled out to MainNet
-  def noHoldingFeesOnTransfers(dsoParty: PartyId, now: CantonTimestamp)(implicit
-      tc: TraceContext
-  ): Future[FeatureSupport] = {
-    isDarSupported(
-      Seq(dsoParty),
-      PackageIdResolver.Package.SpliceAmulet,
-      now,
-      DarResources.amulet,
-      // This is when the AmuletRules transfer choice was changed to not charge holding fees
-      DarResources.amulet_0_1_14,
-    )
-  }
-
   def supportsExpectedDsoParty(parties: Seq[PartyId], now: CantonTimestamp)(implicit
       tc: TraceContext
   ): Future[FeatureSupport] = {

apps/common/src/main/scala/org/lfdecentralizedtrust/splice/http/HttpFeatureSupportHandler.scala

@@ -3,22 +3,25 @@
 
 package org.lfdecentralizedtrust.splice.http
 
-import com.digitalasset.canton.data.CantonTimestamp
 import com.digitalasset.canton.logging.NamedLogging
 import com.digitalasset.canton.topology.PartyId
 import com.digitalasset.canton.tracing.{Spanning, TraceContext}
 import io.opentelemetry.api.trace.Tracer
 import org.lfdecentralizedtrust.splice.environment.PackageVersionSupport
 import org.lfdecentralizedtrust.splice.http.v0.definitions.FeatureSupportResponse
 
+import scala.annotation.nowarn
 import scala.concurrent.{ExecutionContext, Future}
 
+// silence unused warnings to avoid refactoring the code once we have a non-empty set of features again.
+@nowarn("cat=unused")
 trait HttpFeatureSupportHandler extends Spanning with NamedLogging {
 
   protected val packageVersionSupport: PackageVersionSupport
   protected val workflowId: String
   protected implicit val tracer: Tracer
 
+
   def readFeatureSupport(
       dsoParty: PartyId
   )(implicit
@@ -27,15 +30,7 @@ trait HttpFeatureSupportHandler extends Spanning with NamedLogging {
       tracer: Tracer,
   ): Future[FeatureSupportResponse] = {
     withSpan(s"$workflowId.featureSupport") { _ => _ =>
-      for {
-        noHoldingFeesOnTransfers <- packageVersionSupport
-          .noHoldingFeesOnTransfers(
-            dsoParty,
-            CantonTimestamp.now(),
-          )
-      } yield FeatureSupportResponse(
-        noHoldingFeesOnTransfers = noHoldingFeesOnTransfers.supported
-      )
+      Future.successful(FeatureSupportResponse())
     }
 
   }

apps/scan/frontend/src/__tests__/mocks/handlers/scan-api.ts

@@ -28,7 +28,7 @@ export const buildScanMock = (baseScanUrl: string): RestHandler[] => {
   const scanUrl = `${baseScanUrl}/api/scan`;
   return [
     rest.get(`${scanUrl}/v0/feature-support`, (_, res, ctx) => {
-      return res(ctx.json<FeatureSupportResponse>({ no_holding_fees_on_transfers: false }));
+      return res(ctx.json<FeatureSupportResponse>({ }));
     }),
 
     dsoInfoHandler(scanUrl),

apps/scan/frontend/src/hooks/useFeatureSupport.ts

@@ -12,7 +12,6 @@ export const useFeatureSupport = (): UseQueryResult<{
     queryFn: async () => {
       const result = await scanClient.featureSupport();
       return {
-        noHoldingFeesOnTransfers: result.no_holding_fees_on_transfers,
       };
     },
   });

apps/scan/src/main/scala/org/lfdecentralizedtrust/splice/scan/ScanApp.scala

@@ -323,8 +323,6 @@ class ScanApp(
         store,
         acsSnapshotStore,
         config.spliceInstanceNames,
-        packageVersionSupport,
-        clock,
         loggerFactory,
       )
 

apps/scan/src/main/scala/org/lfdecentralizedtrust/splice/scan/admin/http/HttpTokenStandardMetadataHandler.scala

@@ -6,10 +6,8 @@ package org.lfdecentralizedtrust.splice.scan.admin.http
 import cats.data.OptionT
 import com.digitalasset.canton.data.CantonTimestamp
 import com.digitalasset.canton.logging.{NamedLoggerFactory, NamedLogging}
-import com.digitalasset.canton.time.Clock
 import com.digitalasset.canton.tracing.{Spanning, TraceContext}
 import org.lfdecentralizedtrust.splice.config.SpliceInstanceNamesConfig
-import org.lfdecentralizedtrust.splice.environment.PackageVersionSupport
 import org.lfdecentralizedtrust.splice.scan.admin.http.HttpTokenStandardMetadataHandler.TotalSupply
 import org.lfdecentralizedtrust.tokenstandard.metadata.v1
 import org.lfdecentralizedtrust.splice.scan.store.{AcsSnapshotStore, ScanStore}
@@ -21,8 +19,6 @@ class HttpTokenStandardMetadataHandler(
     store: ScanStore,
     acsSnapshotStore: AcsSnapshotStore,
     spliceInstanceNames: SpliceInstanceNamesConfig,
-    packageVersionSupport: PackageVersionSupport,
-    clock: Clock,
     protected val loggerFactory: NamedLoggerFactory,
 )(implicit ec: ExecutionContext)
     extends v1.Handler[TraceContext]
@@ -67,12 +63,6 @@ class HttpTokenStandardMetadataHandler(
       }
   }
 
-  private def lookupTotalSupplyByLatestRound()(implicit ec: ExecutionContext, tc: TraceContext) =
-    for {
-      (latestRoundNr, effectiveAt) <- OptionT(store.lookupRoundOfLatestData())
-      totalSupply <- OptionT(store.getTotalAmuletBalance(latestRoundNr))
-    } yield TotalSupply(amount = totalSupply, asOfTimestamp = effectiveAt)
-
   private def lookupTotalSupplyByLatestAcsSnapshot()(implicit tc: TraceContext) = {
     for {
       latestSnapshot <- OptionT(
@@ -91,17 +81,7 @@ class HttpTokenStandardMetadataHandler(
 
   private def lookupTotalSupply()(implicit tc: TraceContext) = {
     for {
-      noHoldingFeesOnTransfers <- packageVersionSupport.noHoldingFeesOnTransfers(
-        store.key.dsoParty,
-        clock.now,
-      )
-      deductHoldingFees = !noHoldingFeesOnTransfers.supported
-      result <-
-        if (deductHoldingFees) {
-          lookupTotalSupplyByLatestRound().value
-        } else {
-          lookupTotalSupplyByLatestAcsSnapshot().orElse(lookupTotalSupplyByLatestRound()).value
-        }
+      result <- lookupTotalSupplyByLatestAcsSnapshot().value
     } yield result
   }
 

apps/sv/frontend/src/__tests__/mocks/handlers/sv-api.ts

@@ -185,7 +185,7 @@ export const buildSvMock = (svUrl: string): RestHandler[] => [
   }),
 
   rest.get(`${svUrl}/v0/admin/feature-support`, (_, res, ctx) => {
-    return res(ctx.json<FeatureSupportResponse>({ no_holding_fees_on_transfers: false }));
+    return res(ctx.json<FeatureSupportResponse>({ }));
   }),
 
   validatorLicensesHandler(svUrl),

apps/sv/frontend/src/contexts/SvContext.tsx

@@ -38,7 +38,6 @@ export const useFeatureSupport = (): UseQueryResult<{
     queryFn: async () => {
       const resp = await featureSupport();
       return {
-        noHoldingFeesOnTransfers: resp.no_holding_fees_on_transfers,
       };
     },
   });

apps/wallet/frontend/src/hooks/useFeatureSupport.tsx

@@ -18,7 +18,6 @@ export const useFeatureSupport = (): UseQueryResult<WalletFeatureSupport> => {
       return {
         tokenStandard: result.token_standard,
         transferPreapprovalDescription: result.transfer_preapproval_description,
-        noHoldingFeesOnTransfers: result.no_holding_fees_on_transfers,
       };
     },
   });