Skip to content

Commit 9eb368a

Browse files
committed
[static] cleanups
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
1 parent 622f80f commit 9eb368a

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

cluster/pulumi/infra/src/auth0.ts

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,11 @@ import {
1313
NamespaceToClientIdMapMap,
1414
clusterProdLike,
1515
} from '@lfdecentralizedtrust/splice-pulumi-common';
16-
import { standardSvConfigs, extraSvConfigs, dsoSize } from '@lfdecentralizedtrust/splice-pulumi-common-sv';
16+
import {
17+
standardSvConfigs,
18+
extraSvConfigs,
19+
dsoSize,
20+
} from '@lfdecentralizedtrust/splice-pulumi-common-sv';
1721

1822
function ledgerApiAudience(
1923
svNamespaces: string,
@@ -27,7 +31,7 @@ function ledgerApiAudience(
2731
{
2832
name: `Ledger API for SV ${svNamespaces} on ${clusterBasename} (Pulumi managed)`,
2933
identifier: `https://ledger_api.${svNamespaces}.${clusterBasename}.canton.network`,
30-
allowOfflineAccess: true, // FIXME: create an issue to review whether we need this here and in docs (seems like we don't any more, was for ANS UI in the past, now it's only splitwell)
34+
allowOfflineAccess: true, // TODO(DACH-NY/canton-network-internal#2114): is this still needed?
3135
},
3236
{ provider: auth0DomainProvider }
3337
);
@@ -65,7 +69,7 @@ function svAppAudience(
6569
{
6670
name: `SV App API for SV ${svNamespaces} on ${clusterBasename} (Pulumi managed)`,
6771
identifier: `https://sv.${svNamespaces}.${clusterBasename}.canton.network/api`,
68-
allowOfflineAccess: true,
72+
allowOfflineAccess: true, // TODO(DACH-NY/canton-network-internal#2114): is this still needed?
6973
},
7074
{ provider: auth0DomainProvider }
7175
);
@@ -89,7 +93,7 @@ function validatorAppAudience(
8993
{
9094
name: `Validator App API for SV ${svNamespaces} on ${clusterBasename} (Pulumi managed)`,
9195
identifier: `https://validator.${svNamespaces}.${clusterBasename}.canton.network/api`,
92-
allowOfflineAccess: true,
96+
allowOfflineAccess: true, // TODO(DACH-NY/canton-network-internal#2114): is this still needed?
9397
},
9498
{ provider: auth0DomainProvider }
9599
);
@@ -283,7 +287,7 @@ function svsOnlyAuth0(
283287
// Currently, for no good reason, we have sv-1 vs sv1_validator naming inconsistency.
284288
// To make things worse, the sv-da-1 namespace is even more special and has sv-da-1 vs sv-da-1_validator.
285289
// Then mainnet DA-2 is even worse, as we use "sv" and "validator"
286-
// FIXME: decide whether to clean this up, or leave as-is for now and open a tech-debt ticket to clean up later.
290+
// TODO(DACH-NY/canton-internal#2110): clean this up
287291
const svAppName = isMainNet && sv.namespace == 'sv-1' ? 'sv' : sv.namespace;
288292
const validatorAppName =
289293
sv.namespace == 'sv-da-1'
@@ -379,11 +383,13 @@ function nonMainNetAuth0(clusterBasename: string, dnsNames: string[]): pulumi.Ou
379383
clientSecret: auth0MgtClientSecret,
380384
});
381385

382-
const standardSvs: svAuth0Params[] = standardSvConfigs.map(sv => ({
383-
namespace: sv.nodeName,
384-
description: sv.nodeName.replace(/-/g, '').toUpperCase(),
385-
ingressName: sv.ingressName,
386-
})).slice(0, dsoSize);
386+
const standardSvs: svAuth0Params[] = standardSvConfigs
387+
.map(sv => ({
388+
namespace: sv.nodeName,
389+
description: sv.nodeName.replace(/-/g, '').toUpperCase(),
390+
ingressName: sv.ingressName,
391+
}))
392+
.slice(0, dsoSize);
387393
const extraSvs: svAuth0Params[] = extraSvConfigs.map(sv => ({
388394
namespace: sv.nodeName,
389395
description: sv.onboardingName,

0 commit comments

Comments
 (0)