Skip to content

Commit ade6735

Browse files
author
DA Automation
committed
[ci] Update Splice from CCI
Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>
1 parent 723bfaf commit ade6735

File tree

3 files changed

+25
-68
lines changed

3 files changed

+25
-68
lines changed

apps/wallet/src/main/scala/org/lfdecentralizedtrust/splice/wallet/automation/WalletTransferOfferSweepTrigger.scala

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,14 @@ class WalletTransferOfferSweepTrigger(
3939
currentAmuletConfig: AmuletConfig[USD],
4040
)(implicit tc: TraceContext): scala.concurrent.Future[BigDecimal] = {
4141
for {
42-
(filteredTransferOffers, filteredAcceptedTransferOffers) <- store
43-
.getOutstandingTransferOffers(
44-
None,
45-
Some(config.receiver),
46-
)
47-
} yield (filteredTransferOffers.map(_.payload.amount.amount) ++ filteredAcceptedTransferOffers
48-
.map(_.payload.amount.amount))
49-
.map(amount => {
50-
BigDecimal(ccToDollars(amount, amuletPrice)) + computeTransferFees(
51-
BigDecimal(amount),
42+
filteredTransferOffers <- store.getOutstandingTransferOffers(
43+
None,
44+
Some(config.receiver),
45+
)
46+
} yield filteredTransferOffers
47+
.map(c => {
48+
BigDecimal(ccToDollars(c.payload.amount.amount, amuletPrice)) + computeTransferFees(
49+
BigDecimal(c.payload.amount.amount),
5250
currentAmuletConfig.transferConfig.transferFee,
5351
) + computeCreateFees(currentAmuletConfig)
5452
})
@@ -66,15 +64,12 @@ class WalletTransferOfferSweepTrigger(
6664
amountToSendAfterFeesCC: java.math.BigDecimal,
6765
)(implicit tc: TraceContext): Future[Unit] = {
6866
for {
69-
(filteredTransferOffers, acceptedFilteredTransferOffers) <- store
70-
.getOutstandingTransferOffers(
71-
None,
72-
Some(config.receiver),
73-
)
67+
filteredTransferOffers <- store.getOutstandingTransferOffers(
68+
None,
69+
Some(config.receiver),
70+
)
7471
transferOfferAlreadyExists = filteredTransferOffers.exists(
7572
_.payload.trackingId == task.trackingId
76-
) || acceptedFilteredTransferOffers.exists(
77-
_.payload.trackingId == task.trackingId
7873
)
7974
install <- store.getInstall()
8075
_ <-

apps/wallet/src/main/scala/org/lfdecentralizedtrust/splice/wallet/store/UserWalletStore.scala

Lines changed: 5 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -344,25 +344,14 @@ trait UserWalletStore extends TxLogAppStore[TxLogEntry] with TransferInputStore
344344
)(implicit
345345
tc: TraceContext,
346346
ec: ExecutionContext,
347-
): Future[
348-
(
349-
Seq[AssignedContract[
350-
transferOffersCodegen.TransferOffer.ContractId,
351-
transferOffersCodegen.TransferOffer,
352-
]],
353-
Seq[AssignedContract[
354-
transferOffersCodegen.AcceptedTransferOffer.ContractId,
355-
transferOffersCodegen.AcceptedTransferOffer,
356-
]],
357-
)
358-
] = {
347+
): Future[Seq[AssignedContract[
348+
transferOffersCodegen.TransferOffer.ContractId,
349+
transferOffersCodegen.TransferOffer,
350+
]]] = {
359351
for {
360352
transferOffers <- multiDomainAcsStore.listAssignedContracts(
361353
transferOffersCodegen.TransferOffer.COMPANION
362354
)
363-
acceptedTransferOffers <- multiDomainAcsStore.listAssignedContracts(
364-
transferOffersCodegen.AcceptedTransferOffer.COMPANION
365-
)
366355
} yield {
367356
val offersFilteredFrom = fromParty match {
368357
case None => transferOffers
@@ -374,18 +363,7 @@ trait UserWalletStore extends TxLogAppStore[TxLogEntry] with TransferInputStore
374363
case Some(toParty) =>
375364
offersFilteredFrom.filter(_.payload.receiver == toParty.toProtoPrimitive)
376365
}
377-
378-
val acceptedOffersFilteredFrom = fromParty match {
379-
case None => acceptedTransferOffers
380-
case Some(fromParty) =>
381-
acceptedTransferOffers.filter(_.payload.sender == fromParty.toProtoPrimitive)
382-
}
383-
val acceptedOffersFilteredTo = toParty match {
384-
case None => acceptedOffersFilteredFrom
385-
case Some(toParty) =>
386-
acceptedOffersFilteredFrom.filter(_.payload.receiver == toParty.toProtoPrimitive)
387-
}
388-
(offersFilteredTo, acceptedOffersFilteredTo)
366+
offersFilteredTo
389367
}
390368
}
391369

apps/wallet/src/test/scala/org/lfdecentralizedtrust/splice/store/db/UserWalletStoreTest.scala

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -945,51 +945,35 @@ abstract class UserWalletStoreTest extends TransferInputStoreTest with HasExecut
945945
for {
946946
store <- mkStore(user1)
947947
offer1 = transferOffer(user1, user2, 10.0, paymentCodegen.Unit.AMULETUNIT, time(1))
948-
acceptedOffer = acceptedTransferOffer(
949-
user1,
950-
user2,
951-
10.0,
952-
paymentCodegen.Unit.AMULETUNIT,
953-
time(1),
954-
)
955948
_ <- dummyDomain.create(offer1, createdEventSignatories = Seq(user1))(
956949
store.multiDomainAcsStore
957950
)
958-
_ <- dummyDomain.create(acceptedOffer, createdEventSignatories = Seq(user1))(
959-
store.multiDomainAcsStore
960-
)
961-
(unfiltered, unfilteredAccepted) <- store.getOutstandingTransferOffers(
951+
unfiltered <- store.getOutstandingTransferOffers(
962952
None,
963953
None,
964954
)
965-
(filteredSenderMatch, filteredSenderMatchAccepted) <- store.getOutstandingTransferOffers(
955+
filteredSenderMatch <- store.getOutstandingTransferOffers(
966956
Some(user1),
967957
None,
968958
)
969-
(filteredSenderNoMatch, filteredSenderNoMatchAccepted) <- store.getOutstandingTransferOffers(
959+
filteredSenderNoMatch <- store.getOutstandingTransferOffers(
970960
Some(user2),
971961
None,
972962
)
973-
(filteredReceiverMatch, filteredReceiverMatchAccepted) <- store.getOutstandingTransferOffers(
963+
filteredReceiverMatch <- store.getOutstandingTransferOffers(
974964
None,
975965
Some(user2),
976966
)
977-
(filteredReceiverNoMatch, filteredReceiverNoMatchAccepted) <- store
978-
.getOutstandingTransferOffers(
979-
None,
980-
Some(user1),
981-
)
967+
filteredReceiverNoMatch <- store.getOutstandingTransferOffers(
968+
None,
969+
Some(user1),
970+
)
982971
} yield {
983972
unfiltered.map(_.contractId) shouldBe Seq(offer1.contractId)
984-
unfilteredAccepted.map(_.contractId) shouldBe Seq(acceptedOffer.contractId)
985973
filteredSenderMatch.map(_.contractId) shouldBe Seq(offer1.contractId)
986-
filteredSenderMatchAccepted.map(_.contractId) shouldBe Seq(acceptedOffer.contractId)
987974
filteredSenderNoMatch.map(_.contractId) shouldBe Seq()
988-
filteredSenderNoMatchAccepted.map(_.contractId) shouldBe Seq()
989975
filteredReceiverMatch.map(_.contractId) shouldBe Seq(offer1.contractId)
990-
filteredReceiverMatchAccepted.map(_.contractId) shouldBe Seq(acceptedOffer.contractId)
991976
filteredReceiverNoMatch.map(_.contractId) shouldBe Seq()
992-
filteredReceiverNoMatchAccepted.map(_.contractId) shouldBe Seq()
993977
}
994978
}
995979

0 commit comments

Comments
 (0)