Avoid refreshing BftScanConnection too often when less than f scans are failing (#1151)

---------

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

Author: OriolMunoz-da

apps/scan/src/main/scala/org/lfdecentralizedtrust/splice/scan/admin/api/client/BftScanConnection.scala

@@ -132,21 +132,14 @@ class BftScanConnection(
           retryProvider.timeouts,
           "refresh_scan_list",
         )({ tc =>
-          // This retry makes sure any partial or complete failures are immediately retried with a backoff.
+          // refresh will throw if we're in a state where there's no BFT guarantees, in which case
+          // this will retry faster than the regular `bft.scansRefreshInterval`
           FutureUnlessShutdown.outcomeF(
             retryProvider.retry(
               RetryFor.LongRunningAutomation,
               "refresh_scan_list",
               "refresh_scan_list",
-              bft.refresh(this)(tc).flatMap { connections =>
-                if (connections.failed > 0)
-                  Future.failed(
-                    io.grpc.Status.UNAVAILABLE
-                      .withDescription("Deliberately enforcing a retry on failed scans.")
-                      .asRuntimeException()
-                  )
-                else Future.unit
-              },
+              bft.refresh(this)(tc),
               logger,
             )(implicitly, TraceContext.empty, implicitly)
           )