Restrict amulet configs to not allow fees

[ci]

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

remove more unused code

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

Author: cocreature

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/config/ConfigTransforms.scala

@@ -196,7 +196,6 @@ object ConfigTransforms {
       disableOnboardingParticipantPromotionDelay(),
       setDefaultGrpcDeadlineForBuyExtraTraffic(),
       setDefaultGrpcDeadlineForTreasuryService(),
-      disableZeroFees(),
       updateAllAutomationConfigs(
         _.copy(rewardOperationRoundsCloseBufferDuration = NonNegativeFiniteDuration.ofMillis(100))
       ),
@@ -296,9 +295,6 @@ object ConfigTransforms {
       )
     )
 
-  def disableZeroFees(): ConfigTransform =
-    updateAllSvAppFoundDsoConfigs_(c => c.copy(zeroTransferFees = false))
-
   def updateAllValidatorAppConfigs(
       update: (String, ValidatorAppBackendConfig) => ValidatorAppBackendConfig
   ): ConfigTransform =

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/plugins/UpdateHistorySanityCheckPlugin.scala

@@ -234,6 +234,7 @@ class UpdateHistorySanityCheckPlugin(
       }
       if (lines.nonEmpty) {
         val message = s"${this.getClass} contains errors: $lines, exiting test."
+        readLines.foreach(logger.warn(_))
         logger.error(message)
         System.err.println(message)
         sys.exit(1)

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/BootstrapPackageConfigIntegrationTest.scala

@@ -360,7 +360,6 @@ class BootstrapPackageConfigIntegrationTest extends IntegrationTest with Splitwe
         SpliceUtil.defaultTransferConfig(
           amuletConfig.transferConfig.maxNumInputs.toInt,
           amuletConfig.transferConfig.holdingFee.rate,
-          zeroTransferFees = true,
         ),
         amuletConfig.issuanceCurve,
         amuletConfig.decentralizedSynchronizer,

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/BootstrapTest.scala

@@ -27,7 +27,6 @@ class BootstrapTest extends IntegrationTest {
       // We reduce the polling interval here primarily for the top-up trigger to ensure that a top-up happens as soon as
       // possible during the validator setup and other txs do not get throttled for want of traffic.
       .addConfigTransform((_, config) => ConfigTransforms.reducePollingInterval(config))
-      .addConfigTransform((_, config) => ConfigTransforms.disableZeroFees()(config))
 
   "Bootstrap script should pass" in { implicit env =>
     // the script logs errors when a ANS name check fails but then recovers from this

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/ScanFrontendTimeBasedIntegrationTest.scala

@@ -240,15 +240,15 @@ class ScanFrontendTimeBasedIntegrationTest
           "Check the initial amulet config matches the defaults",
           _ => {
             find(id("base-transfer-fee")).value.text should matchText(
-              s"${SpliceUtil.defaultCreateFee.fee.doubleValue()} USD"
+              s"0.0 USD"
             )
 
             find(id("holding-fee")).value.text should matchText(
               s"${SpliceUtil.defaultHoldingFee.rate} USD/Round"
             )
 
             find(id("lock-holder-fee")).value.text should matchText(
-              s"${SpliceUtil.defaultLockHolderFee.fee.doubleValue()} USD"
+              s"0.0 USD"
             )
 
             find(id("round-tick-duration")).value.text should matchText {
@@ -259,7 +259,7 @@ class ScanFrontendTimeBasedIntegrationTest
 
             findAll(className("transfer-fee-row")).toList
               .map(_.text)
-              .zip(SpliceUtil.defaultTransferFee.steps.asScala.toList)
+              .zip(SpliceUtil.zeroTransferFee.steps.asScala.toList)
               .foreach({
                 case (txFeeRow, defaultStep) => {
                   txFeeRow should include(defaultStep._1.setScale(0).toString)

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/ScanIntegrationTest.scala

@@ -17,7 +17,6 @@ import org.lfdecentralizedtrust.splice.codegen.java.splice.round.OpenMiningRound
 import org.lfdecentralizedtrust.splice.config.ConfigTransforms
 import org.lfdecentralizedtrust.splice.config.ConfigTransforms.{
   ConfigurableApp,
-  updateAllSvAppFoundDsoConfigs_,
   updateAutomationConfig,
 }
 import org.lfdecentralizedtrust.splice.http.v0.definitions.{
@@ -51,11 +50,6 @@ class ScanIntegrationTest extends IntegrationTest with WalletTestUtil with TimeT
   override def environmentDefinition: SpliceEnvironmentDefinition =
     EnvironmentDefinition
       .simpleTopology1Sv(this.getClass.getSimpleName)
-      .addConfigTransforms((_, config) =>
-        updateAllSvAppFoundDsoConfigs_(
-          _.copy(zeroTransferFees = true)
-        )(config)
-      )
       .addConfigTransforms((_, config) =>
         (updateAutomationConfig(ConfigurableApp.Validator)(
           _.withPausedTrigger[CollectRewardsAndMergeAmuletsTrigger]

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/ScanTimeBasedIntegrationTest.scala

@@ -13,15 +13,13 @@ import org.lfdecentralizedtrust.splice.console.WalletAppClientReference
 import org.lfdecentralizedtrust.splice.http.v0.definitions
 import org.lfdecentralizedtrust.splice.integration.EnvironmentDefinition
 import org.lfdecentralizedtrust.splice.integration.tests.SpliceTests.IntegrationTest
-import org.lfdecentralizedtrust.splice.scan.admin.api.client.commands.HttpScanAppClient
 import org.lfdecentralizedtrust.splice.scan.automation.ScanAggregationTrigger
 import org.lfdecentralizedtrust.splice.scan.store.db.ScanAggregator
 import org.lfdecentralizedtrust.splice.store.UpdateHistory.BackfillingState
 import org.lfdecentralizedtrust.splice.util.*
 import org.lfdecentralizedtrust.splice.util.SpliceUtil.defaultAnsConfig
 
 import java.time.Duration
-import scala.jdk.CollectionConverters.*
 
 class ScanTimeBasedIntegrationTest
     extends IntegrationTest
@@ -80,26 +78,15 @@ class ScanTimeBasedIntegrationTest
       val cfg = eventuallySucceeds() {
         sv1ScanBackend.getAmuletConfigForRound(firstRound + 3)
       }
-      cfg.amuletCreateFee.bigDecimal.setScale(10) should be(
-        SpliceUtil.defaultCreateFee.fee divide walletAmuletPrice setScale 10
-      )
+      cfg.amuletCreateFee.bigDecimal.setScale(10) should be(BigDecimal(0).bigDecimal.setScale(10))
       cfg.holdingFee.bigDecimal.setScale(10) should be(
         SpliceUtil.defaultHoldingFee.rate divide walletAmuletPrice setScale 10
       )
-      cfg.lockHolderFee.bigDecimal.setScale(10) should be(
-        SpliceUtil.defaultLockHolderFee.fee divide walletAmuletPrice setScale 10
-      )
+      cfg.lockHolderFee.bigDecimal.setScale(10) should be(BigDecimal(0).bigDecimal.setScale(10))
       cfg.transferFee.initial.bigDecimal.setScale(10) should be(
-        SpliceUtil.defaultTransferFee.initialRate.setScale(10)
-      )
-      cfg.transferFee.steps shouldBe (
-        SpliceUtil.defaultTransferFee.steps.asScala.toSeq.map(step =>
-          HttpScanAppClient.RateStep(
-            step._1 divide walletAmuletPrice,
-            step._2,
-          )
-        )
+        SpliceUtil.zeroTransferFee.initialRate.setScale(10)
       )
+      cfg.transferFee.steps shouldBe empty
     }
 
     clue(s"Try to get config for round ${firstRound + 4} which does not yet exist") {

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/SvFrontendIntegrationTest.scala

@@ -904,7 +904,6 @@ class SvFrontendIntegrationTest
           // If we try to create two vote requests for identical configs,
           // the second request will be rejected with "This vote request has already been created."
           def submitSetAmuletConfigRequestViaBackend(
-              createFee: String,
               holdingFee: String = "0.001",
               expiresSoon: Boolean,
           ): Unit = {
@@ -918,7 +917,6 @@ class SvFrontendIntegrationTest
               defaultTickDuration,
               1000,
               holdingFee = BigDecimal(holdingFee),
-              createFee = BigDecimal(createFee),
             )
             val setAmuletConfigAction: ActionRequiringConfirmation = new ARC_AmuletRules(
               new CRARC_SetConfig(
@@ -978,7 +976,7 @@ class SvFrontendIntegrationTest
 
           actAndCheck(
             "sv1 operator creates a new vote request with a short expiration time", {
-              submitSetAmuletConfigRequestViaBackend(createFee = "41", expiresSoon = true)
+              submitSetAmuletConfigRequestViaBackend(expiresSoon = true)
             },
           )(
             "sv1 can see the new vote request in the progress tab",
@@ -988,7 +986,6 @@ class SvFrontendIntegrationTest
           val (_, requestId) = actAndCheck(
             "sv1 operator creates a new vote request with a long expiration time", {
               submitSetAmuletConfigRequestViaBackend(
-                createFee = "0.03",
                 holdingFee = "42",
                 expiresSoon = false,
               )

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/TokenStandardTransferIntegrationTest.scala

@@ -8,7 +8,6 @@ import org.lfdecentralizedtrust.splice.codegen.java.splice.api.token.metadatav1
 import org.lfdecentralizedtrust.splice.codegen.java.splice.api.token.transferinstructionv1.TransferInstruction
 import org.lfdecentralizedtrust.splice.config.ConfigTransforms.{
   ConfigurableApp,
-  updateAllSvAppFoundDsoConfigs_,
   updateAutomationConfig,
 }
 import org.lfdecentralizedtrust.splice.http.v0.definitions.TransferInstructionResultOutput.members
@@ -51,11 +50,6 @@ class TokenStandardTransferIntegrationTest
           _.withPausedTrigger[CollectRewardsAndMergeAmuletsTrigger]
         )(config)
       )
-      .addConfigTransforms((_, config) =>
-        updateAllSvAppFoundDsoConfigs_(
-          _.copy(zeroTransferFees = true)
-        )(config)
-      )
   }
 
   "Token Standard Transfers should" should {

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/util/AmuletConfigUtil.scala

@@ -36,7 +36,6 @@ trait AmuletConfigUtil extends TestCommon {
       tickDuration: NonNegativeFiniteDuration,
       maxNumInputs: Int = 100,
       holdingFee: BigDecimal = SpliceUtil.defaultHoldingFee.rate,
-      createFee: BigDecimal = SpliceUtil.defaultCreateFee.fee,
   )(implicit
       env: SpliceTests.SpliceTestConsoleEnvironment
   ): splice.amuletconfig.AmuletConfig[splice.amuletconfig.USD] = {
@@ -45,9 +44,7 @@ trait AmuletConfigUtil extends TestCommon {
     val existingTransferConfig = existingAmuletConfig.transferConfig
     new splice.amuletconfig.AmuletConfig(
       new splice.amuletconfig.TransferConfig(
-        new splice.fees.FixedFee(
-          createFee.bigDecimal.setScale(10, BigDecimal.RoundingMode.HALF_EVEN).bigDecimal
-        ),
+        existingTransferConfig.createFee,
         new splice.fees.RatePerRound(
           holdingFee.bigDecimal.setScale(10, BigDecimal.RoundingMode.HALF_EVEN).bigDecimal
         ),