Skip to content

Commit d275dc9

Browse files
Bump vetting delay to 24h (#2435)
Honestly kinda random. I do wonder if we can just set it to a week or even longer but in practice this seems long enough for this year at least given our validator scaling expectations. [ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org> Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
1 parent 2d72338 commit d275dc9

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

apps/sv/src/main/scala/org/lfdecentralizedtrust/splice/sv/config/SvAppConfig.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,9 @@ case class SvAppBackendConfig(
336336
// distributed between 0 and the maximum delay) to ensure that not
337337
// all validators submit the transaction at the same time
338338
// overloading the network.
339-
maxVettingDelay: NonNegativeFiniteDuration = NonNegativeFiniteDuration.ofHours(1),
339+
// 24h is chosen to be long enough to avoid a load spike (it's ~86k seconds so assuming it's 1 topology transaction/s on average for 86k validators)
340+
// but short enough to allow for node downtime and other issues.
341+
maxVettingDelay: NonNegativeFiniteDuration = NonNegativeFiniteDuration.ofHours(24),
340342
// `latestPackagesOnly=true` is intended for LocalNet testing only and is not supported in production
341343
latestPackagesOnly: Boolean = false,
342344
followAmuletConversionRateFeed: Option[AmuletConversionRateFeedConfig] = None,

apps/validator/src/main/scala/org/lfdecentralizedtrust/splice/validator/config/ValidatorAppConfig.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,9 @@ case class ValidatorAppBackendConfig(
206206
// distributed between 0 and the maximum delay) to ensure that not
207207
// all validators submit the transaction at the same time
208208
// overloading the network.
209-
maxVettingDelay: NonNegativeFiniteDuration = NonNegativeFiniteDuration.ofHours(1),
209+
// 24h is chosen to be long enough to avoid a load spike (it's ~86k seconds so assuming it's 1 topology transaction/s on average for 86k validators)
210+
// but short enough to allow for node downtime and other issues.
211+
maxVettingDelay: NonNegativeFiniteDuration = NonNegativeFiniteDuration.ofHours(24),
210212
// `latestPackagesOnly=true` is intended for LocalNet testing only and is not supported in production
211213
latestPackagesOnly: Boolean = false,
212214
) extends SpliceBackendConfig // TODO(DACH-NY/canton-network-node#736): fork or generalize this trait.

0 commit comments

Comments
 (0)