Bump vetting delay to 24h (#2435)

Honestly kinda random. I do wonder if we can just set it to a week or
even longer but in practice this seems long enough for this year at
least given our validator scaling expectations.

[ci]

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

Author: moritzkiefer-da

apps/sv/src/main/scala/org/lfdecentralizedtrust/splice/sv/config/SvAppConfig.scala

@@ -336,7 +336,9 @@ case class SvAppBackendConfig(
     // distributed between 0 and the maximum delay) to ensure that not
     // all validators submit the transaction at the same time
     // overloading the network.
-    maxVettingDelay: NonNegativeFiniteDuration = NonNegativeFiniteDuration.ofHours(1),
+    // 24h is chosen to be long enough to avoid a load spike (it's ~86k seconds so assuming it's 1 topology transaction/s on average for 86k validators)
+    // but short enough to allow for node downtime and other issues.
+    maxVettingDelay: NonNegativeFiniteDuration = NonNegativeFiniteDuration.ofHours(24),
     // `latestPackagesOnly=true` is intended for LocalNet testing only and is not supported in production
     latestPackagesOnly: Boolean = false,
     followAmuletConversionRateFeed: Option[AmuletConversionRateFeedConfig] = None,

apps/validator/src/main/scala/org/lfdecentralizedtrust/splice/validator/config/ValidatorAppConfig.scala

@@ -206,7 +206,9 @@ case class ValidatorAppBackendConfig(
     // distributed between 0 and the maximum delay) to ensure that not
     // all validators submit the transaction at the same time
     // overloading the network.
-    maxVettingDelay: NonNegativeFiniteDuration = NonNegativeFiniteDuration.ofHours(1),
+    // 24h is chosen to be long enough to avoid a load spike (it's ~86k seconds so assuming it's 1 topology transaction/s on average for 86k validators)
+    // but short enough to allow for node downtime and other issues.
+    maxVettingDelay: NonNegativeFiniteDuration = NonNegativeFiniteDuration.ofHours(24),
     // `latestPackagesOnly=true` is intended for LocalNet testing only and is not supported in production
     latestPackagesOnly: Boolean = false,
 ) extends SpliceBackendConfig // TODO(DACH-NY/canton-network-node#736): fork or generalize this trait.