Make shellcheck cover our .source files

...and fix them so it passes.

This is to avoid issues such as #3650

[static]

I tried tweaking `.pre-commit-config.yaml` instead but it didn't quite work / ended up way too complex.

With only two affected files, adding a line on top and adding `+x` seems like a reasonable workaround...

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>

Author: martinflorian-da

build-tools/lib/libcli.source

@@ -1,11 +1,14 @@
-# -*- shell-script -*-
+#!/usr/bin/env bash
+
+# Copyright (c) 2024 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
+# SPDX-License-Identifier: Apache-2.0
 
 # common functions for use with bash based clis
 # all functions must be prefixed with _
 
 # make a fancy header
 function _header(){
-  local msg="$@"
+  local msg="$*"
   local vbar
   printf -v vbar '─%.0s' $(seq $((${#msg} +2)) )
   local out
@@ -30,6 +33,7 @@ function _prefix(){
   else
     cat
   fi | while read -r; do
+    # shellcheck disable=SC2059
     printf -- "${format}" "${REPLY}"
   done
 }
@@ -60,7 +64,7 @@ function _debug() {
 
 # issue a user friendly red error
 function _error_msg(){
-  echo -e "\e[1;31mERROR: $@\e[0m" >&2
+  echo -e "\e[1;31mERROR: $*\e[0m" >&2
 }
 
 # issue a user friendly green informational message
@@ -84,12 +88,12 @@ function _warning(){
 
 # prints a little green check mark before $@
 function _ok(){
-  echo -e "\e[32;1m✔\e[0m ${@}"
+  echo -e "\e[32;1m✔\e[0m $*"
 }
 
 # prints a little red x mark before $@ and sets check to 1 if you are using it
 function _nope(){
-  echo -e "\e[31;1m✘\e[0m ${@}"
+  echo -e "\e[31;1m✘\e[0m $*"
 }
 
 
@@ -130,15 +134,16 @@ function _join(){
 
 # buffer the output of a long command and output it when it is done
 function _pipe_buffer(){
-  local buff="$(mktemp)"
+  local buff
+  buff="$(mktemp)"
   cat > "${buff}"
   cat "${buff}"
 }
 
 
 # just sha returns just the sha without the file names
 function _just_sha(){
-  sha256sum $@ | cut -f1 -d' '
+  sha256sum "$@" | cut -f1 -d' '
 }
 
 # checks if a function exists
@@ -149,23 +154,24 @@ function _has_func(){
 
 # copies a function
 function _cp_func(){
-  _has_func $1 || return
-  local code="$(declare -f "$1" | tail -n+2)"
+  _has_func "$1" || return
+  local code
+  code="$(declare -f "$1" | tail -n+2)"
   eval "function ${2}()${code}"
 }
 
 
 # basic confirm action
 function _confirm(){
   echo -e "$@"
-  read -p '[y/n]: '
+  read -r -p '[y/n]: '
   [ "${REPLY}" == 'y' ] || exit 0
 }
 
 # run a command with set -x
 function _set_x(){
   set -x
-  $@ ; RC=$?
+  "$@" ; RC=$?
   { set +x; } 2>/dev/null
   return $RC
 }

cluster/scripts/utils.source

@@ -1,3 +1,9 @@
+#!/usr/bin/env bash
+
+# Copyright (c) 2024 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
+# SPDX-License-Identifier: Apache-2.0
+
+
 function get_postgres_type() {
   local instance=$1
   local stack=$2
@@ -43,7 +49,7 @@ function get_stack_for_namespace_component() {
     stack="$namespace"
   fi
 
-  echo $stack
+  echo "$stack"
 }
 
 create_component_instance() {