Skip to content

Commit df96111

Browse files
Add todo
[ci] Signed-off-by: Robert Autenrieth <robert.autenrieth@digitalasset.com>
1 parent 8d3a367 commit df96111

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

apps/scan/src/main/scala/org/lfdecentralizedtrust/splice/scan/store/AcsSnapshotStore.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,10 +175,9 @@ class AcsSnapshotStore(
175175
* Regular locks (e.g. obtained via `LOCK TABLE ... IN EXCLUSIVE MODE`) would conflict with harmless
176176
* background operations like autovacuum or create index concurrently.
177177
*
178-
* In case the application crashes while holding the lock, the server should close the connection
178+
* In case the application crashes while holding the lock, the server _should_ close the connection
179179
* and abort the transaction as soon as it detects a disconnect.
180-
* See [[com.digitalasset.canton.platform.store.backend.postgresql.PostgresDataSourceConfig]] for our connection keepalive settings.
181-
* With default settings, the server should detect a dead connection within ~15sec.
180+
* TODO(#2488): Verify that the server indeed closes connections in a reasonable time.
182181
*/
183182
private def withExclusiveSnapshotDataLock[T, E <: Effect](
184183
action: DBIOAction[T, NoStream, E]

0 commit comments

Comments
 (0)