Fix scan_txlog.py handling of holding fees #2478
Conversation
[ci] Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
scripts/scan-txlog/scan_txlog.py
Outdated
| amulet_cc_input, | ||
| all_inputs, | ||
| ) = transfer_inputs.summary(self.args.subtract_holding_fees_per_round) | ||
| ) = transfer_inputs.summary(event.template_id.package_id) |
There was a problem hiding this comment.
amuletrules_transfer
There was a problem hiding this comment.
have you considered making summar take an ExercisedEvent as the argument and then read the package id from there? That feels like it may be more robust against e.g. the issue where you used the template id of the amulet.
scripts/scan-txlog/scan_txlog.py
Outdated
| amulet_cc_input, | ||
| all_inputs, | ||
| ) = transfer_inputs.summary(self.args.subtract_holding_fees_per_round) | ||
| ) = transfer_inputs.summary(event.template_id.package_id) |
There was a problem hiding this comment.
AmuletRules_BuyMemberTraffic
scripts/scan-txlog/scan_txlog.py
Outdated
| amulet_cc_input, | ||
| all_inputs, | ||
| ) = transfer_inputs.summary(self.args.subtract_holding_fees_per_round) | ||
| ) = transfer_inputs.summary(event.template_id.package_id) |
There was a problem hiding this comment.
AmuletRules_CreateExternalPartySetupProposal or AmuletRules_CreateTransferPreapproval or TransferPreapproval_Renew
(all in splice-amulet)
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
Nice thanks for the fix! I assume you tested it against the failing test on 3.4.
scripts/scan-txlog/scan_txlog.py
Outdated
| amulet_cc_input, | ||
| all_inputs, | ||
| ) = transfer_inputs.summary(self.args.subtract_holding_fees_per_round) | ||
| ) = transfer_inputs.summary(event.template_id.package_id) |
There was a problem hiding this comment.
have you considered making summar take an ExercisedEvent as the argument and then read the package id from there? That feels like it may be more robust against e.g. the issue where you used the template id of the amulet.
Yes, removed the pause block too. But do let me know if you find it broken again |
wanna make a PR against the 3.4 branch with that? |
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
Fixes #2380
Testing locally on 3.4... Success!
