Skip to content

Conversation

@dfordivam
Copy link
Contributor

@dfordivam dfordivam commented Jan 20, 2026

Fixes #3554

  • Adds support for minting DevelopmentFundCoupon in the trigger
  • Enhanced the existing test in daml and the integration test

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Divam <dfordivam@gmail.com>
- Add MintingDelegationCollectRewardsTrigger
- Bump version of DbExternalPartyWalletStore
- Bump version of DbUserWalletStore

Squashed commits from the PR reviewed in #3470

Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam dfordivam requested a review from meiersi-da January 20, 2026 07:22
Copy link
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick turnaround @dfordivam . Looks good!

dfordivam added a commit that referenced this pull request Jan 22, 2026
Squashed commits from PR reviewed in #3598

Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam dfordivam force-pushed the dfordivam/feature-cip-73-minting-delegation branch from 34f262a to 98c805c Compare January 22, 2026 05:24
@dfordivam
Copy link
Contributor Author

Closing this as the commits have been squashed and put on dfordivam/feature-cip-73-minting-delegation

@dfordivam dfordivam closed this Jan 22, 2026
dfordivam added a commit that referenced this pull request Jan 23, 2026
Squashed commits from PR reviewed in #3598

Signed-off-by: Divam <dfordivam@gmail.com>
dfordivam added a commit that referenced this pull request Jan 23, 2026
Squashed commits from PR reviewed in #3598

Signed-off-by: Divam <dfordivam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants