Added /v2/updates #1018
Merged
Added /v2/updates #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray-roestenburg-da
force-pushed
the
ray/v2-updates
branch
4 times, most recently
from
5add5c7 to
99af33d
Compare
ray-roestenburg-da
changed the title
ray-roestenburg-da
force-pushed
the
ray/v2-updates
branch
3 times, most recently
from
a0164c6 to
ee97f2e
Compare
stephencompall-DA
approved these changes
Jun 10, 2025
...rg/lfdecentralizedtrust/splice/integration/tests/ScanHistoryBackfillingIntegrationTest.scala
Outdated
Show resolved
Hide resolved
Comment on lines
1261
to
1271
Contributor
There was a problem hiding this comment.
This file will hit scalafmt
Contributor
Author
There was a problem hiding this comment.
Fixed, thanks
ray-roestenburg-da
force-pushed
the
ray/v2-updates
branch
2 times, most recently
from
0f4a230 to
31645ca
Compare
Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>
…ation/tests/ScanHistoryBackfillingIntegrationTest.scala Co-authored-by: Stephen Compall <stephen.compall@digitalasset.com> Signed-off-by: Raymond Roestenburg <98821776+ray-roestenburg-da@users.noreply.github.com>
Co-authored-by: Stephen Compall <stephen.compall@digitalasset.com> Signed-off-by: Raymond Roestenburg <98821776+ray-roestenburg-da@users.noreply.github.com>
Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>
ray-roestenburg-da
force-pushed
the
ray/v2-updates
branch
from
31645ca to
5de7411
Compare
moritzkiefer-da
approved these changes
Jun 11, 2025
| } | ||
|
|
||
| clue("Compare scan histories with each other using the v1 HTTP endpoint") { | ||
| // The v1 endpoint is deprecated, but we still have users using it |
Contributor
There was a problem hiding this comment.
do we really want to run both endpoints at the end of every test? Seems a bit overkill
Contributor
Author
There was a problem hiding this comment.
I did not notice that this runs at the end of every test? there were versions of this for v0 and v1 so I (lazily) added v2 for some coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #610
Fixes #464
basic cluster test passes
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines