Add missing dependency on splice-pulumi-common-sv #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[static] I hope this makes the pulumi operator happy again and fixes this ``` src/istio.ts(4,52): error TS2307: Cannot find module 'splice-pulumi-common-sv' or its corresponding type declarations. ``` Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
moritzkiefer-da
pushed a commit
that referenced
this pull request
Jun 23, 2025
This reverts commit 21c4bfb. Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
moritzkiefer-da
added a commit
that referenced
this pull request
Jun 23, 2025
* Revert "Add missing dependency on splice-pulumi-common-sv (#1196)" This reverts commit 21c4bfb. Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org> * Revert "[release-line-0.3.21] Limit cometbft load balancer ports to only those actually used (#1191)" This reverts commit 119434e. Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org> * Only filter cometbft ports by migrations Changing the dependency structure is too much of a mess and this seems good enough. [static] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org> --------- Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org> Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[static]
I hope this makes the pulumi operator happy again and fixes this
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines