Avoid scan rate limiting in TokenStandardCliTestDataTimeBasedIntegrationTest
#3635
Conversation
…tionTest` Fixes DACH-NY/cn-test-failures#6839 [ci] Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
...ralizedtrust/splice/integration/tests/TokenStandardCliTestDataTimeBasedIntegrationTest.scala
Outdated
Show resolved
Hide resolved
| def replaceStringsInJson(viewValue: Json) = { | ||
| val current = viewValue.spaces2SortKeys | ||
| val amuletRulesId = sv1ScanBackend.getAmuletRules().contractId.contractId | ||
| val amuletRulesId = eventually()(sv1ScanBackend.getAmuletRules().contractId.contractId) |
There was a problem hiding this comment.
what is the eventually for? If it's for handling the command failure from it not existing (not sure why it would not exist?) don't you need an eventuallySucceeds?
There was a problem hiding this comment.
Ah I meant to comment on this line before marking ready, sorry...
what is the eventually for?
Just a cheap extra safety against flakes... this is the thing that failed previously. I don't care here if scan has a random hiccup.
don't you need an eventuallySucceeds
Yes, thanks for catching that!
There was a problem hiding this comment.
The original issue was that this call failed due to rate limiting. Why is only this call being rate limited? Can we cache the amulet rules to reduce the amount of calls?
There was a problem hiding this comment.
It's just a dumb call from out of the test itself... I wouldn't overthink this tbh; we're not testing rate limiting here and the thing that is causing too much load on scan is not part of our app logic; just the test logic.
There was a problem hiding this comment.
I mean we could implement caching inside of the test but the gain should just be a minor test duration improvement... doesn't seem worth it to me.
…ation/tests/TokenStandardCliTestDataTimeBasedIntegrationTest.scala Co-authored-by: moritzkiefer-da <45630097+moritzkiefer-da@users.noreply.github.com> Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
[static] Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
[force] Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
martinflorian-da
deleted the
martinflorian-da/cntf-6839-dont-rate-limit-simtime-test
branch
Fixes https://github.com/DACH-NY/cn-test-failures/issues/6839
[ci]
Signed-off-by: Martin Florian martin.florian@digitalasset.com