From addd5b8837b833d55e1b656d0e978c06d0e18b1e Mon Sep 17 00:00:00 2001 From: Itai Segall Date: Wed, 21 Jan 2026 18:16:31 +0000 Subject: [PATCH 1/2] [ci] de-flake app rewards test Signed-off-by: Itai Segall --- .../tests/WalletManualRoundsIntegrationTest.scala | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/WalletManualRoundsIntegrationTest.scala b/apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/WalletManualRoundsIntegrationTest.scala index 566902984f..66eab05080 100644 --- a/apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/WalletManualRoundsIntegrationTest.scala +++ b/apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/WalletManualRoundsIntegrationTest.scala @@ -315,9 +315,8 @@ class WalletManualRoundsIntegrationTest aliceWalletClient.tap(20.0) - eventually(40.seconds) { - aliceValidatorWalletClient.listAppRewardCoupons() should be(empty) - } + // We might have app reward coupons still from previous tests, we'll just ignore those in later stages of this test + val initialAppRewardCoupons = aliceValidatorWalletClient.listAppRewardCoupons() clue("Check that no payment requests exist") { aliceWalletClient.listAppPaymentRequests() shouldBe empty @@ -344,7 +343,11 @@ class WalletManualRoundsIntegrationTest "Request no longer exists and validator has one unfeatured app reward", _ => { aliceWalletClient.listAppPaymentRequests() should have length 0 - inside(aliceValidatorWalletClient.listAppRewardCoupons()) { case Seq(c) => + inside( + aliceValidatorWalletClient + .listAppRewardCoupons() + .filter(!initialAppRewardCoupons.contains(_)) + ) { case Seq(c) => // Award for the first (locking) leg goes to the sender's validator // The wallet is not a featured app, so no featured app reward even if the validator party is featured! c.payload.featured shouldBe false From a8c4d69f71d23d911357251a278228a2ac195697 Mon Sep 17 00:00:00 2001 From: Itai Segall Date: Wed, 21 Jan 2026 19:11:10 +0000 Subject: [PATCH 2/2] [ci] . Signed-off-by: Itai Segall --- .../integration/tests/WalletManualRoundsIntegrationTest.scala | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/WalletManualRoundsIntegrationTest.scala b/apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/WalletManualRoundsIntegrationTest.scala index 66eab05080..e42e112f3f 100644 --- a/apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/WalletManualRoundsIntegrationTest.scala +++ b/apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/WalletManualRoundsIntegrationTest.scala @@ -41,7 +41,6 @@ import com.digitalasset.canton.logging.SuppressionRule import org.slf4j.event.Level import java.time.Duration -import scala.concurrent.duration.DurationInt import scala.jdk.CollectionConverters.* class WalletManualRoundsIntegrationTest