Move listSortedRewardCoupons to common code DbTransferInputQueries #3646
+2,509
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Divam <dfordivam@gmail.com>
- Add MintingDelegationCollectRewardsTrigger - Bump version of DbExternalPartyWalletStore - Bump version of DbUserWalletStore Squashed commits from the PR reviewed in #3470 Signed-off-by: Divam <dfordivam@gmail.com>
Squashed commits from PR reviewed in #3598 Signed-off-by: Divam <dfordivam@gmail.com>
Extracted duplicated listSortedRewardCoupons method from DbUserWalletStore and DbExternalPartyWalletStore into a new shared mixin trait. Signed-off-by: Divam <dfordivam@gmail.com>
meiersi-da
reviewed
Jan 22, 2026
Contributor
meiersi-da
left a comment
meiersi-da
left a comment
There was a problem hiding this comment.
Thanks a lot. Looks good to me.
@OriolMunoz-da : could you do the final approval on this refactoring given that you are one of the core maintainers of this piece of code, and have more Scala experience than I have?
OriolMunoz-da
approved these changes
Jan 22, 2026
Contributor
OriolMunoz-da
left a comment
OriolMunoz-da
left a comment
There was a problem hiding this comment.
lgtm, very minor comments about the comments/docs
.../common/src/main/scala/org/lfdecentralizedtrust/splice/store/db/DbTransferInputQueries.scala
Outdated
Show resolved
Hide resolved
| issuingRoundsMap: Map[Round, IssuingMiningRound], | ||
| roundToIssuance: IssuingMiningRound => Option[BigDecimal], | ||
| limit: Limit, | ||
| ccValue: SQLActionBuilder = sql"rti.issuance", |
Contributor
There was a problem hiding this comment.
is this value different anywhere? It's the same on this PR - fine to keep if it's a change necessary for a later PR
Contributor
Author
There was a problem hiding this comment.
It's same, and I am not sure if it would differ in future. Nevertheless I kept the code identical to the existing UserWallet store's to minimize diffs.
.../common/src/main/scala/org/lfdecentralizedtrust/splice/store/db/DbTransferInputQueries.scala
Outdated
Show resolved
Hide resolved
.../common/src/main/scala/org/lfdecentralizedtrust/splice/store/db/DbTransferInputQueries.scala
Outdated
Show resolved
Hide resolved
dfordivam
added a commit
that referenced
this pull request
Jan 23, 2026
Extracted duplicated listSortedRewardCoupons method from DbUserWalletStore and DbExternalPartyWalletStore into a new shared mixin trait. PR reviewed in #3646 Signed-off-by: Divam <dfordivam@gmail.com>
dfordivam
force-pushed
the
dfordivam/feature-cip-73-minting-delegation
branch
from
98c805c to
f919249
Compare
Contributor
Author
|
Closing this as commits have been squashed and put on the feature branch |
dfordivam
added a commit
that referenced
this pull request
Jan 23, 2026
Extracted duplicated listSortedRewardCoupons method from DbUserWalletStore and DbExternalPartyWalletStore into a new shared mixin trait. PR reviewed in #3646 Signed-off-by: Divam <dfordivam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3555
I implemented the deduplication slightly different than initially discussed.
Here I a new shared mixin trait with the DB sql API.
More APIs could be implemented in this for the
TransferInputStore, though I did not do that as part of this PR, to keep the changes minimal.Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines