fix for test wrappers generation for getDeploymentBinary

Signed-off-by: Nischal Sharma <[email protected]>
hyperledger-web3j · Apr 1, 2024 · e01e726 · e01e726
1 parent 16b133b
commit e01e726
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 5 deletions.
diff --git a/codegen/src/main/java/org/web3j/codegen/unit/gen/MethodFilter.java b/codegen/src/main/java/org/web3j/codegen/unit/gen/MethodFilter.java
@@ -61,9 +61,11 @@ public static List<MethodSpec> generateMethodSpecsForEachTest(Class theContract)
                 .forEach(
                         method -> {
                             String uniqueName = getUniqueName(method, methodNameCountMap);
-                            listOfMethodSpecs.add(
-                                    new MethodParser(method, theContract, uniqueName)
-                                            .getMethodSpec());
+                            if (!uniqueName.startsWith("getDeploymentBinary")) {
+                                listOfMethodSpecs.add(
+                                        new MethodParser(method, theContract, uniqueName)
+                                                .getMethodSpec());
+                            }
                         });
 
         return listOfMethodSpecs;
@@ -76,8 +78,11 @@ public static List<FunSpec> generateFunctionSpecsForEachTest(Class theContract)
                 .forEach(
                         method -> {
                             String uniqueName = getUniqueName(method, functionNameCountMap);
-                            listOfFunSpecs.add(
-                                    new FunParser(method, theContract, uniqueName).getFunSpec());
+                            if (!uniqueName.startsWith("getDeploymentBinary")) {
+                                listOfFunSpecs.add(
+                                        new FunParser(method, theContract, uniqueName)
+                                                .getFunSpec());
+                            }
                         });
 
         return listOfFunSpecs;

diff --git a/codegen/src/test/java/org/web3j/codegen/unit/gen/java/MethodParserTest.java b/codegen/src/test/java/org/web3j/codegen/unit/gen/java/MethodParserTest.java
@@ -73,4 +73,22 @@ public void testGeneratedDuplicateGreetingMethods() {
                 greetMethodSpecs.stream().anyMatch(methodSpec -> methodSpec.name.equals("greet1")));
         assertEquals(2, greetMethodSpecs.size());
     }
+
+    @Test
+    public void testGetDeploymentBinaryMethodNotGenerated() {
+        List<MethodSpec> allMethodSpecs =
+                MethodFilter.generateMethodSpecsForEachTest(greeterContractClass);
+
+        // Filter all MethodSpecs for those related to "getDeploymentBinary" method
+        List<MethodSpec> getDeploymentBinaryMethodSpecs =
+                allMethodSpecs.stream()
+                        .filter(methodSpec -> methodSpec.name.startsWith("getDeploymentBinary"))
+                        .collect(Collectors.toList());
+
+        // Ensure no MethodSpecs were generated for getDeploymentBinary method
+        assertEquals(
+                0,
+                getDeploymentBinaryMethodSpecs.size(),
+                "MethodSpec list should not contain getDeploymentBinary method");
+    }
 }
diff --git a/codegen/src/test/java/org/web3j/codegen/unit/gen/kotlin/FunParserTest.java b/codegen/src/test/java/org/web3j/codegen/unit/gen/kotlin/FunParserTest.java
@@ -78,4 +78,22 @@ public void testGeneratedDuplicateGreetingMethods() {
                         .anyMatch(methodSpec -> methodSpec.getName().equals("greet1")));
         assertEquals(2, greetFunSpecs.size());
     }
+
+    @Test
+    public void testGetDeploymentBinaryMethodNotGenerated() {
+        List<FunSpec> allMethodSpecs =
+                MethodFilter.generateFunctionSpecsForEachTest(greeterContractClass);
+
+        // Filter all FunSpecs for those related to "getDeploymentBinary" method
+        List<FunSpec> getDeploymentBinaryFunSpecs =
+                allMethodSpecs.stream()
+                        .filter(funSpec -> funSpec.getName().startsWith("getDeploymentBinary"))
+                        .collect(Collectors.toList());
+
+        // Ensure no MethodSpecs were generated for getDeploymentBinary method
+        assertEquals(
+                0,
+                getDeploymentBinaryFunSpecs.size(),
+                "MethodSpec list should not contain getDeploymentBinary function");
+    }
 }