Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ERC20.java empty statement #2059

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nogoingbac
Copy link

What does this PR do?

remove ERC20.java empty statement

Where should the reviewer start?

package org.web3j.contracts.eip20.generated ERC20.java

Why is it needed?

Remove useless comma

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

@NickSneo
Copy link
Member

Plz do the DCO, add --signoff when committing

@nogoingbac
Copy link
Author

update commit with --signoff

@NickSneo
Copy link
Member

update commit with --signoff

Do for all the commits.
f133ec4 this commit is not signedoff

@gtebrean
Copy link
Contributor

That class was generated with Web3j so removing those lines with this PR won't have any effect on the long term. @nogoingbac I you would like to help please solve the root cause problem here in Web3j which is adding those lines when the wrapper is generated.
Please let me know if you are open to do it or else I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants