fixup! Speed up ID precompile

 context ending frame instructions can read from mutable memory

Signed-off-by: Luis Pinto <[email protected]>

Author: lu-pinto

evm/src/main/java/org/hyperledger/besu/evm/operation/ReturnOperation.java

@@ -46,7 +46,8 @@ public OperationResult execute(final MessageFrame frame, final EVM evm) {
       return new OperationResult(cost, ExceptionalHaltReason.INSUFFICIENT_GAS);
     }
 
-    frame.setOutputData(frame.readMemory(from, length));
+    // can read from mutable memory as this frame's memory is going out of scope
+    frame.setOutputData(frame.readMutableMemory(from, length));
     frame.setState(MessageFrame.State.CODE_SUCCESS);
     return new OperationResult(cost, null);
   }

evm/src/main/java/org/hyperledger/besu/evm/operation/RevertOperation.java

@@ -48,7 +48,8 @@ public OperationResult execute(final MessageFrame frame, final EVM evm) {
       return new OperationResult(cost, ExceptionalHaltReason.INSUFFICIENT_GAS);
     }
 
-    final Bytes reason = frame.readMemory(from, length);
+    // can read from mutable memory as this frame's memory is going out of scope
+    final Bytes reason = frame.readMutableMemory(from, length);
     frame.setOutputData(reason);
     frame.setRevertReason(reason);
     frame.setState(MessageFrame.State.REVERT);

evm/src/test/java/org/hyperledger/besu/evm/operation/RevertOperationTest.java

@@ -22,6 +22,7 @@
 import org.hyperledger.besu.evm.gascalculator.ConstantinopleGasCalculator;
 
 import org.apache.tuweni.bytes.Bytes;
+import org.apache.tuweni.bytes.MutableBytes;
 import org.apache.tuweni.units.bigints.UInt256;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
@@ -37,14 +38,15 @@ class RevertOperationTest {
   @Mock private MessageFrame messageFrame;
   private final RevertOperation operation = new RevertOperation(new ConstantinopleGasCalculator());
 
-  private final Bytes revertReasonBytes = Bytes.fromHexString("726576657274206d657373616765");
+  private final MutableBytes revertReasonBytes =
+      Bytes.fromHexString("726576657274206d657373616765").mutableCopy();
 
   @BeforeEach
   void setUp() {
     when(messageFrame.popStackItem())
         .thenReturn(UInt256.fromHexString("0x00"))
         .thenReturn(UInt256.fromHexString("0x0e"));
-    when(messageFrame.readMemory(0, 14)).thenReturn(revertReasonBytes);
+    when(messageFrame.readMutableMemory(0, 14)).thenReturn(revertReasonBytes);
     when(messageFrame.memoryWordSize()).thenReturn(0);
     when(messageFrame.calculateMemoryExpansion(anyLong(), anyLong())).thenReturn(14L);
     when(messageFrame.getRemainingGas()).thenReturn(10_000L);