Revert "Fix: colored output is lost with 25.7.0 (#9250)" (#9321)

* Revert "Fix: colored output is lost with 25.7.0 (#9250)"

This reverts commit 42306f9.

Signed-off-by: Sally MacFarlane <[email protected]>

* changelog

Signed-off-by: Sally MacFarlane <[email protected]>

* kudos

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>

Author: macfarla

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Changelog
 
-## Unreleased
+## 25.10.0
+This is a recommended update for Hoodi users for the Fusaka hardfork.
 
 ### Breaking Changes
 
@@ -18,9 +19,9 @@
 - Add blockTimestamp to `eth_getLogs` result [#9278](https://github.com/hyperledger/besu/pull/9278)
 - Add `--ethstats-report-interval` CLI option to control ethstats reporting frequency instead of using hardcoded 5-second interval [#9271](https://github.com/hyperledger/besu/pull/9271)
 - Add `isCancelled` method to `TransactionEvaluationContext`. That way selectors could check if the block creation has been cancelled or in timeout [#9285](https://github.com/hyperledger/besu/pull/9285)
+- Performance improvements for MOD related opcodes [#9188](https://github.com/hyperledger/besu/pull/9188) thanks to [@thomas-quadratic](https://github.com/thomas-quadratic)
 
 ### Bug fixes
-- Fix loss of colored output in terminal when using `--color-enabled=true` option [#8908](https://github.com/hyperledger/besu/issues/8908)
 
 ## 25.10.0-RC2
 This RC is a pre-release, recommended update for Holesky and Sepolia users for the Fusaka hardfork.

app/src/main/java/org/hyperledger/besu/cli/logging/XmlExtensionConfiguration.java

@@ -62,7 +62,7 @@ public Configuration reconfigure() {
             new XmlExtensionConfiguration(
                 refreshedParent.getLoggerContext(),
                 refreshedParent.getConfigurationSource().resetInputStream());
-        refreshed.createConsoleAppender();
+        createConsoleAppender();
         return refreshed;
       } catch (final IOException e) {
         LoggerFactory.getLogger(Logger.ROOT_LOGGER_NAME)
@@ -90,12 +90,11 @@ private void createConsoleAppender() {
       return;
     }
 
-    final boolean colorEnabled = getColorEnabled();
     final PatternLayout patternLayout =
         PatternLayout.newBuilder()
             .withConfiguration(this)
-            .withDisableAnsi(!colorEnabled)
-            .withNoConsoleNoAnsi(!colorEnabled)
+            .withDisableAnsi(!BesuCommand.getColorEnabled().orElse(!noColorSet()))
+            .withNoConsoleNoAnsi(!BesuCommand.getColorEnabled().orElse(false))
             .withPattern(
                 String.join(
                     SEP,
@@ -106,29 +105,11 @@ private void createConsoleAppender() {
                     colorize("%msgc%n%throwable")))
             .build();
     final ConsoleAppender consoleAppender =
-        ConsoleAppender.newBuilder()
-            .setName("Console")
-            .setTarget(ConsoleAppender.Target.SYSTEM_ERR)
-            .setLayout(patternLayout)
-            .build();
+        ConsoleAppender.newBuilder().setName("Console").setLayout(patternLayout).build();
     consoleAppender.start();
-
-    // Remove existing Console appender if present to avoid duplicate output
-    if (this.getRootLogger().getAppenders().containsKey("Console")) {
-      this.getRootLogger().removeAppender("Console");
-    }
-
     this.getRootLogger().addAppender(consoleAppender, null, null);
   }
 
-  private boolean getColorEnabled() {
-    try {
-      return BesuCommand.getColorEnabled().orElse(!noColorSet());
-    } catch (NoClassDefFoundError | ExceptionInInitializerError e) {
-      return !noColorSet();
-    }
-  }
-
   private static boolean noColorSet() {
     return System.getenv("NO_COLOR") != null;
   }